Subject: Re: PDS Small Bodies Node Deep Impact and EPOXI review (fwd) From: Ludmilla Kolokolova Date: 3/18/2014 2:41 PM To: Elizabeth Warner Hi Elizabeth, Please, see below comments from Richard Chen (PDS) for the EPOXI/DI review. Please, put them in the review website under notes. Thank you. Ludmilla -- ============================================================================== From: "Chen, Richard L (398M)" To: "ludmilla@astro.umd.edu" Subject: Re: PDS Small Bodies Node Deep Impact and EPOXI review Hi, Ludmilla, this might be the lowest ratio of comments to GB I've ever had. For the directory names below, please ignore the first two characters (the letter and the .), which help me match the order on the review web page. Sorry again to back out on you physically. Thanks, Richard */document/day_of_year_calendar.lbl */document/epoxi_cal_pipeline_summ.lbl */document/epoxi_sis.lbl */document/epoxi_sis.pdf */document/instruments_hampton.lbl */document/pdsdd_epoxi.lbl */document/quaternion_desc.lbl s.di-c-hrii_hriv_mri_its-6-doc-set-v4.0/voldesc.cat Are these datasets planned for later? All of the above reference them "DIF-C-HRIV-2-EPOXI-ISON-V1.0" "DIF-C-HRIV-3/4-EPOXI-ISON-V1.0" */document/day_of_year_calendar.lbl */document/epoxi_cal_pipeline_summ.lbl */document/epoxi_sis.lbl */document/instruments_hampton.lbl */document/pdsdd_epoxi.lbl */document/quaternion_desc.lbl Not a bug: some volumes have older versions than others. Update? */document/epoxi_sis.pdf - Not a bug: in the labels for HRIV, MRI, and ITS level 3/4 data, PDS keyword PROCESSING_HISTORY_TEXT contains FLAT_PRO= FLATCONS= FLATTEMP= CALWINDW= CALWINPY= but the sample labels in the SIS's 4.4.4.1 and 4.4.4.2 do not. - p. 27: "DIF-L-HRII-3_4-EPOXI-LUNAR-CALS-V1.0" should have a / not a _ i.e. "DIF-L-HRII-3/4-EPOXI-LUNAR-CALS-V1.0" g.dii-c-its-3_4-9p-encounter-v3.0/index/index.lbl h.dif-c-hriv-3_4-9p-encounter-v3.0/index/index.lbl i.dif-c-mri-3_4-9p-encounter-v3.0/index/index.lbl n.dif-c-hrii-3_4-9p-encounter-v3.0/index/index.lbl t.dif-cal-hrii_hriv_mri-6-epoxi-temps-v3.0/index/index.lbl Not a bug: only these index.lbls (those for 9p) have keyword MISSION_NAME b.dif-c-hriv-3_4-epoxi-garradd-v1.0/calib/abscalvs/hrivis_100801_1_0_1.lbl d.dif-c-mri-3_4-epoxi-garradd-v1.0/calib/abscalvs/mrivis_100101_2_0_1.lbl d.dif-c-mri-3_4-epoxi-garradd-v1.0/calib/abscalvs/mrivis_100101_2_0_2.lbl d.dif-c-mri-3_4-epoxi-garradd-v1.0/calib/abscalvs/mrivis_100101_2_0_3.lbl d.dif-c-mri-3_4-epoxi-garradd-v1.0/calib/abscalvs/mrivis_100101_2_0_6.lbl d.dif-c-mri-3_4-epoxi-garradd-v1.0/calib/abscalvs/mrivis_100101_2_0_7.lbl d.dif-c-mri-3_4-epoxi-garradd-v1.0/calib/abscalvs/mrivis_100101_2_0_9.lbl f.dif-c-mri-3_4-epoxi-ison-v1.0/calib/abscalvs/mrivis_100101_2_0_1.lbl f.dif-c-mri-3_4-epoxi-ison-v1.0/calib/abscalvs/mrivis_100101_2_0_3.lbl f.dif-c-mri-3_4-epoxi-ison-v1.0/calib/abscalvs/mrivis_100101_2_0_6.lbl f.dif-c-mri-3_4-epoxi-ison-v1.0/calib/abscalvs/mrivis_100101_2_0_7.lbl f.dif-c-mri-3_4-epoxi-ison-v1.0/calib/abscalvs/mrivis_100101_2_0_9.lbl Missing RECORD_TYPE = FIXED_LENGTH g.dii-c-its-3_4-9p-encounter-v3.0/calib/badpix/itsvis_050409_2_2_999.lbl typo: INSTRUMENT_NAME = "DEEP IMPACT IMPACTOR TARGETING SENSOR - VISIBLE CCD"w g.dii-c-its-3_4-9p-encounter-v3.0/calib/badpix/itsvis_050409_2_4_999.lbl g.dii-c-its-3_4-9p-encounter-v3.0/calib/badpix/itsvis_050409_2_8_999.lbl "SAMPLE_BITS" = "8" should not have quotes g.dii-c-its-3_4-9p-encounter-v3.0/calib/drkmodel/*.lbl AXIS_NAME = ("SAMPLES", "LINES", "CURRENT_COEFFICIENTS") is legal, but "SAMPLE" and "LINE" (singular) are much more common. h.dif-c-hriv-3_4-9p-encounter-v3.0/catalog/dataset.cat REFERENCE_KEY_ID = "HAMPTONETAL2005" shows up twice i.dif-c-mri-3_4-9p-encounter-v3.0/calib/badpix/mrivis_020601_1_8_999.lbl" SAMPLE_BITS = "8" should not have quotes i.dif-c-mri-3_4-9p-encounter-v3.0/calib/bias/mrivis_020601_1_6.lbl missing line after INSTRUMENT_NAME = "DEEP IMPACT MEDIUM RESOLUTION INSTRUMENT i.dif-c-mri-3_4-9p-encounter-v3.0/calib/drkmodel/*.lbl AXIS_NAME = ("SAMPLES", "LINES", "CURRENT_COEFFICIENTS") is legal, but "SAMPLE" and "LINE" (singular) are much more common. i.dif-c-mri-3_4-9p-encounter-v3.0/catalog/dataset.cat REFERENCE_KEY_ID = "HAMPTONETAL2005" shows up twice i.dif-c-mri-3_4-9p-encounter-v3.0/data/rad/2005/185/mv05070405_9001012_001_ r.lbl i.dif-c-mri-3_4-9p-encounter-v3.0/data/radrev/2005/185/mv05070405_9001012_0 01_rr.lbl Is this an acceptable value: EPOXI:COMPRESSED_IMAGE_VALUE = "UNK: BAD imghdr.IMGH000.val=01111101" File document/pdsdd_epoxi.ful does not mention possible error values k.dif-c-hrii-3_4-epoxi-garradd-v1.0/calib/lindn/hriir_100928_1_1.lbl m.dif-c-hrii-3_4-epoxi-ison-v1.0/calib/lindn/hriir_100928_1_1.lbl AXIS_NAME = ("LINE_SAMPLES", "LINES", "PER_PIXEL_LINEARITY_COEFFS") is legal, but "SAMPLE" and "LINE" (singular) are much more common. n.dif-c-hrii-3_4-9p-encounter-v3.0/calib/dark/hriir_050622_3_2_6002201000.l bl SAMPLE_BITS = "32" should not have quotes n.dif-c-hrii-3_4-9p-encounter-v3.0/calib/specmap/*lbl AXIS_NAME = ("SAMPLES", "LINES", "MEASUREMENT") is legal, but "SAMPLE" and "LINE" (singular) are much more common. n.dif-c-hrii-3_4-9p-encounter-v3.0/calib/abscalir/hriir_050112_16_3_999.lbl n.dif-c-hrii-3_4-9p-encounter-v3.0/calib/flat/hriir_050112_8_0_0.lbl Missing PDS_VERSION_ID = PDS3 o.dif-c-hrii-3_4-epoxi-hartley2-v3.0/calib/lindn/*lbl AXIS_NAME = ("LINE_SAMPLES", "LINES", "PER_PIXEL_LINEARITY_COEFFS") is legal, but "SAMPLE" and "LINE" (singular) are much more common. q.dif-l-hrii-3_4-epoxi-lunar-cals-v1.0/calib/abscalir/hriir_071004_1_4_999. lbl Line 1: wPDS_VERSION_ID = PDS3 q.dif-l-hrii-3_4-epoxi-lunar-cals-v1.0/calib/flat/hriir_050112_8_0_0.lbl Missing PDS_VERSION_ID = PDS3 q.dif-l-hrii-3_4-epoxi-lunar-cals-v1.0/calib/lindn/*.lbl AXIS_NAME = ("LINE_SAMPLES", "LINES", "PER_PIXEL_LINEARITY_COEFFS") is legal, but "SAMPLE" and "LINE" (singular) are much more common. s.di-c-hrii_hriv_mri_its-6-doc-set-v4.0/voldesc.cat Lines 175 and 176: "C/GARRADD (2009 P1)", "C/ISON (2012 S1)", should be "GARRADD.CAT", "ISON.CAT", t.dif-cal-hrii_hriv_mri-6-epoxi-temps-v3.0/data/.../*.lbl None have MISSION_PHASE_NAME, SPACECRAFT_CLOCK_START_COUNT, or _STOP_COUNT. No objection if that makes sense and was deliberate. t.dif-cal-hrii_hriv_mri-6-epoxi-temps-v3.0/data/raw/mri/mri_raw_t_temps_201 0.lbl typo: sRECORD_BYTES = 157 Please let me know when to add these keywords to the PDS data dictionary EPOXI:* Please let me know when to add these values to the PDS data dictionary MISSION_PHASE_NAME: "CRUISE 3", "9P ENCOUNTER" COMPRESSOR_ID: "3" DOCUMENT_TOPIC_TYPE: "DEEP IMPACT", "ARCHIVE INTERFACE CONTROL DOCUMENT", "DATA_LOG", "DATA MANAGEMENT/ARCHIVE PLAN", "INSTRUMENT THERMAL-VACUUM TEST PLAN", "PROJECT DATA MANAGEMENT PLAN" PRODUCT_TYPE = "RAW"