*xml (for all bundles) - The recommended subdirectory structure is: browse[_*]/ calibration[_*]/ context[_*]/ data[_*]/ document[_*]/ geometry[_*]/ miscellaneous[_*]/ xml_schema[_*]/ spice_kernels[_*]/ - The standard PDS preamble and root tag (the header), molded for BOPPS a) b) d) f) h) Line j: Anne has argued against this. That's SBN's call. Lines b, d, f: perhaps every label in these bundles lacks lines c, e, g. Lines f, t: Sean says the schema will be accessible at those URLs Lines l, s: we want to remove "/v1" from the namespace for missions - Here are the templates for the context LIDs in this review: 1) urn:nasa:pds:context:investigation:individual.none 2) urn:nasa:pds:context:instrument_host:earth-based.- 3) urn:nasa:pds:context:facility:observatory. 4) urn:nasa:pds:context:instrument:. OR if instrument is used at only 1 telescope at facilityID urn:nasa:pds:context:instrument:.- 1.gbo-kpno/ - Here are the context LIDs based on the template above: 1) urn:nasa:pds:context:investigation:individual.none 2) urn:nasa:pds:context:instrument_host:earth-based.kpno-m4mt 3) urn:nasa:pds:context:facility:observatory.kpno 4) urn:nasa:pds:context:instrument:echspec.kpno Note that #1 replaces urn:nasa:pds:context:investigation:individual_investigation.none Note that #2 replaces urn:nasa:pds:context:telescope:telescope.kpno-4mmt (in bundle.xml) urn:nasa:pds:telescope:telescope.kpno-m4mt (elsewhere) Note that #3 replaces urn:nasa:pds:context:facility:facility.kpno (in bundle.xml) urn:nasa:pds:facility:facility.kpno (elsewhere) Note that #4 replaces urn:nasa:pds:context:instrument:instrument.kpno-echspec (most places) urn:nasa:pds:instrument:instrument.kpno-echspec (in telescope_docs/*xml) - In each file, please add the lid_reference (data_to_target) to target urn:nasa:pds:context:target:comet.c-hyakutake_1996_b2 1.gbo-kpno/hyakutake_spectra/collection_inventory.csv - Not all lines end in CRLF (though some do) - Does not list the LID from gbo-kpno/hyakutake_spectra/documents/4mechspec.xml urn:nasa:pds:gbo-kpno:hyakutake_spectra:echspec_manual::1.0 - DPH 8.0: "Basic products of similar type and content are grouped into a collection." This collection groups Product_Observationals and Product_Documents. Mitch Gordon of PDS says this is ok, but perhaps this collection can be split in two? 1.gbo-kpno/hyakutake_spectra/data/*.xml - 27 should be 28 1.gbo-kpno/hyakutake_spectra/data/*.tab - The last line does not end in CRLF. 1.gbo-kpno/hyakutake_spectra/data/offset_10_arcsec.tab - Line 21518 needs to be split: 4439.8745 , -1.2303975e-15 4439.9517 , -5.3005169e-154440.0557 , -8.3680622e-15 4440.1338 , -6.4354977e-15 Doing so requires incrementing 22455 in the .xml 1.gbo-kpno/hyakutake_spectra/data/offset_7_arcsec.tab - Line 1859 has an extra space at the end 1.gbo-kpno/telescope_documents/collection.csv - The LIDs here don't match what's in the xml files P,urn:nasa:pds:gbo-kpno:document:echspec_description::1.0 P,urn:nasa:pds:gbo-kpno:document:kpno_description::1.0 P,urn:nasa:pds:gbo-kpno:document:m4mt_description::1.0 vs. logical_identifiers urn:nasa:pds:gbo-kpno:telescope_documents:echspec_description urn:nasa:pds:gbo-kpno:telescope_documents:kpno_description urn:nasa:pds:gbo-kpno:telescope_documents:m4mt_description 2.unidentified_emissions/emissions/*/*.tab - None of these has CRLF as the line terminator. - record_length should be set to the length of a record, not the file. Don't forget to account for the CRLF, e.g. in borrelly_data.xml, 6496 should be 57 This value for the 23 files should be 57 76 56 81 119 58 63 128 51 64 54 75 137 57 74 115 145 139 125 129 119 56 84 2.unidentified_emissions/emissions/*/*.xml - Please change lid_reference urn:nasa:pds:context:investigation:individual_investigation.none to urn:nasa:pds:context:investigation:individual.none 2.unidentified_emissions/emissions/borrelly/borrelly_*.xml - Please change the lid_references from urn:nasa:pds:facility:facility.saoras urn:nasa:pds:telescope:telescope.saoras-6mt urn:nasa:pds:context:instrument:instrument.saoras-mpfs to urn:nasa:pds:context:instrument_host:earth-based.saoras-6mt urn:nasa:pds:context:facility:observatory.saoras urn:nasa:pds:context:instrument:mpfs.saoras - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.19p-borrelly_1_1904_y2 2.unidentified_emissions/emissions/borrelly/borrelly_data.xml - Line 136: element description must have a non-blank value 2.unidentified_emissions/emissions/bradfield/bradfield_*.xml - Please change the lid_references from urn:nasa:pds:facility:facility.asiago urn:nasa:pds:telescope:telescope.asiago-122cmt urn:nasa:pds:telescope:telescope.asiago-182cmt urn:nasa:pds:context:instrument:instrument.asiago-prispec urn:nasa:pds:context:instrument:instrument.asiago-graspec to urn:nasa:pds:context:instrument_host:earth-based.asiago-122cmt urn:nasa:pds:context:instrument_host:earth-based.asiago-182cmt urn:nasa:pds:context:facility:observatory.asiago urn:nasa:pds:context:instrument:prispec.asiago urn:nasa:pds:context:instrument:graspec.asiago - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.c-bradfield_1980_y1 though SBN may set the final part of this LID since it is new. 2.unidentified_emissions/emissions/brorsen_metcalf/brorsen_metcalf.xml - Please change the lid_references from urn:nasa:pds:facility:facility.lick urn:nasa:pds:telescope:telescope.lick-3mst urn:nasa:pds:context:instrument:instrument.lick-hes to urn:nasa:pds:context:instrument_host:earth-based.lick-3mst urn:nasa:pds:context:facility:observatory.lick urn:nasa:pds:context:instrument:hes.lick - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.23p-brorsen-metcalf_1_1847_o1 2.unidentified_emissions/emissions/collection_description.txt - "the value '999.99999' to represent there is no data for that entry." To implement this programmatically, in each data .xml file, add 999.99999 or perhaps "not_applicable_constant" instead. 2.unidentified_emissions/emissions/collection_description.xml - This logical_identifier is not an Internal_Reference in collection.xml (with reference_type = collection_to_document) nor listed in collection_inventory.csv: urn:nasa:pds:unidentified_emissions:emissions:collection_description 2.unidentified_emissions/emissions/collection_description.txt~ - If this file is intentionally there, I have more comments. 2.unidentified_emissions/emissions/devico/devico_*.xml - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.122p-devico_1_1846_d1 2.unidentified_emissions/emissions/giacobinizinner/giacobinizinner.xml - Please change the lid_references from urn:nasa:pds:facility:facility.sao-ras urn:nasa:pds:telescope:telescope.sao-6mt urn:nasa:pds:context:instrument:instrument.sao-mpfs to (assuming this data came from the same facility, telescope, and instrument as borrelly/ above): urn:nasa:pds:context:instrument_host:earth-based.saoras-6mt urn:nasa:pds:context:facility:observatory.saoras urn:nasa:pds:context:instrument:mpfs.saoras - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.21p-giacobini-zinner_1_1900_y1 - After the first field, the field_locations are wrong (too high). The record is only 128 bytes, but the last field_location is 161. The values should be 1 8 20 32 45 57 64 76 88 94 106 118 - 4 should be 20 2.unidentified_emissions/emissions/hale_bopp/hale_bopp_zhang_*.xml - Please change the lid_references from urn:nasa:pds:facility:facility.bao urn:nasa:pds:telescope:telescope.bao-2p16mt urn:nasa:pds:context:instrument:instrument.bao-ces to urn:nasa:pds:context:instrument_host:earth-based.bao-2p16mt urn:nasa:pds:context:facility:observatory.bao urn:nasa:pds:context:instrument:ces.bao - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.c-hale-bopp_1995_o1 2.unidentified_emissions/emissions/hyakutake/*.xml - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.c-hyakutake_1996_b2 2.unidentified_emissions/emissions/hyakutake/chyakutake_1996_b2_morrison_*.xml: - Please change the lid_references from urn:nasa:pds:facility:facility.ritobs urn:nasa:pds:telescope:telescope.ritobs-ro1mt urn:nasa:pds:context:instrument:instrument.ritobs-ffes to urn:nasa:pds:context:instrument_host:earth-based.ritobs-ro1mt urn:nasa:pds:context:facility:observatory.ritobs urn:nasa:pds:context:instrument:ffes.ritobs 2.unidentified_emissions/emissions/hyakutake/chyakutake_1996_b2_morrison_observations.xml - Line 40: element description must have a non-blank value 2.unidentified_emissions/emissions/hyakutake/chyakutake_1996_b2_wyckoff.xml - Please change the lid_reference from urn:nasa:pds:facility:facility.kpno to urn:nasa:pds:context:facility:observatory.kpno - Where are the context LIDs for instrument and telescope/instrument_host? - Line 220: element description must have a non-blank value 2.unidentified_emissions/emissions/hyakutake/chyakutake_ahearn_*.xml - Please change the lid_references from urn:nasa:pds:facility:facility.kpno urn:nasa:pds:telescope:telescope.kpno-m4mt urn:nasa:pds:context:instrument:instrument.kpno-echspec to urn:nasa:pds:context:instrument_host:earth-based.kpno-m4mt urn:nasa:pds:context:facility:observatory.kpno urn:nasa:pds:context:instrument:echspec.kpno These are the same values as for the gbo-kpno bundle. 2.unidentified_emissions/emissions/ikeya_zhang/ikeya_zhang.xml - Please change the lid_references from urn:nasa:pds:facility:facility.orm urn:nasa:pds:telescope:telescope.orm-tng urn:nasa:pds:context:instrument:instrument.orm-sarg to urn:nasa:pds:context:instrument_host:earth-based.orm-tng urn:nasa:pds:context:facility:observatory.orm urn:nasa:pds:context:instrument:sarg.orm - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.153p-ikeya-zhang though SBN may set the final part of this LID since it is new. 2.unidentified_emissions/emissions/kohoutek/kohoutek_lick.xml - Please change the lid_references from urn:nasa:pds:facility:facility.lick urn:nasa:pds:telescope:telescope.lick-1mrt urn:nasa:pds:context:instrument:instrument.lick-cassspec to urn:nasa:pds:context:instrument_host:earth-based.lick-1mrt urn:nasa:pds:context:facility:observatory.lick urn:nasa:pds:context:instrument:cassspec.lick - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.kohoutek_1993 though SBN may set the final part of this LID since it is new. 2.unidentified_emissions/emissions/kohoutek/kohoutek_wise.xml - Please change the lid_references from urn:nasa:pds:facility:facility.wise urn:nasa:pds:telescope:telescope.wise-3mrt urn:nasa:pds:context:instrument:instrument.wise-coudespec to urn:nasa:pds:context:instrument_host:earth-based.wise-3mrt urn:nasa:pds:context:facility:observatory.wise urn:nasa:pds:context:instrument:coudespec.wise - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.kohoutek_1993 though SBN may set the final part of this LID since it is new. 2.unidentified_emissions/emissions/linear_and_neat/linear.xml - I don't know mission FUSE, but please change the LID urn:nasa:pds:spacecraft:spacecraft.fuse to urn:nasa:pds:context:instrument_host:spacecraft.fuse - Add lid_reference to the instrument - Is it justifiable to have lid_reference urn:nasa:pds:context:investigation:individual.none instead of urn:nasa:pds:context:investigation:mission.fuse - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.c-linear_2001_a2 though SBN may set the final part of this LID since it is new. 2.unidentified_emissions/emissions/linear_and_neat/neat.xml - I don't know mission FUSE, but please change the LID urn:nasa:pds:spacecraft:spacecraft.fuse to urn:nasa:pds:context:instrument_host:spacecraft.fuse - Add lid_reference to the instrument - Is it justifiable to have lid_reference urn:nasa:pds:context:investigation:individual.none instead of urn:nasa:pds:context:investigation:mission.fuse - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.c-neat_2001_q4 though SBN may set the final part of this LID since it is new. - 4 should be 15 2.unidentified_emissions/emissions/swift_tuttle/swift_tuttle.xml - Please change the lid_references from urn:nasa:pds:facility:facility.lick urn:nasa:pds:telescope:telescope.lick-0p6mcat urn:nasa:pds:context:instrument:instrument.lick-hes to urn:nasa:pds:context:instrument_host:earth-based.lick-0p6mcat urn:nasa:pds:context:facility:observatory.lick urn:nasa:pds:context:instrument:hes.lick I assume this is the same instrument as used for brorsen_metcalf/. - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.109p-swift-tuttle_1_1862_o1 2.unidentified_emissions/emissions/whipple_fedtke_tevzadze/*.xml - The two files have lid_references that presumably refer to the same thing urn:nasa:pds:context:instrument:instrument.dao-spus urn:nasa:pds:context:instrument:instrument.spus - Please change the lid_references from urn:nasa:pds:facility:facility.dao urn:nasa:pds:context:instrument:instrument.dao-spus to urn:nasa:pds:context:facility:observatory.dao urn:nasa:pds:context:instrument:spus.dao - Where is the context LIDs for telescope/instrument_host? - Add the lid_reference to the target: urn:nasa:pds:context:target:comet.1942g-whipple-fedtke-tevzadze though SBN may set the final part of this LID since it is new. 2.unidentified_emissions/emissions/whipple_fedtke_tevzadze/whipple_fedtke_tevzadze_data.tab - Please replace or remove the tabs 3.cara_data - We're assuming bundle LID "urn:nasa:pds:xxxxx" is a placeholder. Suggested LIDs: bundle: urn:nasa:pds:cara collection1: urn:nasa:pds:cara:data product: urn:nasa:pds:cara:data:116p collection2: urn:nasa:pds:cara:document product: urn:nasa:pds:cara:document:cara_observer_code 3.cara_data/cara_data/data/ - The string "data" is repeated a lot there. I suggest renaming the top level to "cara/", as almost any bundle X could be named "X_data". Per the general comments on directory structure, the middle directory could be named just "data". The third directory - I don't know how to generally characterize the products in them. It would be legal not to have that subdir at all since there are so few files. 3.cara_data/cara_data/data/*.tab - None of these has CRLF as the line terminator. - record_length should be set to the length of a record, not the file. Don't forget to account for the CRLF, e.g. in borrelly_data.xml, This value for the 6 files should be 159 160 247 196 167 211 3.cara_data/cara_data/data/*.xml - The preamble is entirely missing the PDS schematron declaration (line b from the top of the comments), not just the schematypens. - logical_identifier can not have upper case letters - carriage-return line-feed should be Carriage-Return Line-Feed - is it possible/worthwhile to determine and list the lid_references to the instrument, instrument_host, and/or facility? - Add the lid_reference to the target (sorry, tired of listing files) urn:nasa:pds:context:target:comet.116p-wild (new, changeable after last :) urn:nasa:pds:context:target:comet.174p-echeclus (new, changeable) urn:nasa:pds:context:target:comet.29p-schwassmann-wachmann_1_1927_v1 urn:nasa:pds:context:target:comet.67p-churyumov-gerasimenko_1_1969_r1 urn:nasa:pds:context:target:comet.2004_q2 (new, changeable) urn:nasa:pds:context:target:comet.2013_a1 (new, changeable) - add Primary_Result_Summary between Time_Coordinates and Investigation_Area. Supposedly, the PDS product search will rely on values there. 3.cara_data/cara_data/data/67P.tab - Line 1371: the lines shrink by 1 character in the second to last field Actually, the converse is probably true, that the previous lines were one char too wide in that field and that record_length should be 1 lower. 3.cara_data/cara_data/data/C2013A1.tab - Line 79: 1 should be 11 Actually, the converse is probably true, that the previous lines were one char too wide in that field and that record_length should be 1 lower. FOR THE REMAINING DATASETS: - The overall bundle.xml is required but missing. - Each collection's collection.xml is required but missing, though the collection.csv is there. - It would be nice but not necessary for all the labels to use the same version of PDS4 schema. Here the products are 1301; the collections and bundles, 1400 - Balloon The products all use this, but it is currently not a legal value. Adding that requires going through the PDS CCB process. - Add the lid_reference to the target. We can retrieve the LIDs given the names of the various targets, e.g. urn:nasa:pds:context:target:asteroid.1_ceres - The context LIDs: urn:nasa:pds:context:investigation:mission.bopps urn:nasa:pds:context:instrument_host:earth-based.sto.bopps urn:nasa:pds:context:facility:observatory.gondola.bopps urn:nasa:pds:context:instrument:birc.bopps - In *.xml, add Observation_Area/Primary_Result_Summary. Supposedly, the PDS product search will rely on values there. 4.biassub/hd46300/skybackground/fw1/skx1_1_180825433_n007_-003b.xml 4.biassub/hd46300/skybackground/fw4/skx1_4_180959714_n007_-003b.xml - 0.000 The minimum value is 3.0E0. Perhaps this is related to the odd filename. 5.calibrated/hd196724/all_filters/setb/fw9/ - This directory is empty (which is probably legal). Is that intentional? 6.documents/collection.xml - This file is required but missing. This should be two collections: one for documents, one for schema (DPH 8.0: "Basic products of similar type and content are grouped into a collection."). 6.documents/bopps_1000.xml - The root tag should be Product_XML_Schema, not Product_Document, as in https://pds.nasa.gov/pds4/pds/v1/PDS4_PDS_1400.xml - Lines 58 and 62 are illegal: Schematron XML Schema (XSD) Their equivalent would be legal if the root were Product_XML_Schema - bopss_1000.xsd should be bopps_1000.xsd 6.documents/bopps_1000.xsd - we want to remove "/v1" from the namespace for missions, so change targetNamespace="http://pds.nasa.gov/pds4/mission/bopps/v1" xmlns:bopps="http://pds.nasa.gov/pds4/mission/bopps/v1" to targetNamespace="http://pds.nasa.gov/pds4/mission/bopps" xmlns:bopps="http://pds.nasa.gov/pds4/mission/bopps" 6.documents/boppssis.pdf - Section 3.8: I find the table descriptions of data in 3.7 easier to read than the xml files in this section. I recommend adding such info to this section if fitting, or a mention that the data is a FITS image - I see that the filename conventions are in the *description.txt. Where are the directories' hierarchies described? 6.documents/boppssis.xml - BOPPSSIS.pdf should be boppssis.pdf 7.groundcalibration/status/relays/*.xml: - Line 80: ASCII_Date_Time is illegal. Probably should be ASCII_Date_Time_YMD_UTC 7.groundcalibration/status/temperature/*.xml: - Line 81: ASCII_Date_Time_UTC is illegal. Probably should be ASCII_Date_Time_YMD_UTC 7.groundcalibration/photon_transfer_test/*.xml: - Lines 128, 138, 148, 158 are illegal: ASCII_Short_String_Collapsed The intent is probably something like 'ASCII_Directory_Path_Name', 'ASCII_File_Name', or 'ASCII_File_Specification_Name', but the .tab's values look like the roots of filename, e.g. st20_1_000809509_p002_0003r Is it possible for *.tab to have real filenames? If not, maybe ASCII_String. 8.raw/hd46300/skybackground/fw1/skx1_1_180825433_n007_0000r.xml 8.raw/hd46300/skybackground/fw4/skx1_4_180959714_n007_0000r.xml - Line 58: 0.000 The minimum value is 3.0 9.scoadded/flatfield/hd133772/ccha_0_6_0304_f_0244.xml (& probably others) - Lines 129 and 135 have values too low by 2, maybe due to CRLF a.status/pointing/*.xml, a.status/relays/*.xml - Line 80: ASCII_Date_Time is illegal. Probably should be ASCII_Date_Time_YMD_UTC a.status/status_description.xml - The logical_identifier looks like an incomplete copy/paste: urn:nasa:pds:bopps:groundcalibration:description should be urn:nasa:pds:bopps:status:description a.status/temperature/*.xml - Line 81: ASCII_Date_Time_UTC is illegal. Probably should be ASCII_Date_Time_YMD_UTC