Notes on 67/P Shape Model Review
Boris Semenov, 31 January 2016


Major:

-  data/dsk/spc_esa/mtp009/cshp_dv_047_02_hires_bds.bds

   *  was made with incorrect DATA_CLASS (1 instead of 2)

   *  has inadequate internal comments

   *  strongly recommend replacing it with ROS_CG_M004_NSPCESA_U_V1.BDS 
      from ROS SPICE data set.


-  data/dsk/spc_esa/mtp009/cshp_dv_047_02_hires_bds.lbl

   *  is very different from other DSK labels.

   *  re-make it to be like other DSK labels.


-  data/dsk/*/*/*.lbl (except cshp_dv_047_02_hires_bds.lbl)

   *  change RECORD_TYPE = STREAM to what's ROS SPICE data set DSK labels

      RECORD_TYPE                = FIXED_LENGTH
      RECORD_BYTES               = 1024

   *  change KERNEL_TYPE = DIGITAL_SHAPE to what's ROS SPICE data set 
      DSK labels

      KERNEL_TYPE                = SHAPE

   *  change Boris Semenov to Nathaniel Bachman in PRODUCER_FULL_NAME 


-  voldesc.cat 

   *  DATA_SET_ID does not match labels. It is 
      RO-C-OSINAC/OSIWAC-5-67P-SHAPE-V1.0 instead of
      RO-C-MULTI-5-67P-SHAPE-V1.0.

   *  prefix "ROOSI" in for the volume and volume set ID suggests that
      data set provided on the volume is based just on OSIRIS data.
      This is not correct.


-  catalog/dataset.cat

   *  DATA_SET_ID does not match labels. It is
      RO-C-OSINAC/OSIWAC-5-67P-SHAPE-V1.0 instead of
      RO-C-MULTI-5-67P-SHAPE-V1.0.


Minor:

-  aareadme.txt 

   *  "Two different modeling groups ...": is it two or three?

   *  shows file names in uppercase while files are lowercase which is
      inconvenient

   *  does not mention catalog/navcam_inst.cat
   
   *  does not mention document/rmoc_eaicd.pdf

   *  does not mention RMOC STL model under extras/


-  extraneous files:

   *  catalog/._dataset.cat

   *  document/preview_images/._standard_views.lbl


-  document/preview_images/

   *  does not include preview images for the SPC_ESA model


-  document/docinfo.txt

   *  does not mention labels (.lbl)


-  extras/extrinfo.txt 

   *  does not mention STL model label


-  extras/cshp_dv_047_02_hires_stl.stl

   *  why is "STL formatted version of the RMOC MTP009 shape model" 
      under extras/ but not under data/?


-  index/indxinfo.txt

   *  does not mention labels


Notes:

-  all DSK except cshp_dv_047_02_hires_bds.bds are OK. They are copies
   of validated, archived DSK from ROS SPICE data set

-  cshp_dv_047_02_hires_bds.bds contains the same data as
   ROS_CG_M004_NSPCESA_U_V1.BDS from ROS SPICE data set but has
   incorrect DATA_CLASS.

-  all triplate model are identical to those that NAIF used to make
   DSK in November 2015. At that time NAIF did sanity checks on these 
   (all passed) but did not keep notes.

-  in November DSKs we imported into Cosmographia and visually checked.
   The check suggested that they were in the same references frame.

-  no attempt was made to carefully read documentation and catalog files
   and to check triplate labels.
   

End.