Liens list for New Horizons SWAP delta review March 2017. Last edited by SBN:Tilden Barnes on 2017-04-19 Affected Datasets: NH-J-SWAP-2-JUPITER-V4.0 NH-J-SWAP-3-JUPITER-V4.0 NH-P-SWAP-2-PLUTO-V2.0 NH-P-SWAP-3-PLUTO-V2.0 NH-X-SWAP-2-PLUTOCRUISE-V3.0 NH-X-SWAP-3-PLUTOCRUISE-V3.0 file: 'calib/background_009_dac.lbl' --> SJ: line 89 has a line length > 80. Remove the extra white space. This was caused when fixing a typo from prior review. file: 'catalog/dataset.cat' --> In the DATA_SET_DESC under the Review section, it states that the SWAP data was certified for scientific use in 2016-12 peer review. That is not true. It was certified on 2017-03-19. --> The CITATION_DESC year will need to be updated from '2016' to '2017' for those data sets no released in 2016, which include these SWAP data sets. file: 'catalog/swap.cat' --> line 259 contains two non-ascii characters. Do not replace them with ascii double quotes, but ascii single quotes, if using any quotes. files: 'data/*/*0x586_sci.fit'\ --> The histogram data consists of two linear arrays. In the Primary HDU is stored the number of number of times a sample was accumulated at each index of the histogram. Stored in the Histogram HDU is the sum of the counts for each index. Thus, there should be 0 counts stored in the histogram at each location where there is no samples made. The fits file ('swa_0283651232_0x586_sci.fit'), shows an example where there are accumulated counts in the histogram, but no samples made.\ --> ==> ** Updated swap.cat\ --> ==> RF: The new information in the swap.cat file describing the Histogram data format is adequate to understand the Histogram data. However, the processed 0x586 data shows an issue. (See slides 15-20 in Frahm_SWAP_March2017_Final.pdf). In future releases, I would recommend that the discussion on the contents of the Histogram be migrated into the SWAP portion of the ICD since this is the document describes the 0x586 file format. However, this format is adequate for this delta review. There are limited bad FITs data files in the 0x586 data set; however, the amount is not exorbitant. There could be many reasons why these files show unreasonable values for the Histogram and the investigators should review the 0x586 data to determine the source and fix the issue if at all possible. The issue does not influence the rest of the data which is a scientifically valid product. Thus, I would recommend removing these bad data files from the archive and then releasing these data to the public. file: 'document/data_summary_plots/swap_*_datasumm.lbl' --> Emily notes there is a problem in the document directory in that a label that lists PNG files does not list the same number of files as actually found in the directory. (Already in "notes" [?] with other comments.)\ --> ==> ** See 73. Fixed.\ --> ==> SBN:TB - PC okay. PE has too many. Jup has too few. Issue not resolved. --> ==> SJ: There may be an issue with some of the files being misnamed, and so adding to the count of files. directory: 'document/data_summary_plots/'\ --> Multiple summary plots are generated in the data set. But some are black. Is this No Data or Plot Failure?\ --> ==> ** Fixed. Made a note in the label file and swap.cat that this is expected behavior.\ --> ==> RF: Words are fine and explain empty science data summary plots, but not the following two data plots which show no data: --> ==> --> SWAPdelta/nh-p-swap-2-pluto v2.0/document/data_summary_plots/swap_001day_201507042359.png --> ==> --> SWAPdelta/nh-p-swap-2-pluto-v2.0/document/data_summary_plots/swap_001day_201507052359.png --> ==> --> Recommendation – Remove these two data files. files: '*pluto*/document/docinfo.txt' --> RF: In PE and PC, there is a duplicate line under NH_MISSION_TRAJECTORY.LBL: "please read the label for more detail" file: 'document/swap_cal.pdf' --> pg 1, par 1: add comma: "geometric factor, the energy" --> pg 9, #6 par 1: typo: "the the" --> ==> ** This file will be updated with the updated Calibrations for the P3 delivery. --> ==> SJ: These are trivial corrections that shouldn’t have to wait until the next scheduled release. Please take the minute and a half it takes to fix these error now. file: 'document/soc_inst_icd.pdf' --> SBN:TB - Should we include the updated copy found in other instrument data sets? DEFERRED LIENS to P3 delivery ============================= 73.nh-x-swap-2-plutocruise-v3.0/data/20081005_008555/swa_0085550432_0x586_eng.lbl & others\ 74.nh-x-swap-3-plutocruise-v3.0/data/20081005_008555/swa_0085550432_0x586_sci.lbl & others\ 75.nh-p-swap-2-pluto-v2.0/data/20150115_028359/swa_0283599968_0x586_eng.lbl & others\ 76.nh-p-swap-3-pluto-v2.0/data/20150115_028359/swa_0283599968_0x586_sci.lbl & others\ 71.nh-j-swap-2-jupiter-v4.0/document/samples/*.lbl\ 72.nh-j-swap-3-jupiter-v4.0/document/samples/*.lbl\ - Can you make this value more descriptive:\ AXIS_NAME = AXIS_1\ ** Deferred to P3. Note that AXIS_NAME is an optional field. We will ask the SWAP team for a more meaningful value, and the ICD does describe these fields too.\ ==> SJ: Deferral request accepted, will require some effort/interaction with team – please keep on liens list files: 'data/*/*0x584_sci.*\ --> For extension 14 (SPICE Orbit Attitude Calc), the PDS label column names/descriptions and fits headers describe calculations for Jupiter instead of Pluto. Is this correct?\ --> ==> ** This is correct for now. We will be updating the column names and values in the extension for Pluto as part of P3.\ --> ==> SJ: 0x584_sci*lbl Update column names/values as part of P3 as promised