Notes on ro-c-multi-5-67p-shape-v2.0 with checksum.tab dated 07/13/17 BVS/NAIF, 08/21/17 -------------------------------------------------------------------- Executive summary: -------------------------------------------------------------------- -- "show-stoppers" items that must be fixed: B2 -- including old ESAC-made DSKs instead of new NAIF-made DSKs) B5 -- moving NOTE to SPICE_KERNEL object in DSK labels B6 -- missing PRODUCT_VERSION_TYPE in DSK labels C5 C11 -- description re SHAP5 offset raises many questions that must be addressed or it should be removed. -- items strongly recommended to be addressed: B7 -- setting NAIF_INSTRUMENT_ID to actual IDs instead of "N/A" B8 -- missing UNIT in coordinate columns in some triplate labels B9 -- missing INSTRUMENT_ID in some triplate labels C6 -- no description of SPG in user_guide.asc C7 -- no advice on selecting SPC vs SPG vs ESA/RMOC models in user_guide.asc C16 -- missing specific info about applicability of rotation parameters given at the bottoms of all *_model_info.asc -- questions, items, typos that are desirable to be addressed: all other items. -------------------------------------------------------------------- A. catalog/ directory -------------------------------------------------------------------- catalog/dataset.cat catalog/navcam_inst.cat A1. REFERENCE_KEY_ID = "N/A". Are there no references that can be used in these catalogs? A2. did not attempt to carefully review any catalogs -------------------------------------------------------------------- B. data/ directory -------------------------------------------------------------------- data/spice_dsk/*/*/*.bds B1. all DSKs except data/spice_dsk/spc_esa/mtp019/cshp_dv_130_01_lores_bds.bds data/spice_dsk/spc_esa/mtp019/cshp_dv_130_01_hires_bds.bds are identical to files included or staged to be included in the ROS SPICE data set (RO/RL-E/M/A/C-SPICE-6-V1.0). They have been created and validated by NAIF. B2. two DSKs data/spice_dsk/spc_esa/mtp019/cshp_dv_130_01_lores_bds.bds data/spice_dsk/spc_esa/mtp019/cshp_dv_130_01_hires_bds.bds contain the same data (which was verified by comparing dumps produced by DSKEXP) as the DSKs http://naif.jpl.nasa.gov/pub/naif/ROSETTA/misc/mcosta/ROS_CG_K104_NSPCESA_U_V1.BDS http://naif.jpl.nasa.gov/pub/naif/ROSETTA/misc/mcosta/ROS_CG_M002_NSPCESA_U_V1.BDS that were created on May 16, 2016 per request from Maud Barthelemy, specifically for inclusion in this data set and ROS SPICE data set. Instead of these NAIF-made DSKs, old DSKs made during operations were renamed and included. These old DSKs were made with some incorrect MKDSK setup parameters (DATA_CLASS = 1 instead of 2), with non-optimal voxel scales (4.0 and 5 instead if 3.0 and 5) and have sub-par comments. These two DSKs should be replaced with NAIF-made versions provided in the URLs below. data/*/*/*/*.lbl B3. in all labels for DSK and non-DSK products that were present in V1.0 "RO-C-MULTI-5-67P-SHAPE-V1.0:" in used in the CITATION_DESC. Is this intentional? B4. PRODUCT_IDs have different style, some are with and some are without file extension. While not a problem as they are all unique, this looks messy. data/spice_dsk/*/*/*.lbl B5. SPICE_KERNEL object does not allow NOTE keyword. It allows only DESCRIPTION, INTERCHANGE_FORMAT, and KERNEL_TYPE. Moving NOTE from the main label area to SPICE_KERNEL in order to add a different NOTE keyword is an error. This was done in all DSK labels except data/spice_dsk/spc_esa/mtp009/cshp_dv_047_01_lores_bds.lbl data/spice_dsk/spc_esa/mtp009/cshp_dv_047_02_hires_bds.lbl data/spice_dsk/spc_esa/mtp019/cshp_dv_130_01_hires_bds.lbl data/spice_dsk/spc_esa/mtp019/cshp_dv_130_01_lores_bds.lbl Remove NOTE from SPICE_KERNEL object. B6. PRODUCT_VERSION_TYPE is not included in these DSK labels: data/spice_dsk/spc_esa/mtp009/cshp_dv_047_01_lores_bds.lbl data/spice_dsk/spc_esa/mtp009/cshp_dv_047_02_hires_bds.lbl data/spice_dsk/spc_esa/mtp019/cshp_dv_130_01_hires_bds.lbl data/spice_dsk/spc_esa/mtp019/cshp_dv_130_01_lores_bds.lbl data/spice_dsk/spg_dlr/shap4s/cg_dlr_spg_shap4s_050k.lbl data/spice_dsk/spg_dlr/shap4s/cg_dlr_spg_shap4s_100k.lbl data/spice_dsk/spg_dlr/shap4s/cg_dlr_spg_shap4s_1m.lbl data/spice_dsk/spg_dlr/shap4s/cg_dlr_spg_shap4s_200k.lbl data/spice_dsk/spg_dlr/shap4s/cg_dlr_spg_shap4s_4m.lbl Add this keyword to these labels. B7. NAIF_INSTRUMENT_ID is set to "N/A" in all labels except data/spice_dsk/spc_esa/mtp009/cshp_dv_047_01_lores_bds.lbl data/spice_dsk/spc_esa/mtp009/cshp_dv_047_02_hires_bds.lbl data/spice_dsk/spc_esa/mtp019/cshp_dv_130_01_hires_bds.lbl data/spice_dsk/spc_esa/mtp019/cshp_dv_130_01_lores_bds.lbl in which it is set correctly to NAVCAM NAIF IDs {-226170,-226180}. Either set it in all labels or in none. data/triplate/*/*/*.lbl B8. data/triplate/spc_esa/mtp*/*.lbl do not include UNIT in the vertex coordinate column objects. B9. data/triplate/spc_esa/mtp*/*.lbl do not include INSTRUMENT_ID. Other triplate labels do. B10. did not at-temp to check if labels correctly describe data data/*/*/*/*.obj data/*/*/*/*.ros data/*/*/*/*.wrl B11. did not review non-DSK data product files -------------------------------------------------------------------- C. document/ directory -------------------------------------------------------------------- document/cheops_ref_frame_v1.lbl C1. has RO-C-MULTI-5-67P-SHAPE-V1.0:" in the CITATION_DESC. Is this intentional? document/user_guide.asc C2. .DSK in "Shape Model Formats" should be changed to DSK (.BDS) C3. "Reference Frame and Rotation State" does not mention SHAP4 and SHAP4S models C4. "Shape Model Version" mentions SHAP7 that's not in the data set C5. this paragraph The SHAP5 SPC version of the shape models was reconstructed in a frame rotated by 0.28 deg and translated by (2.8,1.3,17.0) m with respect to the Cheops frame. The transformation between the two frames was determined using a tool called "PC_ALIGN" available in the NASA Ames Stereo Pipeline (ASP). The method is based on the article of Pomerleau et al., 'Comparing ICP Variants on Real-World Data Sets', Autonomous Robots 34(3), 133-148, February 2013. raises many questions, such as: * did the team that produced SHAP5 SPC confirm that they used a different frame? * if yes, o what document defines this frame? o is this frame just a refinement of CHEOPS_REF_FRAME_V1 or something different? o is it "IAU-compliant"? o why the labels for SHAP5 SPC still say that they use "the reference frame described in CHEOPS_REF_FRAME_V1"? * if no, o can this offset be disregarded and shapes used with CHEOPS_REF_FRAME_V1? o if the offset cannot be disregarded, are users supposed to apply this offset on top of any positional/rotational information for G-C/CHEOPS_REF_FRAME_V1 obtained from SPICE of elsewhere? o how would is this info supposed to be applied when they use DSKs? * what axis is the rotational offset about? C6. no description of SPG technique C7. provides comparison/suggestions only regarding SPC and MSPCD and makes not suggestions regarding using SPC vs SPG vs ESA/RMOC. document/eaicd.pdf C8. 1.7: does not mention SPICE and DSK C9. 2.3.3: "Information on the shape models created by DLR can be found in ..." should two references given in this paragraph be in references section and be pointed at using RD.#? C10. 2.4.1: change "DBS (.DSK extension)" to "DSK (.BDS extension)" and change "DBS (.DSK)" to "DSK (.BDS)" C11. 3.2.2: same concerns about SHAP5 SPC frame offset paragraph as for user_guide.asc C12. 3.2.2: should mention that rotation constants from CHEOPS_REF_FRAME_V1.PDF apply only to Aug-Sep 2014. C13. 3.3.4: DOCINF.TXT -> CATINFO.TXT C14. 3.3.5: does not mention SCIENCE_INDEX.TAB C15. 4: says nothing about DLR SPG models document/*_model_info.asc C16. what is the applicability period for Axis orientation: and Rotation Period:? C17. none of rotation constants sets is sufficient to compute inertial orientation of the comet (no W0, incomplete precession constants) C18. these documents seem to have a lot of overlap with eaicd.pdf. Are they all in sync? -------------------------------------------------------------------- D. index/ directory -------------------------------------------------------------------- index/citations.tab D1. includes citation for DOCUMENT/CHEOPS_REF_FRAME_V1.LBL but not for other documents (note: CHEOPS_REF_FRAME_V1.PDF is the only document that has CITATION_DESC in the label; should other have it too?) -------------------------------------------------------------------- End.