Comet ISON Liens List urn:nasa:pds:ison_gbo:hfosc_jan2013::1.0 urn:nasa:pds:ison_gbo:hfosc_feb2013::1.0 urn:nasa:pds:ison_gbo:hfosc_sept2013::1.0 urn:nasa:pds:ison_gbo:hfosc_oct2013::1.0 urn:nasa:pds:ison_gbo:hfosc_nov2013::1.0 Certification: Not certified. Delta review is sufficient. Data Provider Liens =================== Emily Kramer Review data/imaging/ --> Flags in file names indicate what processing has been done. r = registered on comet position, or t in October. Is there a difference? --> While the documentation files clearly state which processing has been done to which frames, it was unclear why image registration wasn't done for all data. e.g., wj010098.fits (Oct. 1), November data, September 19 data. September data appears to already be registered? Spectroscopy documentation/overviews: --> VBT referred to as 90" in overview docs, but 2.34-m in spectroscopy documentation. This should be rectified. file: february2013_spectroscopy.pdf --> Missing y-axis label in second figure of February spectroscopy documentation. Imaging and spectra documentation pdfs: --> Would be helpful to have each document structured in the same format for all months. Tony Farnham Review Documentation Issues: Documentation states that the data are calibrated, but it appears that this only consists of bias removal, flat fielding and cosmic ray removal (and relative fluxes for spectra). The term "calibrated" suggests that they have converted to flux or magnitude units, which does not seem to be the case. --> I would suggest that the terminology refer to the final archived products as "processed" or "reduced", rather than calibrated. This has implications on the directory names and some of the discussions as well. Alignment of images: In imaging document, "All images are aligned on the brightest pixel of the comet (optocentre)" suggests the brightest pixel is used (integer shifts), but later it says a linear interpolation is used, which suggests sub-pixel shifts. --> If the latter is true, I suggest the terminology "All images are aligned on the comet optocentre" and stating that the images are aligned at the sub-pixel level to make this clear. files: jan2013_spectroscopy.pdf, sept2013spectroscopy.pdf In Jan & Sept spectroscopy documents, raw and calibrated data don't always match. Images seem to list a different star. In Jan, Raw lists HR1544, while processed and derived list HD195034. In Sept, no stars listed in raw while processed and derived list HD195034 --> Need to include more info. SBN Liens ========= Emily Kramer Review file: */overview.txt --> till ==> until --> "Photometric data was obtained" ==> "Photometric data were obtained" Tony Farnham Review data/ --> In datasets with more than one nights' observation, the master calibration frames have XML labels that don't match the FITS image name (presumably legal but annoying). --> Even worse is on Feb 21, the FITS files have numbers rather than "r" or "i" so there is no obvious link between them without opening the label. Imaging READ_PDS issues --> Raising issues with READ_PDS because it is the only means of manipulating data read from XML label. I don't know if these are label errors or software errors..... --> Frequently get a "no END statement" error. Doesn't seem t affect reading of the data. --> Some files get a READU error (unformatted binary read error). The FITS files are read by FITS readers with no error. Has an effect on the way the data are read. List of affected files in READU_ERROR.TXT. Reading Spectral Data --> IDL: Able to read, display and manipulate some of the data using the XML labels with the PDS4 version of READ_PDS. --> Other files cause IDL (not just READ_PDS) to crash horribly. No error info, due to crash. Files listed in READPDS_CRASH_FILES.TXT. Files: */spectra/*.xml --> Problem with a "quote" in description field in the labels. Should be proper units for angles. Anne Raugh Notes --> Shouldn't use "gbo" in a bundle name - we use that acronym for a different set of words. --> Shouldn't use "ISON" in a bundle name - there are too many comets with that name. --> Note that the "HFOSC" acronym refers to one of several instruments actually used. Chen EN Notes files: *.xml --> In the XML Prolog and Root Tag (the top of a label), use https instead of http for URLs (not namespaces) of NASA sites, e.g. change EN recommends (SBN has always disagreed) explicitly declaring xmlns:pds="http://pds.nasa.gov/pds4/pds/v1" --> EN recommends including context and schema collections for a fully self-describing bundle. --> The LIDs in these labels are the same as those reviewed in 2017.10. If those were ingested, the LIDs will collide, and this would need correction. --> These LIDs (all used as lid_references) are unknown. Some (*) are incorrect. Please coordinate with EN about them and their context products: a. urn:nasa:pds:context:facility:observatory.iao b. urn:nasa:pds:context:facility:observatory.vainu c. urn:nasa:pds:context:facility:observatory.wise d. urn:nasa:pds:context:instrument:fosc * e. urn:nasa:pds:context:instrument:hfosc * f. urn:nasa:pds:context:instrument:omr_spec * g. urn:nasa:pds:context:target:calibration_field.sa_95-41 * h. urn:nasa:pds:context:target:comet.ison * i. urn:nasa:pds:context:telescope:hct * j. urn:nasa:pds:context:telescope:vbt * k. urn:nasa:pds:context:telescope:wise1m * --> a, b, c are probably good --> d, e, f need the LID of the context object the instrument is identified with --> If g is meant to be the Star Area 95-41, use urn:nasa:pds:context:target:star.gsc_04718-00250 --> For h, use urn:nasa:pds:context:target:comet.2012_s1 --> i, j, k must also incorporate the LID of the context object the telescope is identified with. Files: hfosc_*2013/collection.xml --> Section 2B.2.2.2 of the PDS4 Standards: "Beneath the root directory, the top-level subdirectories have a one-to-one correspondence with the bundle's collections". However, this one file is the only collection.xml for the three top-level subdirectories documentation/, imaging/, and spectroscopy. Files: hfosc_*2013/inventory.csv --> Need to update inventory.csv files with changed LIDs recorded in Chen_NOTES.txt. --> A collection should have products of similar type (DPH 8.0). These mix data and documentation.