Hale-Bopp Lightcurves Liens List

urn:nasa:pds:halebopp::1.0

Certification: Certified.  Can publish with liens, provided the bundle readme.txt is the "missing" overview. [Follow-up: "readme.txt" isn't quite the full missing overview.  Emily will supply a list of the sort of thing that still seems to be missing via email so we can make sure we hit everything.]


Data Provider Liens
===================

Tilden Pre-Review

file: bundle.xml and */collection.xml
--> <Identification_Area> This object is exactly the same as the data and document collections and bundle.  It should contain unique information for each collection/bundle.  Please consult with SBN personell if you have any questions.


Tony Farnham Review

Discrepancies in the Data files and Documentation:
--> Data file:  whypointsremovedfromdata.csv (Column Y) includes the entries: "Used a telescope under 5.5 magnitude" and "Used binoculars under 3.3 magnitude"
--> Document:  REASONS_DATA_WERE_REMOVED.PDF says "If telescopes were used under 5.4 magnitude or binoculars used under 1.4 magnitude."  (5.4 and 1.4 also used in the statistics list in that file).

Files: Pre/Post Data files and labels
--> "mph" column lists the phase correction as coming from "Schleicher et al 2011". Document: SCHLEICHERDUSTPHASEHM_TABLE.TXT Cites it as "Schleicher (May 2010)". I didn't see anywhere that specified where it actually came from (note that it was captured from his website?)

File: hblcpostperihelion.csv
--> Type: "Comet phase angle in degrees at reported date as per aJPL HORIZONS Ephemeris query". Should be: "date as per a JPL HORIZONS Ephemeris query".

--> Warning note: the phrase "as per a JPL HORIZONS Ephemeris query" isn't particularly meaningful without a reference to the orbit solution that was used there.  Not an issue for H-B, but in other situations, the elements can change.

Request:
--> The only time entry is given in the "T" format, which is perfectly acceptable Difficult to use, especially in EXCEL. It would be nice to have a second, linear time entry JD or time from perihelion.


Emily Kramer Review

Data descriptions missing:
--> While the nature of the data is described within the .csv files (and on the PDS website), the data set is missing "collection_description.txt" and "collection_description.xml" so that the data can be easily understood just from the archived files

file: input_column_meanings.pdf
--> The information on the linked websites should be included directly in the archive to ensure that the information will be preserved. I wasn't able to access it already! This documentation doesn't seem to be directly related to the data in this set; rather it appears to be related to how the data are submitted to the ICQ.


SBN Liens
=========

Tilden Pre-Review

--> May want to restructure bundle to make it more generic instead of specific to this data set.  Consult SBN-UMD personnel. 

file: bundle.xml and */collection.xml
--> <title> suggest removing version text "V1.0".  It is found in the <version_id>.
--> Should include target information.


Chen EN Notes

file: *.xml

--> In the XML Prolog and Root Tag (the top of a label), use https instead
 of http for URLs (not namespaces) of NASA sites, e.g. change

    <?xml-model href="http://pds.nasa.gov/pds4/pds/v1/PDS4_PDS_1900.sch"

to
    
<?xml-model href="https://pds.nasa.gov/pds4/pds/v1/PDS4_PDS_1900.sch"

and
 
    xsi:schemaLocation="http://pds.nasa.gov/pds4/pds/v1
 http://pds.nasa.gov/pds4/pds/v1/PDS4_PDS_1900.xsd

to

    xsi:schemaLocation="
http://pds.nasa.gov/pds4/pds/v1
 https://pds.nasa.gov/pds4/pds/v1/PDS4_PDS_1900.xsd


--> EN recommends (SBN has always disagreed) explicitly declaring
 xmlns:pds="http://pds.nasa.gov/pds4/pds/v1"


--> EN recommends including context and schema collections for a fully
 self-describing bundle.

--> The offset for Table_Delimited is low by 1, e.g. for hblcpostperihelion.xml,
 <offset unit="byte">2709</offset>

should be

    <offset unit="byte">2710</offset>

The header's object_length should be the same. 

file: inventory.csv
--> The last line of these files do not end in CRLF.

    % od -h data/inventory.csv | tail
    0000060      7363    3a76    313a    302e    0a0d    2c50    7275    3a6e
    0000100      616e    6173    703a    7364    683a    6c61    6265    706f
    0000120      3a70    6164    6174    683a    6c62    7063    6572    6570
    0000140      6972    6568    696c    6e6f    635f    7673    3a3a    2e31
    0000160      0d30    500a    752c    6e72    6e3a    7361    3a61    6470
    0000200      3a73    6168    656c    6f62    7070    643a    7461    3a61
    0000220      6877    7079    696f    746e    7273    6d65    766f    6465
    0000240      7266    6d6f    6164    6174    635f    7673    3a3a    2e31
    0000260      0d30    000a
    0000263