Uranian Satellites Liens List urn:nasa:pds:gbo-apache_point:uransatspec::1.0 Certification Status: Not certified. The processed data must be atmospherically corrected to be useful. Full review required. Data Provider Liens =================== Mike Kelley Review file: overview.txt --> Please clarify the following sentence from Processing: "Wavelength calibration was done on multiple point source images (satellite spectra) with a long exposure time with the source placed away from the center of the slit and many OH lines." It is confusing and seems to suggest the source is placed away from many OH lines, which doesn't make sense. --> Something missing in the sentence: "An automated Spectra were combined to maximize signal to noise ratios." --> "Spectra were combined to maximize signal to noise ratios." Comparing the file numbers with the log suggests the spectra from the nod positions were combined, right? If true, please explicitly state this. If not, what was actually combined? data/ --> Processed data labels refer to apertures, but there appears to only be one aperture for all cases. To avoid confusion, consider dropping the discussion of apertures. --> Overview says "Following telluric correction, the five spectral orders are merged to generate the complete reduced spectrum," but the processed data are not telluric corrected or merged. Either the overview must be corrected, or the final spectra provided. --> Units of the flux and error axes are not specified. (Where should that be?) --> OK to use Array_3D_Spectrum for spectral_dispersion CE (wave, flux, err) CE order? What would we do in a 4D case? Karl Hibbitts Review data/ --> Wavelength calibration of processed spectra is suspect SBN Liens ========= Tilden Pre-Review file: collection.xml --> should probably be 2018 Mike Kelley Review file: collection.xml --> : Why use Multiple Satellites? Why not list the two satellites? file: overview.txt --> Mix of tabs and spaces throughout. Please normalize to only tabs or spaces for indentation (preferably spaces). data/ --> Consider Surface for the Science_Facets. --> sp:Spectral_Characteristics/sp:Field_of_View/sp:description specifies "Slits with 0.7', 1.5', and 1.7' are also available", but these should have units of arcseconds, not arcminutes. --> sp:Spectral_Characteristics/sp:Bin_Description/sp:bin_profile_description - The text here (instrument array dimensions) does not seem relevant. Instead, it should be related to what sp:bin_width_wavelength means. files: Raw and calibration images --> Labeling with the spectral data dictionary, but the data are images of the focal plane. Is this the right approach? The Bin_Description class does not make sense in this context. file: PDS4_SP_1800 --> This data set uses PDS4_SP_1800. This is not on the PDS4 Released Schemas page. --> typo in complexType[name="Spectral_Characteristics"]/annotation/documentation: "... It is note used ..." --> Another typo in complextype[name="sampling_interval_wavenumber"]/annotation/documentation: "... spacing of points, in eavenumber units ..." --> What specifies the units of the dispersion values? It may be implied that all spectral units should be the same, but shouldn't this be explicit in the data dictionary? Chen EN Notes file: *.xml --> In the XML Prolog and Root Tag (the top of a label), use https instead of http for URLs (not namespaces) of NASA sites, e.g. change EN recommends (SBN has always disagreed) explicitly declaring xmlns:pds="http://pds.nasa.gov/pds4/pds/v1" --> EN recommends including context and schema collections for a fully self-describing bundle. file: PDS4_SP_1800.xsd --> This file has not been provided for the review and is not available on pds.nasa.gov/pds4/schema yet. One solution would be to create an xml_schema/ directory and collection with all secondary members. file: collection.xml --> Section 2B.2.2.2 of the PDS4 Standards: "Beneath the root directory, the top-level subdirectories have a one-to-one correspondence with the bundle's collections". However, this one file is the only collection.xml for the two top-level subdirectories data/ and document/. --> This has the same LID as one reviewed in 2017.10. If that bundle was ingested, the LIDs collide, which would need corrective action. --> This and many files in this bundle have incorrect LIDs urn:nasa:pds:facility:observatory.apache_point urn:nasa:pds:telescope:apache_point.arc3m5 urn:nasa:pds:instrument:triplespec.arc3m5 should be urn:nasa:pds:context:facility:observatory.apache_point urn:nasa:pds:context:telescope:apache_point.arc3m5 urn:nasa:pds:context:instrument:telescope.triplespec.arc3m5 Actually, the last two are unknown to EN. Please coordinate with EN about them and their context products. --> These LIDs are currently being debated and will be resolved soon. Please coordinate with EN about them: urn:nasa:pds:context:target:satellite.ariel urn:nasa:pds:context:target:satellite.oberon file: tspec_guide.xml --> Presumably, change the logical_identifier for this file urn:nasa:pds:gbo-apache_point:uransatspec:tpsec_guide to urn:nasa:pds:gbo-apache_point:uransatspec:tspec_guide to match the file name and the line in inventory.csv file: inventory.csv --> The last line of this file does not end in CRLF. % od -h inventory.csv | tail 0005200 6570 3a63 766f 7265 6976 7765 3a3a 2e31 0005220 0d30 500a 752c 6e72 6e3a 7361 3a61 6470 0005240 3a73 6267 2d6f 7061 6361 6568 705f 696f 0005260 746e 753a 6172 736e 7461 7073 6365 6c3a 0005300 676f 6873 6565 3a74 313a 302e 0a0d 2c50 0005320 7275 3a6e 616e 6173 703a 7364 673a 6f62 0005340 612d 6170 6863 5f65 6f70 6e69 3a74 7275 0005360 6e61 6173 7374 6570 3a63 7374 6570 5f63 0005400 7567 6469 3a65 313a 302e 0005412