*.xml
- In the XML Prolog and Root Tag (the top of a label), use https instead
of http for URLs (not namespaces) of NASA sites, e.g. change
869
should be
870
The header's object_length should be the same, e.g. 870 for 122pde_vico_1.xml,
unid-emis/*.csv
- Floating point numbers should have a decimal. Some values in this file don't.
Section 4B.1.2 of the Standards says:
f indicates a floating point number in the format [-]ddd.ddd
- Many value do not have trailing 0's, e.g. 4482.5 for %7.2f
Section 4B.1.2 of the Standards says about the precision:
For real numbers, it indicates the number of digits to the right of the
decimal point.
uransatspec/
- No bundle.xml? If intentional, note that no other node has even 1 bundle
without it. If unintentional, it should be reviewed.
uransatspec/.../*.xml
uransatspec/.../PDS4_SP_1800.xsd
- This file has not been provided for the review and is not available on
pds.nasa.gov/pds4/schema yet. One solution would be to create an xml_schema/
directory and collection with all secondary members.
uransatspec/collection.xml
- Section 2B.2.2.2 of the PDS4 Standards: "Beneath the root directory, the
top-level subdirectories have a one-to-one correspondence with the bundle's
collections". However, this one file is the only collection.xml for the two
top-level subdirectories data/ and document/.
- This has the same LID as one reviewed in 2017.10. If that bundle was
ingested, the LIDs collide, which would need corrective action.
- This and many files in this bundle have incorrect LIDs
urn:nasa:pds:facility:observatory.apache_point
urn:nasa:pds:telescope:apache_point.arc3m5
urn:nasa:pds:instrument:triplespec.arc3m5
should be
urn:nasa:pds:context:facility:observatory.apache_point
urn:nasa:pds:context:telescope:apache_point.arc3m5
urn:nasa:pds:context:instrument:telescope.triplespec.arc3m5
Actually, the last two are unknown to EN. Please coordinate with
EN about them and their context products:
- These LIDs are currently being debated and will be resolved soon.
Please coordinate with EN about them:
urn:nasa:pds:context:target:satellite.ariel
urn:nasa:pds:context:target:satellite.oberon
uransatspec/document/tspec_guide.xml
- Presumably, change the logical_identifier for this file
urn:nasa:pds:gbo-apache_point:uransatspec:tpsec_guide to
urn:nasa:pds:gbo-apache_point:uransatspec:tspec_guide
to match the file name and the line in inventory.csv
uransatspec/inventory.csv
- This should be named collection.csv to match collection.xml
- The last line of this file does not end in CRLF.
% od -h inventory.csv | tail
0005200 6570 3a63 766f 7265 6976 7765 3a3a 2e31
0005220 0d30 500a 752c 6e72 6e3a 7361 3a61 6470
0005240 3a73 6267 2d6f 7061 6361 6568 705f 696f
0005260 746e 753a 6172 736e 7461 7073 6365 6c3a
0005300 676f 6873 6565 3a74 313a 302e 0a0d 2c50
0005320 7275 3a6e 616e 6173 703a 7364 673a 6f62
0005340 612d 6170 6863 5f65 6f70 6e69 3a74 7275
0005360 6e61 6173 7374 6570 3a63 7374 6570 5f63
0005400 7567 6469 3a65 313a 302e
0005412
halebopp/
- No bundle.xml? If intentional, note that no other node has even 1 bundle
without it. If unintentional, it should be reviewed.
halebopp/data/*.xml
- The offset for Table_Delimited is low by 1, e.g. for hblcpostperihelion.xml,
2709
should be
2710
The header's object_length should be the same
halebopp/*/inventory.csv
- These should be named collection.csv to match collection.xml
- The last line of these files do not end in CRLF.
% od -h data/inventory.csv | tail
0000060 7363 3a76 313a 302e 0a0d 2c50 7275 3a6e
0000100 616e 6173 703a 7364 683a 6c61 6265 706f
0000120 3a70 6164 6174 683a 6c62 7063 6572 6570
0000140 6972 6568 696c 6e6f 635f 7673 3a3a 2e31
0000160 0d30 500a 752c 6e72 6e3a 7361 3a61 6470
0000200 3a73 6168 656c 6f62 7070 643a 7461 3a61
0000220 6877 7079 696f 746e 7273 6d65 766f 6465
0000240 7266 6d6f 6164 6174 635f 7673 3a3a 2e31
0000260 0d30 000a
0000263
hfosc_*2013/
- No bundle.xml? If intentional, note that no other node has even 1 bundle
without it. If unintentional, it should be reviewed.
- A collection should have products of similar type (DPH 8.0). These mix
data and documentation.
- The LIDs in these labels are the same as those reviewed in 2017.10. If
those were ingested, the LIDs will collide, and this would need correction.
- These LIDs (all used as lid_references) are unknown. Some (*) are
incorrect. Please coordinate with EN about them and their context products:
a. urn:nasa:pds:context:facility:observatory.iao
b. urn:nasa:pds:context:facility:observatory.vainu
c. urn:nasa:pds:context:facility:observatory.wise
d. urn:nasa:pds:context:instrument:fosc *
e. urn:nasa:pds:context:instrument:hfosc *
f. urn:nasa:pds:context:instrument:omr_spec *
g. urn:nasa:pds:context:target:calibration_field.sa_95-41 *
h. urn:nasa:pds:context:target:comet.ison *
i. urn:nasa:pds:context:telescope:hct *
j. urn:nasa:pds:context:telescope:vbt *
k. urn:nasa:pds:context:telescope:wise1m *
- a, b, c are probably good
- d, e, f need the LID of the context object the instrument is identified with
- If g is meant to be the Star Area 95-41, use
urn:nasa:pds:context:target:star.gsc_04718-00250
- For h, use
urn:nasa:pds:context:target:comet.2012_s1
- i, j, k must also incorporate the LID of the context object the telescope
is identified with.
hfosc_*2013/collection.xml
- Section 2B.2.2.2 of the PDS4 Standards: "Beneath the root directory, the
top-level subdirectories have a one-to-one correspondence with the bundle's
collections". However, this one file is the only collection.xml for the three
top-level subdirectories documentation/, imaging/, and spectroscopy
hfosc_*2013/inventory.csv
- This should be named collection.csv to match collection.xml
hfosc_jan2013/inventory.csv
- These LIDs, listed in the .csv, are not found in any product in this review
urn:nasa:pds:ison_gbo:hfosc_jan2013:jan22_2013_imaging::1.0
urn:nasa:pds:ison_gbo:hfosc_jan2013:jan22_2013_spectroscopy::1.0
hfosc_jan2013/documentation/jan2013_imaging.xml
hfosc_jan2013/documentation/jan2013_spectroscopy.xml
- The LIDs for these files are not in inventory.csv
hfosc_feb2013/inventory.csv
- These LIDs, listed in the .csv, are not found in any product in this review
urn:nasa:pds:ison_gbo:hfosc_feb2013:tccfbwb220034::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:tccfbwb220046::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:tccfbwb220047::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:tccfbwb220048::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:tccfbwb220049::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:tccfbwb220050::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:albedo::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:ison_continuum::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:ison_continuum_subtracted::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:ison_spectrum::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:solar_analog::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:solar_continuum::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:february_2013_imaging::1.0
urn:nasa:pds:ison_gbo:hfosc_feb2013:preprocessing::1.0
hfosc_feb2013/spectroscopy/derivedspectra/solar_continuum.xml
hfosc_feb2013/spectroscopy/derivedspectra/albedo.xml
hfosc_feb2013/spectroscopy/calibratedspectra/feb_continsub.xml
hfosc_feb2013/spectroscopy/derivedspectra/ison_continuum.xml
hfosc_feb2013/spectroscopy/calibratedspectra/flat.xml
hfosc_feb2013/imaging/february21/calibrationframes/sciencecombine.xml
hfosc_feb2013/spectroscopy/derivedspectra/ison_continuum_subtracted.xml
hfosc_feb2013/documentation/feb21preprocessing.xml
hfosc_feb2013/spectroscopy/calibratedspectra/feb_solar.xml
hfosc_feb2013/spectroscopy/derivedspectra/solar_analog.xml
hfosc_feb2013/spectroscopy/derivedspectra/ison_spectrum.xml
hfosc_feb2013/documentation/feb22preprocessing.xml
hfosc_feb2013/documentation/feb19preprocessing.xml
hfosc_feb2013/imaging/february21/calibratedimages/icrccfbwb210030.xml
hfosc_feb2013/imaging/february22/calibratedframes/rccfbwb220034.xml
hfosc_feb2013/documentation/february2013_imaging.xml
hfosc_feb2013/imaging/february22/calibratedframes/rccfbwb220047.xml
hfosc_feb2013/imaging/february22/calibratedframes/rccfbwb220046.xml
hfosc_feb2013/imaging/february22/calibratedframes/rccfbwb220049.xml
hfosc_feb2013/imaging/february22/calibratedframes/rccfbwb220048.xml
hfosc_feb2013/imaging/february22/calibratedframes/rccfbwb220050.xml
hfosc_feb2013/spectroscopy/calibratedspectra/feb_continuum.xml
hfosc_feb2013/imaging/february21/calibratedimages/icrccfbwb210025.xml
hfosc_feb2013/imaging/february19/calibrationframes/sciencecombine.xml
hfosc_feb2013/imaging/february21/calibratedimages/icrccfbwb210026.xml
hfosc_feb2013/imaging/february21/calibratedimages/icrccfbwb210023.xml
hfosc_feb2013/imaging/february21/calibratedimages/icrccfbwb210024.xml
hfosc_feb2013/imaging/february21/calibratedimages/icrccfbwb210029.xml
hfosc_feb2013/spectroscopy/calibratedspectra/feb_ison.xml
hfosc_feb2013/imaging/february19/calibratedimages/icccfbwb190044.xml
hfosc_feb2013/imaging/february21/calibratedimages/icrccfbwb210021.xml
hfosc_feb2013/imaging/february19/calibratedimages/icccfbwb190045.xml
hfosc_feb2013/imaging/february21/calibratedimages/icrccfbwb210022.xml
hfosc_feb2013/imaging/february19/calibratedimages/icccfbwb190042.xml
hfosc_feb2013/imaging/february19/calibratedimages/icccfbwb190043.xml
- The LIDs for these files are not in inventory.csv
hfosc_oct2013/inventory.csv
- These LIDs, listed in the .csv, are not found in any product in this review
urn:nasa:pds:ison_gbo:hfosc_oct2013:flatb01::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi030001::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi030032::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi030036::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi030041::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi030063::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi030083::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi080020::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi080063::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi110005::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi110006::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi110007::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi130005::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi130006::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wi130007::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010001::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010005::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010006::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010007::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010011::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010012::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010013::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010017::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010045::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010074::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010081::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010085::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010096::1.0
urn:nasa:pds:ison_gbo:hfosc_oct2013:wj010097::1.0
hfosc_oct2013/imaging/october01/rawframes/wa220012.xml
hfosc_oct2013/imaging/october01/rawframes/wi290010.xml
hfosc_oct2013/imaging/october01/rawframes/wa220017.xml
hfosc_oct2013/imaging/october01/calibrationframes/flatv01.xml
hfosc_oct2013/spectroscopy/oct01/calibratedspectra/continuumgr7.xml
hfosc_oct2013/imaging/october01/rawframes/wa220001.xml
hfosc_oct2013/imaging/october01/rawframes/wi290009.xml
hfosc_oct2013/imaging/october01/rawframes/wi290008.xml
hfosc_oct2013/documentation/preprocessing.xml
hfosc_oct2013/imaging/october01/rawframes/wi290081.xml
hfosc_oct2013/imaging/october01/rawframes/wi290080.xml
hfosc_oct2013/documentation/cosmic_rays.xml
hfosc_oct2013/imaging/october01/rawframes/wa220027.xml
hfosc_oct2013/spectroscopy/oct01/calibratedspectra/continuum_subcometgr7.xml
hfosc_oct2013/spectroscopy/oct01/calibratedspectra/solaranaloggr7.xml
hfosc_oct2013/imaging/october01/rawframes/wi290079.xml
hfosc_oct2013/spectroscopy/oct01/calibratedspectra/cometgr7_spectrum.xml
- The LIDs for these files are not in inventory.csv
hfosc_nov2013/spectroscopy/nov13/calibratedspectra/13nobj6_tbfw.xml
hfosc_nov2013/spectroscopy/nov11/calibratedspectra/11nobj2_tbf.xml
hfosc_nov2013/spectroscopy/nov12/calibratedspectra/12nobj3_tbf.xml
hfosc_nov2013/spectroscopy/nov13/calibratedspectra/13nobj4_tbf.xml
hfosc_nov2013/spectroscopy/nov08/calibratedspectra/8nobj6_tbfw.xml
hfosc_nov2013/spectroscopy/nov09/derivedspectra/9nov2013_ison.xml
hfosc_nov2013/spectroscopy/nov13/calibratedspectra/13nobj3_tbf.xml
hfosc_nov2013/spectroscopy/nov13/calibratedspectra/13nobj5_tbfw.xml
hfosc_nov2013/spectroscopy/nov09/calibratedspectra/9nobj4_tbfw.xml
hfosc_nov2013/spectroscopy/nov13/calibratedspectra/13nobj2_tbf.xml
hfosc_nov2013/spectroscopy/nov12/calibratedspectra/12nobj5_tbfw.xml
hfosc_nov2013/spectroscopy/nov12/calibratedspectra/12nobj2_tbf.xml
hfosc_nov2013/spectroscopy/nov11/calibratedspectra/11nobj3_tbfw.xml
- The LIDs for these files are not in inventory.csv
ihw-c-nnsn-3-edr-halley-v2.0/document/*.lbl
- DATA_SET_ID = "ihw-c-nnsn-3-edr-halley-v2.0" should be all caps, i.e.
DATA_SET_ID = "IHW-C-NNSN-3-EDR-HALLEY-V2.0"
- Does the FITS_HEADER start at the same place as the IMAGE? I.e. should
^FITS_HEADER = ("NNSN3138.FIT",3)
^IMAGE = ("NNSN3138.FIT",3)
be
^FITS_HEADER = ("NNSN3138.FIT",1)
^IMAGE = ("NNSN3138.FIT",3)
- Probably not a bug but could be. More than 1 file has this START_TIME:
1985-12-08T04:03:00.000
The same thing happens with these START_TIMEs
1985-12-12T09:08:33.000
1985-12-12T09:11:26.000
1985-12-12T11:52:43.000
1985-12-12T12:05:41.000
1985-12-12T12:12:53.000
1985-12-12T12:17:12.000
1985-12-12T12:25:50.000
1986-01-04T02:08:48.000
1986-01-05T16:49:11.000
1986-01-07T16:10:19.000
1986-05-06T13:40:33.000
1988-04-19T23:40:05.000
nh-p-pepssi-5-plasma-v1.0/data/*.lbl
- Keyword MISSION_PHASE_NAME is missing, optional, but suggested.
- Keywords SPACECRAFT_CLOCK_START_COUNT and SPACECRAFT_CLOCK_STOP_COUNT
are required but missing.
nh-p-swap-5-derived-solarwind-v1.0/data/*.lbl
- Keyword MISSION_PHASE_NAME is missing, optional, but suggested.
- Keywords SPACECRAFT_CLOCK_START_COUNT and SPACECRAFT_CLOCK_STOP_COUNT
are required but missing.
nh-p-swap-5-derived-solarwind-v1.0/data/nh_heliocentric_sw_2015-07-14.lbl
- For spreadsheets, the only way to specify an offset is via , i.e. change
^SPREADSHEET = ( "NH_HELIOCENTRIC_SW_2015-07-14.CSV", 2 )
to
^SPREADSHEET = ( "NH_HELIOCENTRIC_SW_2015-07-14.CSV", 317 )
- Lines 113-122 have 264 bytes of characters, then CRLF, so change
ROW_BYTES = 264
to
ROW_BYTES = 266
- the .csv has 123 rows of data and 1 row of header,j so change
ROWS = 124
to
ROWS = 123
Same comments for the other data label, with offset=370 and ROW_BYTES=298
nh-p-swap-5-derived-solarwind-v1.0/index/index.lbl
- Perhaps a column was added but not accounted for? These
RECORD_BYTES = 227
ROW_BYTES = 227
should be
RECORD_BYTES = 253
ROW_BYTES = 253
nh-p_psa-leisa_mvic-5-comp-v1.0/data/*.lbl
- Keyword MISSION_PHASE_NAME is missing, optional, but suggested.
- Keywords START_TIME, STOP_TIME, SPACECRAFT_CLOCK_START_COUNT, and
SPACECRAFT_CLOCK_STOP_COUNT are required but missing. Also goes for *.img
nh-p_psa-leisa_mvic-5-comp-v1.0/data/spec/*.lbl
- All these labels have
PRODUCT_CREATON_TIME = 2017-09-30T00:00:00
which should be
PRODUCT_CREATION_TIME = 2017-09-30T00:00:00
nh-p_psa-leisa_mvic-5-comp-v1.0/data/spec/*_cube.lbl
- To avoid adding new standard values, please change
CORE_NAME = "SPECTRAL_RADIANCE"
CORE_UNIT = "WATT*M**-2*SR**-1*uM**-1"
to
CORE_NAME = "SPECTRAL RADIANCE"
CORE_UNIT = "WATT*M**-2*SR**-1*UM**-1"
nh-p_psa-lorri_alice_rex-5-atmos-v1.0/data/haze/*.lbl
nh-p_psa-lorri_alice_rex-5-atmos-v1.0/data/rexatmos/*.lbl
nh-p_psa-lorri_alice_rex-5-atmos-v1.0/data/thermscan/*.lbl
- Keyword MISSION_PHASE_NAME is missing, optional, but suggested.
nh-p_psa-lorri_alice_rex-5-atmos-v1.0/data/aliceocc/*.lbl
nh-p_psa-lorri_alice_rex-5-atmos-v1.0/data/atmoscomp/*.lbl
nh-p_psa-lorri_alice_rex-5-atmos-v1.0/data/thermscan /*.lbl
- Keywords START_TIME and STOP_TIME are required but missing.
nh-p_psa-lorri_alice_rex-5-atmos-v1.0/data/aliceocc/*.lbl
nh-p_psa-lorri_alice_rex-5-atmos-v1.0/data/atmoscomp/*.lbl
nh-p_psa-lorri_alice_rex-5-atmos-v1.0/data/rexatmos/*.lbl
nh-p_psa-lorri_alice_rex-5-atmos-v1.0/data/thermscan /*.lbl
- Keywords SPACECRAFT_CLOCK_START_COUNT and SPACECRAFT_CLOCK_STOP_COUNT
are required but missing.
nh-p_psa-lorri_mvic-5-geomaps-v1.0/data/.../*.lbl
- Keywords START_TIME, STOP_TIME, SPACECRAFT_CLOCK_START_COUNT, and
SPACECRAFT_CLOCK_STOP_COUNT are required but missing. Also goes for *.img