Liens for OSIRIS instrument from the July 2017 Rosetta Peer Review ================================================================== Reviewed Data Sets: RO-C-OSINAC-2-ESC1-67PCHURYUMOV-M12-V2.1 RO-C-OSINAC-4-ESC1-67PCHURYUMOV-M12-V1.0 RO-C-OSIWAC-3-ESC1-67PCHURYUMOV-M12-V2.1 RO-C-OSINAC-3-ESC1-67PCHURYUMOV-M12-V2.1 RO-C-OSIWAC-2-ESC1-67PCHURYUMOV-M12-V2.1 RO-C-OSIWAC-4-ESC1-67PCHURYUMOV-M12-V1.0 Review Certification: CERTIFIED, with minor liens. General Liens for all OSIRIS data sets ====================================== Suggested to add Filter descriptions in the product PDS labels and fits headers. (PDS is fine rejecting this so long as the descriptions are documented else where.) Suggested to add operational activity keywords from the PDS label to the FITS header. (PDS recognizes this is convient for the FITS users, but is fine to reject this since it is not part of the archive to the PDS.) file: 'BROWSE/BROWINFO.TXT' --> The description in this file needs modification. Browse images are not in the orientation described in the label. There is a brief description of this in the browinfo.txt, but the description of the problem Tony described is not consistent with the explanation in the browinfo.txt file. It sounds like only thing that needs changing is the description in the browinfo.txt file, though some investigation is needed. The Browse Images are not presented in the proper orientation (as viewed in the data products with PDS software). directory: 'CALIB/' --> The calibration files are not available as FITS equivalents. There is no pipeline available to do this, though. If it is possible to add these without extraordinary effort, please do. This is not a lien, however. file: 'CALIB/CALINFO.TXT' --> There is no talk of the OSICALLIOPE_V##.TXT files. files: 'CALIB/OSICALLIOPE_V*.TXT' --> There is no DESCRIPTION for the DOCUMENT object. It would be very useful to add. files: 'CATALOG/*.CAT' --> Strongly recommend that catalog files that contain documents as their DESCRIPTION should be converted to documents with only a brief summary and reference in the actual catalog files. This is to help cut down on the size and therefore readability of the catalog files. --> Some of these files describe "future" events that have now passed since the close of the mission. --> • Recommend technical editing for catalog files overall for spelling, grammar, incomplete sentences, updating tenses, etc.; perhaps as a final pass for the archive. file: 'CATALOG/INSTHOST.CAT' --> typo: line 523 coul -> could --> typos: lines 1349-1350 "battery discharge alarm shall heve remained enabled all the time" to "battery discharge alarm remained enabled all the time." --> typo: line 1636 noth -> north --> Please rephrase this odd sentence: "During cruise the instruments would serve for survival." file: 'CATALOG/MISSION.CAT' --> MISSION_STOP_DATE should be updated from "NULL". --> typos: lines 85,87,533,534,540 Manouver -> Maneuver file: 'CATALOG/DATASET.CAT' --> DATA_SET_DESC: The ABSTRACT_DESC is more descriptive of this data set is a few respects (calibration type, data units, target(s)) than here, which should never be the case. Please add more details. --> DATA_SET_DESC: The 'Related Datasets' section lists many data sets that do no exist, nor will exist to the archive. (Note they were separate samples sent to PSA/PDS for internal review purposes only). --> DATA_SET_DESC: The 'Change log' section mentions the including of '.fts' files, but they are actually '.FIT' files. file: 'CATALOG/REFERENCE.CAT' --> This file needs to be updated to the most current version. files: 'DATA/ ... /*' (data labels) --> Values of keywords should be all capitalized. This goes for: --> --> FILTER_NAME: "FFP-Vis_Blue", "FFP-Vis_Green", etc --> --> PRODUCER_INSTITUTION_NAME: "Max Planck Institute for Solar System Research" --> ROSETTA:POINT_OF_INTEREST = "IMAGE_CENTER" should be "IMAGE CENTER" (no _) files: 'DOCUMENT/*/*.LBL' --> Strongly suggest adding an informative DESCRIPTION keyword to each DOCUMENT object to describe what the document is. Since the DOCUMENT_NAME is the file name (as opposed to the name/title of the document as suggested in the PDSDD), there is little clue beyond the file name and the DOCUMENT_TOPIC_TYPE to know what the document is. files: 'DOCUMENT/*/*.PDF' --> The following documents claim to be PDF/A-1A (generated by Microsoft Office?), but fail verification. (The others succeed) --> --> CALIB/ADC_CORRECTION_V01.PDF --> --> CALIB/EXPOSURETIME_COR_V03.PDF --> --> CALIB/GEOMETRIC_DIST_COR_V02.PDF --> --> CALIB/GEO_PRODUCTS_V01.PDF --> --> CALIB/RADIOMETRIC_CALIB_V02.PDF --> --> CALIB/SOLAR_STRAYLIGHT_V01.PDF --> --> EAICD/OSIRIS_EAICD_V03.PDF --> --> EAICD/OSIRIS_EAICD_V04.PDF --> --> SCIENCE_USER_GUIDE/SCIENCE_USER_GUIDE_V01.PDF --> --> SIS/OSIRIS_SIS_V02.PDF --> --> SIS/OSIRIS_SIS_V03.PDF file: 'ERRATA.TXT' --> The ERRATA warns that the FIRST_LINE and FIRST_LINE_SAMPLE can be negative values. I found none such in these data sets. Is this still relevant for the OSIRIS data set? Liens unique to Level 3 OSIRIS data sets ======================================== [NONE] Liens unique to Level 4 OSIRIS data sets ======================================== files: 'BROWSE/*.LBL' --> The AZIMUTH_FOV and ELEVATION_FOV keywords unit should be changed from "DEGREES" to "deg" (as has been done with level 2 and 3 data sets). --> The ROSETTA:HORIZONTAL_RESOLUTION and ROSETTA:VERTICAL_RESOLUTION keywords unit should be changed from "RAD" to "rad" (as has been done with level 2 and 3 data sets). [ERROR] files: 'CATALOG/DATASET.CAT' --> DATA_SET_NAME: Since it is known that there will be multiple L4 data sets per phase and sub-instrument, please make sure this value is unique. All level 4 names are exactly the same as those provided in other L4 samples not provided in this review. There should be a difference. --> ABSTRACT_DESC: The "(CODMAC level 4)" is out of place in the sentence. Perhaps rephrasing the ABSTRACT to say "This CODMAC level 4 (resampled) data set contains ...". Similar situation for the L5 data set. --> CITATION_DESC: The DAT_SET_NAME part has the same problem as the DATA_SET_NAME keyword. [ERROR] files: 'DATA/*/*.LBL' --> The AZIMUTH_FOV and ELEVATION_FOV keywords unit should be changed from "DEGREES" to "deg" (as has been done with level 2 and 3 data sets). --> The ROSETTA:HORIZONTAL_RESOLUTION and ROSETTA:VERTICAL_RESOLUTION keywords unit should be changed from "RAD" to "rad" (as has been done with level 2 and 3 data sets).