Produced by PDS-SBN: T. Barnes Note: Looked at the EXT1 in more detail assuming they are representative of the rest. =============================================== Datasets Validated: RO-A-RPCICA-2-AST2-RAW-V1.0 RO-A-RPCICA-3-AST2-CALIB-V1.0 RO-C-RPCICA-2-ESC1-RAW-V2.0 RO-C-RPCICA-2-ESC2-RAW-V2.0 RO-C-RPCICA-2-ESC3-RAW-V2.0 RO-C-RPCICA-2-ESC4-RAW-V1.0 RO-C-RPCICA-2-EXT1-RAW-V1.0* RO-C-RPCICA-2-EXT2-RAW-V1.0 RO-C-RPCICA-2-EXT3-RAW-V1.0 RO-C-RPCICA-2-PRL-RAW-V2.0 RO-C-RPCICA-3-ESC1-CALIB-V1.0 RO-C-RPCICA-3-ESC2-CALIB-V1.0 RO-C-RPCICA-3-ESC3-CALIB-V1.0 RO-C-RPCICA-3-ESC4-CALIB-V1.0 RO-C-RPCICA-3-EXT1-CALIB-V1.0* RO-C-RPCICA-3-EXT2-CALIB-V1.0 RO-C-RPCICA-3-EXT3-CALIB-V1.0 RO-C-RPCICA-3-PRL-CALIB-V1.0 RO-C-RPCICA-4-EXT1-CORR-V1.0* RO-C-RPCICA-4-EXT1-PHYS_MASS-V1.0* RO-E-RPCICA-2-EAR1-RAW-V2.0 RO-E-RPCICA-2-EAR2-RAW-V2.0 RO-E-RPCICA-2-EAR3-RAW-V1.0 RO-E-RPCICA-3-EAR1-CALIB-V1.0 RO-E-RPCICA-3-EAR2-CALIB-V1.0 RO-E-RPCICA-3-EAR3-CALIB-V1.0 RO-M-RPCICA-2-MARS-RAW-V2.0 RO-M-RPCICA-3-MARS-CALIB-V1.0 RO-SS-RPCICA-2-CR2-RAW-V2.0 RO-SS-RPCICA-2-CR4-RAW-V2.0 RO-SS-RPCICA-3-CR2-CALIB-V1.0 RO-SS-RPCICA-3-CR4-CALIB-V1.0 RO-X-RPCICA-2-CVP2-RAW-V2.0 RO-X-RPCICA-3-CVP2-CALIB-V1.0" =============================================== Errors for: GLOBAL (all datasets) DATA_SET_ID disconnect: --> CVP vs CVP2: In the past, L2 CVP has always been delivered and released to the public as RO-X-RPCICA-2-CVP-RAW-VX.X. We should continue that. Using CVP2 now seems out of place. To be consistent should also do this for L3 data sets. In the DATA_SET_ID please use "CVP" not "CVP2". --> CR4B vs CR4: In 2017, L2 CR4B V2.0 was released to the public as RO-SS-RPCICA-2-CR4B-RAW-V2.0. V1.0 was just "CR4" as opposed to "CR4B". Which should be used? If changing from "CR4B" to "CR4", please document this in the DATA_SET_DESC for RO-SS-RPCICA-2-CR4-RAW-V2.0 along with the statement it is replacing the prior released delivery from 2017. Whatever you do, please be consistent with L2/3/4. --> "RO-C-RPCICA-4-EXT1-PHYS_MASS-V1.0" is not a valid DATA_SET_ID. Underscores are not allowed. Only alpha-numeric and the dash, and a period for the version. --> Don't forget to update the DATA_SET_ID where ever it might be found, labels, documents, citations, etc. VOLUME_ID problem: --> Some VOLUME_ID values need to be corrected to the following. The rest are fine. This affected 'VOLDESC.CAT' and 'INDEX/*.LBL' and any other places the keyword may be found. =================== DS_ID: FROM => TO RO-A-RPCICA-2-AST2-RAW-V1.0: ROICA_0999 => ROICA_1008 RO-A-RPCICA-3-AST2-CALIB-V1.0: ROICA_1999 => ROICA_2008 RO-E-RPCICA-2-EAR3-RAW-V1.0: ROICA_0999 => ROICA_1007 RO-E-RPCICA-3-EAR3-CALIB-V1.0: ROICA_1999 => ROICA_2007 RO-X-RPCICA-2-CVP2-RAW-V2.0: ROICA_0999 => ROICA_1001 RO-X-RPCICA-3-CVP2-CALIB-V1.0: ROICA_1999 => ROICA_2001 =================== directory: 'BROWSE/' --> Suggest that the L3/4 data sets contain browse products as the L2 data sets do. directory: 'CALIB/' --> Note that L3/4 data sets contain a 'CALIBRATION.TXT' file that the L2 data sets do not contain. Otherwise the contents are pretty much the same. Should the L2 data sets contain this document? files: 'CALIB/*/*.LBL' --> Is the TARGET_NAME and TARGET_TYPE keywords really relevant here? The tables themselves are the same no matter what the target is. Suggest removing these keywords, unless the tables actually should be different, in which case the tables should be updated. files: 'CALIB/ELEVATION/*.LBL' --> TABLE NAME: typo "{WS}" should be changed to the actual version number. files: 'CALIB/ENERGY/*.LBL' --> TABLE NAME: typo "{WS}" should be changed to the actual version number. L2 data sets have a value. files: 'CALIB/GFACTOR/*.LBL' --> COLUMNS: change value from '5' to '9' files: 'CALIB/MASS_LOOKUP/*.LBL' --> TABLE NAME: typo "{WS}" should be changed to the actual version number. L2 data sets have a value. --> TABLE NAME and file name do not always match. The TABLE NAME always says "TABLE3" but the file name might say table1 or table2. files: 'CALIB/MASS_MASK/*.LBL' --> TABLE NAME: typo "{WS}" should be changed to the actual version number. L2 data sets have a value. file: 'CATALOG/DATASET.CAT' --> ABSTRACT_DESC: ESC2 L2 typo: "Comet escort 1" => "Comet escort 2" --> ABSTRACT_DESC: ESC4 to EXT3 L2 typo: Remove the sentences mentioning going to Version 2. These data sets are the first version. This appears to be text copied from the earlier comet phases, where there is a new version. --> ABSTRACT_DESC: L2 PRL/EAR1/EAR2/MARS/CR2/CR4B/CVP needs to add the sentences about going to version 2. They are currently missing. --> DATA_SET_DESC: Since the version number has not changed, mention should prominently be made here that the release in August 2017 has been replaced with this archive copy as of XXX, once the data is ready for release. Otherwise please version the data sets. --> DATA_SET_DESC: There is no mention of the mission phase here. The ABSTRACT_DESC is more descriptive about the phase and results (for example AST2 stated ICA suffered an overheating event and so obtained no valuable data). Such details should be mentioned here. --> --> Side note: The AST2 comment should also be mentioned in the CONFIDENCE_LEVEL_NOTE. Very appropriate to go there. Any similar comments on the confidence of the data should go in the CONFIDENCE_LEVEL_NOTE. --> CITATION_DESC: Author should be changed from "Hans N." to "Nilsson, H.", i.e. should be surname/family-name then first initial of given name. --> CITATION_DESC: The publication year should be changed from 2015 to 2018. file: 'DOCUMENT/ICA_USER_GUIDE.PDF' --> Remember to replace with the most current copy of this document. Not all data sets have the best copy. file: 'DOCUMENT/ICA_EAICD/CATINFO.TXT' --> This filename is reserved. Please use another. Remember to update this file to reflect the new name. file: 'DOCUMENT/ICA_EAICD/ICA_EAICD.PDF' --> Remember to replace with the most current copy of this document. Not all data sets have the best copy. Note: All PDF files were verified as compliant for archiving with the PDS. =============================================== Errors for: *-2-* (L2 data sets) file: 'CALIB/*/*INFO.TXT' --> PRODUCT_ID: value should be changed to "*INFO.TXT" to match L3/4. Current value appears to be a typo. file: 'CATALOG/MISSION.CAT' --> This file needs to be updated to the current version. file: 'CATALOG/REFERENCE.CAT' --> This file needs to be updated to the current version. files: 'DATA/EDITED/*/*/*/*GEOM.LBL --> Column 1: FORMAT should be changed from "A24" to "A23". files: 'DATA/EDITED/*/*/*/*HK.LBL --> Column 40,42: VALID_MAXIMUM cannot be 255 for a 1 byte column. That would require 3 byte column. files: 'DATA/EDITED/*/*/*/*L2.LBL --> COLUMN 3 BYTES: The data appears to be 8 bytes (excluding double quote). START_BYTE starts just after the opening double quote, but the bytes makes it end after the closing quotes. Change BYTES from 9 to 8. --> COLUMN 3: Strongly suggest adding a FORMAT keyword. For instance FORMAT = "A8" (per previous error). file: 'DOCUMENT/SOFTWARE/IMPORT_L2.M' --> lines 10/11: The examples here should be updated to reflect the new file name scheme. See version of this file in the L3/4 data sets as an example of the new text. file: 'INDEX/BROWSE_INDEX.LBL' --> COLUMNS: change value from '6' to '5' file: 'INDEX/INDEX.LBL' --> COLUMNS: change value from '4' to '3' =============================================== Errors for: *-3-* (L3 data sets) files: 'DATA/CALIBRATED/*/*/*/*.LBL --> ^ARCHIVE_CONTENT_DESC: "EAICD.PDF" should be "ICA_EAICD.PDF" --> ^RPC_SCIENCE_USAGE_DESC = "RPC_USER_GUIDE.PDF" file cannot be found. --> COLUMN 3 BYTES: The data appears to be 8 bytes (excluding double quote). START_BYTE starts just after the opening double quote, but the bytes makes it end after the closing quotes. Change BYTES from 9 to 8. --> COLUMN 3: Strongly suggest adding a FORMAT keyword. For instance FORMAT = "A8" (per previous error). --> COLUMN 11 UNIT: value "" should not include the gt/lt signs. Also missing value before first '/'. =============================================== Errors for: RO-C-RPCICA-4-EXT1-CORR-V1.0 file: 'CATALOG/DATASET.CAT' --> ABSTRACT_DESC: L4 data sets should mention that these are RESAMPLED XXXX DATA, not simply "CALIBRATED DATA". Please be descriptive here for the user to differentiate between different L4 types of data sets, since at this time there are at least two. Also please mention the mission phase or time frame. --> CITATION_DESC: The NAME part is for the L3 data set, not this one. --> DATA_SET_TERSE_DESC: This describes the L3 data set, not this one. files: 'DATA/CORR/*/*/*/*CORR.LBL' --> COLUMN 3 BYTES: The data appears to be 8 bytes (excluding double quote). START_BYTE starts just after the opening double quote, but the bytes makes it end after the closing quotes. Change BYTES from 9 to 8. --> COLUMN 3: Strongly suggest adding a FORMAT keyword. For instance FORMAT = "A8" (per previous error). --> COLUMN 11 UNIT: value "" should not include the gt/lt signs. Also missing value before first '/'. files: 'DATA/CORR/*/*/*/*ZERO.LBL' --> COLUMNS: Value should be changed from 11 to 5. --> CITATION_DESC: The NAME part is for the L3 data set, not this one. --> DATA_SET_TERSE_DESC: This describes the L3 data set, not this one. =============================================== Errors for: RO-C-RPCICA-4-EXT1-PHYS_MASS-V1.0 file: 'CATALOG/DATASET.CAT' --> ABSTRACT_DESC: L4 data sets should mention that these are RESAMPLED XXXX DATA, not simply "CALIBRATED DATA". Please be descriptive here for the user to differentiate between different L4 types of data sets, since at this time there are at least two. Also please mention the mission phase or time frame. files: 'DATA/PHYS_MASS/*/*/*/*.LBL' --> COLUMNS: Value should be changed from 11 to 9. --> COLUMN 3 BYTES: The data appears to be 8 bytes (excluding double quote). START_BYTE starts just after the opening double quote, but the bytes makes it end after the closing quotes. Change BYTES from 9 to 8. --> COLUMN 3: Strongly suggest adding a FORMAT keyword. For instance FORMAT = "A8" (per previous error). --> COLUMN 9 UNIT: value "" should not include the gt/lt signs. Also missing value before first '/'.