a.swan_derived/ ** Question: Do we get to review the bundle with LID urn:nasa:pds:soho? (all other nodes create bundle) - The labels all have references to urn:nasa:pds:context:investigation:mission.soho ** Question: please confirm that we agreed on that over the original one: urn:nasa:pds:context:investigation:mission.solar_and_heliospheric_observatory If intend to use the original one, then all labels need to be changed - The labels all have references to urn:nasa:pds:context:instrument:swan.soho ** Major, please provide a context product for that. ** If SBN wants to provide lid_references to the comets in this collection, EN can provide the LIDs. ** Suggestion, EN (and the DPH) recommends that the Root Tag include: xmlns:pds="http://pds.nasa.gov/pds4/pds/v1" This has been debated, and there is no consequence for ignoring. a.swan_derived/collection.xml - The data products' LIDs are not derived from this file's LID: urn:nasa:pds:soho:swan_comet_water while the product LIDs are: urn:nasa:pds:soho:swan_derived:c_2012_k1_panstarrs_water_tab urn:nasa:pds:soho:swan_derived:c_2013_r1_lovejoy_water_tab … (all 13 files) ** Major, suggest either change the Collection LID to urn:nasa:pds:soho:soho:swan_derived or change the product LIDs b.gio-c-nms-4-86p-v1.0/catalog/dataset.cat - This keyword is illegal here. It's used in target.cat TARGET_TYPE = "COMET" ** Major, please delete this line. b.gio-c-nms-4-86p-v1.0/catalog/instrument.cat - These are referred to here but not defined in reference.cat: Meier1993 Reber1993 Reber1997 Krankowskyetal1981 Plus they should be all caps ** Major, suggest to define, and capitalize them b.gio-c-nms-4-86p-v1.0/catalog/reference.cat - All values of REFERENCE_KEY_ID should be all caps. ** Major, please fix this file and any files (like instrument.cat) that refer to them. ETAL is also missing from some. Please add. - REFERENCE_DESC is formed incorrectly. Refer to the PDS3 standards. Example: REFERENCE_KEY_ID = "Berthelier1986" REFERENCE_DESC = " Angular and energy distribution of low energy cometary ions measured in the outer coma of Comet Halley, Berthelier, J J; Illiano, J M; Hodges, R R; Krankowsky, D Eberhardt,P; Laemmerzahl, P; Hoffman, J H; Herrewerth, I; Woweries, J; Dolder,U, ESA Proceedings of the 20th ESLAB Symposium on the Exploration of Halley's Comet ** Major, suggest to change to: REFERENCE_KEY_ID = "BERTHELIERETAL1986" REFERENCE_DESC = "Berthelier, J.J., J.M. Illiano, R.R. Hodges, D. Krankowsky, P. Eberhardt, P. Laemmerzahl, J.H. Hoffman, I. Herrewerth, J. Woweries, and U. Dolder, Angular and energy distribution of low energy cometary ions measured in the outer coma of Comet Halley, ESA Proceedings of the 20th ESLAB Symposium on the Exploration of Halley's Comet, Volume 1: Plasma and Gas, pp. 175-178, 1986 ** This issue applies to the entire file, please fix them all. b.gio-c-nms-4-86p-v1.0/data/.../*.tab - PROCESSING_LEVEL_ID has type identifier, so a numeric value needs quotes, re: PROCESSING_LEVEL_ID = 4 ** Major, please change to “4” - Values should be all caps, re: PRODUCER_INSTITUTION_NAME = "University of Bern" ** Minor, please capitalize b.gio-c-nms-4-86p-v1.0/document/*.lbl - REVISION_ID is an illegal keyword ** Major, suggest to remove or add something like VERSION_ID - RELEASE_ID has type identifier, so its value needs quotes ** Major, please add quotes b.gio-c-nms-4-86p-v1.0/document/docinfo.txt - This file needs PDS label info at the top ** Major, please add, e.g., from a recent DAWN review PDS_VERSION_ID = PDS3 RECORD_TYPE = STREAM OBJECT = TEXT PUBLICATION_DATE = 2017-10-19 NOTE = "Description of contents of DOCUMENT directory" END_OBJECT = TEXT END [your text] b.gio-c-nms-4-86p-v1.0/errata.txt - Like docinfo.txt, this needs PDS label info at the top. ** Major, same as above (docinfo.txt), please add b.gio-c-nms-4-86p-v1.0/label/nms_data3.fmt b.gio-c-nms-4-86p-v1.0/label/nms_data4.fmt BYTES = 57 should be 56 ** Major, please replace ** The following comments apply to all remaining data sets: - All calib/ and document/ (except data_summary.lbl) labels have MISSION_NAME = "NEW HORIZONS KUIPER BELT EXTENDED MISSION" However, all data/ labels and data_summary.lbl have MISSION_NAME = "NEW HORIZONS" ** Major, be consistent ** we assume MISSION_NAME = "NEW HORIZONS KUIPER BELT EXTENDED MISSION" */catalog/nh_kem.cat - MISSION_DESC should unambiguously give the values of MISSION_PHASE_NAME. It currently has: Full MISSION_PHASE_NAME, Short name Start(1,3) Stop(2,3) plus optional Description ---------- ---------- --------- ------------------------- KEMCRUISE1 2016-10-26 2018-08-14 KEM CRUISE1, KBO1 CRUISE, Pluto-KBO1 Cruise, Kuiper belt Extended Mission (KEM) first cruise (4) KEM1 2018-08-14 TBD KEM1 ENCOUNTER, KBO1 ENCOUNTER, KBO1 approach, flyby, post-encounter (4) ** Major, please make it clear of the valid values being used for MISSION_PHASE_NAME# ** Major, Values must be all caps, which implies 4 new values: "KEM CRUISE 1", "KBO1 CRUISE", "KEM1 ENCOUNTER", "KBO1 ENCONTER" None of the above is being used in data labels, every data label in this review only has MISSION_PHASE_NAME = "CRUISE TO FIRST KBO ENCOUNTER" ** suggest add "CRUISE TO FIRST KBO ENCOUNTER" in the table above in nh_kem.cat */voldesc.cat - Values must be all caps, so VOUME_SET_NAMEs have NEW HORIZONS ALICE Kuiper Belt cruise 1 RAW DATA NEW HORIZONS ALICE Kuiper Belt cruise 1 CALIBRATED DATA ... NEW HORIZONS SWAP Kuiper Belt cruise 1 CALIBRATED DATA ** Minor, please capitalize them e.nh-x-leisa-2-kemcruise1-v1.0/data/.../*.lbl - To match the orientation of fv, SAMPLE_DISPLAY_DIRECTION = "LEFT" should be "RIGHT" ** Major, please correct g.nh-x-lorri-2-kemcruise1-v1.0/catalog h.nh-x-lorri-3-kemcruise1-v1.0/catalog - Some data labels reference targets "2011 HJ103" "2012 HE85" "2012 HZ84" "2014 OE394 "ASTEROID 119951 (2002 KX14)" ** Major, please provide target.cat for them o.nh-x-sdc-2-kemcruise1-v1.0/calib/*.tab p.nh-x-sdc-3-kemcruise1-v1.0/calib/*.tab - Bug: DATA_SET_ID = "__MACRO_DATASET_UPPER__" ** Major, please fix o.nh-x-sdc-2-kemcruise1-v1.0/document/sdc_stim_v0002.tab p.nh-x-sdc-3-kemcruise1-v1.0/document/sdc_stim_v0002.tab - Line 9 is too long, making the data start at the wrong spot. ** Major, please correct