September 2019 Comet Review
===========================

Spitzer IRS Comet Spectroscopy Liens
====================================

Reviewers: Adam McKay, Mike DiSanti
===================================

file: overview.pdf
--> Table 2 could be more explicit about what “. . .” ,means in aperture column.
--> In Table 3 I assume “ . . .” means no observation, but this isn’t explicit.
--> Units on example plots are not those for the data, made comparison more difficult.

DATA
--> Should context info in .csv files be in separate file? Makes reading in data more difficult.
--> In some cases “nucleus” flux > total flux at some wavelengths. Perhaps the assumed albedo (0.05) is over-estimated?

file: data/spectrum1d/132P_Helin_Roman_Alu_2-pre2.074-20051120.14-irs.csv
--> Errors too small? Lots of scatter where the error bars are small. Is this a real feature?

Suggestion: Add a short “readme.txt” file, describing the 7 columns contained in the .csv files.  Although in the csv header information, this would make it easier for users. Particularly that inter-order/inter-module scaling factor (“scales”) is already included, so spectra can be plotted without further scaling.

Engineering Review: Emily Law
=============================

spitzer-spec-comet/.../*xml
- All files reference:
  urn:nasa:pds:context:investigation:mission.spitzer
  urn:nasa:pds:context:instrument_host:spacecraft.spitzer
  urn:nasa:pds:context:instrument:irs.spitzer
EN has not received context products for those. The first two LIDs would
be fine, but the third should be reversed, i.e.
  urn:nasa:pds:context:instrument:spitzer.irs
That is based on the proposed PDS4_Context_Products_Guide_V1.4.pdf.
Please send these EN context products to be ingested.

- No files reference LIDs for targets. PDS has already created context
products and their LIDs for some of the targets in this review, e.g.
  urn:nasa:pds:context:target:comet.9p_tempel_1
  urn:nasa:pds:context:target:comet.c2001_q4_neat
We could create the rest if requested. This affects search.
If LIDs and context products are to be created. They should be added as references in the products.


- The files begin (with less friendly white space shown below):
  <?xml version="1.0" encoding="UTF-8"?>
  <?xml-model href="../PDS4/pds/v1/PDS4_PDS_1A10.xsd"
    schematypens="http://purl.oclc.org/dsdl/schematron"?>
  <?xml-model href="../PDS4/sp/v1/PDS4_SP_1A10.xsd"
    schematypens="http://purl.oclc.org/dsdl/schematron"?>
  <?xml-model href="../PDS4/geom/v1/PDS4_GEOM_1A10.xsd"
    schematypens="http://purl.oclc.org/dsdl/schematron"?>
  <Product_Observational
    xmlns="http://pds.nasa.gov/pds4/pds/v1"
    xmlns:geom="http://pds.nasa.gov/pds4/geom/v1"
    xmlns:sp="http://pds.nasa.gov/pds4/sp/v1"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="
      http://pds.nasa.gov/pds4/pds/v1 ../PDS4/pds/v1/PDS4_PDS_1B00.xsd
      http://pds.nasa.gov/pds4/sp/v1 ../PDS4/sp/v1/PDS4_SP_1A10.xsd
      http://pds.nasa.gov/pds4/geom/v1 ../PDS4/geom/v1/PDS4_GEOM_1A10.xsd ">
1) For the data labels, in <?xml-model, the href should be to .sch not .xsd
2) For the data labels, the versions of PDS4_PDS_* should be the same. - i.e,should not have both 1A10 and 1B00 except PSA4_SP_1A10 is ok to be different.
Element information_model_version must match whatever you converge on. 
3) For both <?xml-model and schemaLocastion, please replace the relative path
names with the URLs at pds.nasa.gov, e.g.
  <?xml-model href="../PDS4/pds/v1/PDS4_PDS_1A10.xsd"
    schematypens="http://purl.oclc.org/dsdl/schematron"?>
should be
  <?xml-model href="https://pds.nasa.gov/pds4/pds/v1/PDS4_PDS_1B00.sch"
    schematypens="http://purl.oclc.org/dsdl/schematron"?>
and
    xsi:schemaLocation="
      http://pds.nasa.gov/pds4/pds/v1 ../PDS4/pds/v1/PDS4_PDS_1B00.xsd
should be
    xsi:schemaLocation="
      http://pds.nasa.gov/pds4/pds/v1 https://pds.nasa.gov/pds4/pds/v1/PDS4_PDS_1B00.xsd
4) EN (and the DPH) recommends that the Root Tag include:
    xmlns:pds="http://pds.nasa.gov/pds4/pds/v1"

spitzer-spec-comet/collection.xml
- This file does not reference
  urn:nasa:pds:context:investigation:mission.spitzer
as every other label does. That will affect search results
- the schematron specification is required but missing.
need something similar to: <?xml-model href="../PDS4/pds/v1/PDS4_PDS_1A10.sch"
    schematypens="http://purl.oclc.org/dsdl/schematron"?>



spitzer-spec-comet/data/spectrum1d/41P_Tuttle_Giacobini_Kresak-pre1.275-20060418.09-irs-cubism.xml
- The following has a non-Latin character, which is illegal:
  <title>Spitzer/IRS spectrum of comet 41P/Tuttle-Giacobini-Kresák at 1.275 AU on 2006-04-18 02:07</title>
  
Certification: Certified with liens