Created by SBN:T.Barnes for the Rosetta MUST data sets for April 2020 peer review. =============================================== Datasets Validated: RO-X-HK-3-ANTENNASTATUS-V1.0 RO-X-HK-3-AOCGEN-V1.0 RO-X-HK-3-EDAC-V1.0 RO-X-HK-3-HGAAPM-V1.0 RO-X-HK-3-IMP-V1.0 RO-X-HK-3-NAVCAM-V1.0 RO-X-HK-3-OCMRCS-V1.0 RO-X-HK-3-RWL-V1.0 RO-X-HK-3-SOLARARRAY-V1.0 RO-X-HK-3-STARTRACKER-V1.0 =============================================== Errors for: GLOABL (all datasets) file: 'AAREADME.TXT' --> Introduction par 2: change "March 2014" to "March 2004" (note year). Or change "entire Rosetta Mission" to something else because it is not the "entire". file: RO-X-HK-3-{AOCGEN,HGAAPM,IMP,NAVCAM,STARTRACKER,TCS}-V1.0/BROWSE/BROWINFO.TXT --> Required End of Line characters are missing carriage return. file: 'CATALOG/DATASET.CAT' --> LABEL_REVISION_NOTE was changed, not updated. You should not be changing a label revision note, but only appending to it normally. Since this has not been released, we can live with it but it is very disconcerting: Example: =================== < LABEL_REVISION_NOTE = "2019-07-18, L. O'Rourke, Created" --- > LABEL_REVISION_NOTE = "2019-11-30, L. O'Rourke, Updated based on Sep-2019 > Review" =================== --> CITATION_DESC: Year should be changed from 2019 to 2020. --> CONFIDENCE_LEVEL_NOTE: Remember to update after 2020 April review. Currently it states "Updated from Sept 2019 review" which is not helpful or a correct usage of this keyword. --> TARGET_NAME: Since all values in the DATA directory were "N/A", this value in this file should also be "N/A". You cannot state 67P was the target of the data set when it was never observed. file: 'CATALOG/INST_ROS_HK.CAT' --> The LABEL_REVISION_NOTE has changed, not merely been updated. Normally you should not alter the label revision note, only append. Since no change was made to the contents of this file, it is distressing to see this label revision note change. Once this file is going into the archive the label revision note text should remain unchanged unless the file's text changes, in which case the label revision note should be appended to, not replaced. Please replace the text with "First version" or something to that effect. files: 'DATA/ ... /*.LBL --> COLUMN 2 mismatch. For all cases where the combination of BYTES = 15 and FORMAT = "I5", these two do not match. BYTES is 15, but the FORMAT only covers 5 bytes. FORMAT should cover all 15 bytes or the other keywords would need to be corrected (BYTES to 5, START_BYTE changing, etc). file: 'INDEX/INDEX.LBL' --> REVISION_ID: Invalid and unknown keyword. Relic of old data sets. Please remove. The process to generate these files is different than what has been used for years. Are they using old code? This was not a problem in the Sept 2019 reviewed version. file: 'RO-X-HK-3-AOCGEN-V1.0/INDEX/INDEX.*' --> These files are for RO-X-HK-3-ANTENNASTATUS-V1.0 not RO-X-HK-3-AOCGEN-V1.0. Please regenerate the files. UNKNOWN_VALUES: The following keywords have undefined values. Should be added to Rosetta Mission dictionary *or* corrected in the DATA label to a value specified in the Rosetta Mission dictionary. I noticed some values were manipulated (including or not including a dash for instance). I have not received an updated dictionary so that may also be the cause. --> ROSETTA:SC_HK_SUBSYSTEM - "ANTENNASTATUS", "AOCGEN", "HGAAPM", "OCMRCS", "SOLARARRAY" --> ROSETTA:SUBSYSTEM_DATA_TYPE - "X_BAND_TWTA_1_2_STATUS", "CONSERT_ANT_TEMP", "GIADA_TEMP", "MIDAS_TEMP", "MIRO_TEMP", "OSIRIS_TEMP", "RF_ANTENNA_TEMP", "ROSINA_TEMP", "RPC_BOOM_TEMP", "RPC_ICA_TEMP", "RPC_IES_TEMP", "SAS_TEMP", "SREM_TEMP", "SSP_ANT_TEMP", "VIRTIS_TEMP"