DART DRACO Liens ================ file: readme.txt --> Line 17, something seems to be missing in “See these resources in the [ ] for more information” Documentation ============= --> Some repetitive information in each of both documents can be removed to avoid potential conflict and simplify reading. E.g., raw image format is “single HDU, 1024 x 1024, 32-bit floating point FITS, 2x2 binned from the original 2048 x 2048 window1…” appears a few times in an identical form. file: jhuapl_dart_draco_calibration_pipeline_descxription_210315.pdf --> Page 9, first few lines: calibration pipeline input file directory ‘cal_files/’ and subdirectory structure described here are different from the directory structure in the data bundle. --> Last page, FITS keyword IFOV is missing in calibrated images, and not included in the SIS doc --> Page 13: REFDKAR2 -> REFDARK2 file: jhuapl_dart_draco_uncalibrated_calibrated_sis_210626.pdf --> Page 12, section 4.1.3: “DRACO typically employs high gain, 30x when operating in rolling shutter mode to maximize the SNR”. (Li): I though high gain is to utilize full-well capacity, while low gain is to maximize SNR. --> SIS document, page 20, section 4.3.3: Clarify whether this section applies to lightcurve data (which is not included in this sample data) --> Page 13, third line from bottom: an extra ` in “spacecraft`” --> Page 18, last sentence in the first paragraph of section 4.3.2.2: “… are included in the as part of”, remove “in the” --> Table 4: Some critical geometry backplane values should be explained more specifically. --> Clarify how geometry values are calculated when the image includes both Didymos and Dimorphos. Are XYZ lat lon defined in different frame? --> Clarify whether gravity-related values (backplanes 14, 16, 16) are calculated in two body system or one body. --> For some photometry users, how the incidence and emission angles are derived from the shape model can be very important. Suggest to explain the averaging method for calculating these angles somewhere. --> Table 3 ----> I/F is not the unit of Calibrated Images. ----> Mixing Radiance and I/F is often confusing. IOVERF keyword is strange, as I/F or RADF is expected. Suggestion: Generate level 2a and 2b datasets that distinguish between these two. ----> Add the names of Image Backplane layers to the description column. Calibration Data ================ file: draco_lookup_*.csv --> File contains header information commented by hashtag (#), therefore it cannot be directly opened by MS Excel, but no problem with other more generic tools such as `astropy.io.ascii`. Include
class in label to document these bytes. --> Are Calibration Files files L4? Or should they go with calibrated data bundle as part of the calibration documentation? Calibrated Data =============== *.fits --> Include "error image" extensions with standard deviation error and data quality flags to aid analysis. --> FITS header cards are copied from raw to calibrated ata. Remove those that are not necessary. Do all those track ID relate to scientific applications? --> Geometry backplane data: add SPICE kernel information to XML label via the Geometry dictionary. Engineering Node Review ======================= *.xml - Please change urn:nasa:pds:context:target:asteroid.didymos to urn:nasa:pds:context:target:asteroid.65803.didymos - Only bundle.xml and collection*.xml have a lid_reference to the target. We suggest that all labels, especially data labels, have such. - Please change the LID for the instrument from urn:nasa:pds:context:instrument:draco.dart to urn:nasa:pds:context:instrument:dart.draco - Almost all labels have DART Spacecraft Since Spacecraft is deprecated, please change Spacecraft to Host bundle_dart_spacecraft.xml - The lid_references of the collections urn:nasa:pds:dart_teleobs:ldt_doc urn:nasa:pds:dart_teleobs:ldt_raw urn:nasa:pds:dart_teleobs:ldt_cal urn:nasa:pds:dart_teleobs:ldt_ddp don't match the collection*.xml's LIDs: urn:nasa:pds:dart:dartdoc urn:nasa:pds:dart:dracocal urn:nasa:pds:dart:dracoddp urn:nasa:pds:dart:dracoraw Perhaps the former were copied from the other bundle and not modified. Please change to be consistent - reference_type is wrong for the doc collection, i.e. urn:nasa:pds:dart_teleobs:ldt_doc bundle_has_data_collection Please change to: urn:nasa:pds:dart:dartdoc #previous bullet bundle_has_document_collection - Please add lid_references to instrument_host and instrument, as the other labels do. caibration/ - If this directory contains calibration files while draco/final/calibrated/ contains calibrated data files, then the two sets of files probably should not share the same collection.xml and collection LID urn:nasa:pds:dart:dracocal and that 1) this directory should have its own collection.*, 2) collection.xml and all the files in this directory would have LIDs beginning with something like urn:nasa:pds:dart:calibration 3) bundle.xml should correspondingly add urn:nasa:pds:dart:calibration bundle_has_calibration_collection document/.../*.xml (many, but not all) - file_size does not match the actual filesize, e.g. in document/draco/overview_dracoraw.xml, overview_dracoraw.txt 1578 but the size of overview_dracoraw.txt is 515 bytes Please fix - Please add lid_references to investigation, instrument_host, instrument, and target if applicable, as the other labels do. document/collection_dartdoc.xml document/collection_dracodoc.csv - These should have the same base filename. document/draco/*pdf - These comply with PDFA-3A and almost PDSA-3B but not the required PDFA-1A document/draco/jhuapl_dart_draco_uncalibrated_calibrated_sis_210626.pdf - Suggestion: briefly describe PDS4, particularly the LID convention document/draco/jhuapl_dart_draco_uncalibrated_calibrated_sis_210626.xml document/draco/jhuapl_dart_draco_calibration_pipeline_description_210315.xml - collection.xml has LID urn:nasa:pds:dart:dartdoc which does not match these two files' LIDs of urn:nasa:pds:dart:dart_doc:jhuapl_dart_draco_calibration_... urn:nasa:pds:dart:dart_doc:jhuapl_dart_draco_uncalibrated_... Please change these two LIDs to urn:nasa:pds:dart:dartdoc:jhuapl_dart_draco_calibration_... urn:nasa:pds:dart:dartdoc:jhuapl_dart_draco_uncalibrated_... and modify collection.csv to match. document/draco/label_examples/ - Is this directory needed? It seems to have sample labels, but the actual labels are already in this bundle. If still needed, please add all the LIDs to colleciton_dracodoc.csv and add Citation_Information to each label; if not, please delete the dir and its contents. draco/ - This subdirectory is organized incorrectly. The LIDs of the lowest-level products imply three collections urn:nasa:pds:dart:dracoddp urn:nasa:pds:dart:dracocal urn:nasa:pds:dart:dracoraw The Standards Reference section 2B.2.2.2 says, "The top-level subdirectories have a one-to-one correspondence with the bundle’s collections," so draco/ should be three separate directories, one for each collection. Furthermore, Section 2b.2.2.1 lists valid names of top-level subdirs, in particular data[_*], so the top-level subdirs should be named data_dracoddp/ data_dracocal/ data_dracoraw/ Or perhaps data_ddp/ data_cal/ data_raw/ Many, certainly not all, collection LIDs match the directory name exactly, suggest changing all the LIDs from the current urn:nasa:pds:dart:dracocal:draco_bad_pixels_20210107 urn:nasa:pds:dart:dracocal:draco_bias_global_1x_n20c_20210225 ... to, assuming you chose data_cal/ et al to be the directory names, urn:nasa:pds:dart:data_cal:draco_bad_pixels_20210107 urn:nasa:pds:dart:data_cal:draco_bias_global_1x_n20c_20210225 ... - If you do change the directory structure as suggested, please create subdirs in data_dracocal/ and data_dracoraw/ because those would have too many files. draco/collection*.xml - All have lid_reference to non-existent LID urn:nasa:pds:dart:dartdoc:jhuapl_dart_draco_uncalibrated_calibrated_sis_210325 while the closest LID among the documents is urn:nasa:pds:dart:dart_doc:jhuapl_dart_draco_uncalibrated_calibrated_sis_210626 Please converge on one version of the LID draco/final/*.sh - Suggest deleting these files - None of the Product_Observational have Primary_Result_Summary. EN recommends it to facilitate searching at the product level.