DART Lowell Liens
=================

Documentation
=============

--> Note somewhere the tracking that was used during exposures (asteroid's rate, sidereal rate, half-asteroid rate).

--> Add DART SOC or Lowell ICD as documents, or add them as references (in Reference_List class) in documents where they are mentioned.

--> Include observing log, which may include some detailed information about weather and any other factors that might affect data quality. 

file: Lowell_dart_uncalibrated_calibrated_sis.pdf
--> Please include page numbers.

--> Section 4.1, paragraph 2: "arc minute" -> "arcminute"

--> Section 4.1, paragraph 3: Also include continuum filtes: UC = UV continuum, BC = blue continuum, GC = green continuum, RC = red continuum.

--> Section 4.4.6, last paragraph: Clarify whether calibration was restricted to solar-type stars when converting to r-band magnitudes.

--> Use FITS or fits consistently throughout document.

--> Section 5.5.1, GAIN keyword: add units "in electrons per ADU" to description.

--> Section 5.5.1, RDNOISE keyword: LMI description elsewhere was 2.1, not 6. Add units "in ADU" to description.

--> Section 5.5.1, DETTEMP keyword: Add units "in degC" to description.

--> Section 5.5.1, TEMPCCD keyword: Add units "in degC" to description.

--> Section 5.5.1, ZA keyword: Add units "in deg" to description.

--> Section 5.5.1, PARANGLE keyword: Add units "in deg" to description.

--> Section 4.4.7: the explanation of image number says “_0157_ is the 157th image generated on that UT date”.  But it’s probably better not say this because otherwise you’ll need to explain the missing images in the data directory.

--> Section 5.1: example for documentation directory ‘documentation/lowell/…’ is different from the actual directory ‘documentation/lowell_doc/…’.  Need to make them consistent.

file: source_extractor_flags.txt
--> Missing a value of 1.  Some rows in the lightcurve table has flag values of 3.

file: Collection_lowelldoc.xml [and probably elsewhere]
--> “Lowell Discovery Telescope” and “Discovery Channel Telescope” are used. Try to standardize all uses or note at a high level that both are the same telescope (new vs old name)


Data
====

file: *_photometry.dat
--> Use .tab extension, rather than .dat.
--> Trailing 0s were not printed in this table. Use same number of significant digits for all values in a column
--> Ambiguity about array indexing [wording fix needed in documentation]
TRIMSEC and BIASSEC both give arrays of pixels as [x1:x2, y1:y2]. To  match the provided data, these should be interpreted as including pixels from x1 to x2-1 and y1 to y2-1.


Engineering Node Review
=======================

*.xml

- All labels have exactly 1 lid_reference (except documentation/*, which have none):
  urn:nasa:pds:context:investigation:mission.double_asteroid_redirection_test
Sugggest adding lid_references to the facility, telescope, and instrument.
The facility is probably
  urn:nasa:pds:context:facility:observatory.lowell
which already exists at https://pds.nasa.gov/data/pds4/context-pds4/facility/.
Currently, only two Lowell telescopes have been defined:
  urn:nasa:pds:context:telescope:lowell.perkins_warner1m83 (Anderson Mesa)
  urn:nasa:pds:context:telescope:lowell.21in0 (Mars Hill)
LDT is not either of those? If not, we can define the LID and context product
for it and the instrument, perhaps
  urn:nasa:pds:context:telescope:lowell.ldt4m3
  urn:nasa:pds:context:instrument:lowell.ldt4m3.lmi
Other PDS nodes should weigh in on that.

- Please change
  urn:nasa:pds:context:target:asteroid.didymos
to
  urn:nasa:pds:context:target:asteroid.65803.didymos
- Only bundle.xml and collection*.xml have a lid_reference to the target.
We suggest that all labels, especially data labels, have such.

bundle_dart_teleobs.xml

- Since the documetation directory is for docs, please change the second line of
  <lid_reference>urn:nasa:pds:dart_teleobs:ldt_doc</lid_reference>
  <reference_type>bundle_has_data_collection</reference_type>
to
  <reference_type>bundle_has_documenation_collection</reference_type>


documentation/

- Suggestion: rename this to named document/.  Section 2b.2.2.1 lists valid names
of top-level subdirs, in particular document/ not documentation/

documentation/.../*.xml (some, not all)

- file_size does not match the actual filesize, e.g. in
documentation/lowell_doc/source_extractor_flags.xml
  <file_name>source_extractor_flags.txt</file_name>
  <file_size unit="byte">840</file_size>
but the size of source_extractor_flags.txt is 909 bytes
Please fix

- Please add lid_references to investigation, instrument_host, instrument,
and target if applicable, as the other labels do.


documentation/example_labels

- Is this directory needed? It seems to have sample labels, but the actual
labels are already in this bundle. If still needed, please add all the LIDs
to colleciton_dracodoc.csv.  If not, please delete the dir and its contents.

documentation/lowell_doc/collection*
- These files should sit at the top level of the subdir, i.e. one level higher.

documentation/lowell_doc/lowell_dart_uncalibrated_calibrated_sis.pdf
- Suggest to briefly describe PDS4, particularly the LID convention

lowell_data/

- This subdirectory is organized incorrectly. There are 3 collections here:
  urn:nasa:pds:dart_teleobs:ldt_ddp
  urn:nasa:pds:dart_teleobs:ldt_cal
  urn:nasa:pds:dart_teleobs:ldt_raw
The Standards Reference section 2B.2.2.2 says, "The top-level subdirectories
have a one-to-one correspondence with the bundle’s collections," so lowell_data/
should be three separate directories, one for each collection. Furthermore,
Section 2b.2.2.1 lists valid names of top-level subdirs, in particular
data[_*], so the top-level subdirs should be named
  data_ldt_ddp/
  data_ldt_cal/
  data_ldt_raw/
Or perhaps
  data_ddp/
  data_cal/
  data_raw/
Many, certainly not all, collection LIDs match the directory name exactly,
if so, suggest changing all the LIDs from the current
  urn:nasa:pds:dart_teleobs:ldt_cal:lmi_20201217_0035_cal_v1
  urn:nasa:pds:dart_teleobs:ldt_ddp:ldt_20201217_didymos_photometry
  ...
to, assuming you chose data_cal/ et al to be the directory names,
  urn:nasa:pds:dart_teleobs:data_cal:lmi_20201217_0035_cal_v1
  urn:nasa:pds:dart_teleobs:data_ddp:ldt_20201217_didymos_photometry
  ...

- If you do change the directory structure as suggested, please create subdirs
in data_ldt_cal/ and data_ldt_raw/ because those would have too many files.

validateXML.sh

- Suggest deleting this file

- None of the Product_Observational have Primary_Result_Summary.
EN recommends it to facilitate searching at the product level.