dart_spacecraft_bundle *.xml - Please change urn:nasa:pds:context:target:asteroid.didymos to urn:nasa:pds:context:target:asteroid.65803.didymos - Only bundle.xml and collection*.xml have a lid_reference to the target. We suggest that all labels, especially data labels, have such. - Please provide the context products that go with LIDs: urn:nasa:pds:context:investigation:mission.double_asteroid_redirection_test urn:nasa:pds:context:instrument_host:spacecraft.dart urn:nasa:pds:context:instrument:draco.dart - Please change the LID for the instrument from urn:nasa:pds:context:instrument:draco.dart to urn:nasa:pds:context:instrument:dart.draco - Almost all labels have DART Spacecraft Since Spacecraft is deprecated, please change Spacecraft to Host bundle_dart_spacecraft.xml - The lid_references of the collections urn:nasa:pds:dart_teleobs:ldt_doc urn:nasa:pds:dart_teleobs:ldt_raw urn:nasa:pds:dart_teleobs:ldt_cal urn:nasa:pds:dart_teleobs:ldt_ddp don't match the collection*.xml's LIDs: urn:nasa:pds:dart:dartdoc urn:nasa:pds:dart:dracocal urn:nasa:pds:dart:dracoddp urn:nasa:pds:dart:dracoraw Perhaps the former were copied from the other bundle and not modified. Please change to be consistent - reference_type is wrong for the doc collection, i.e. urn:nasa:pds:dart_teleobs:ldt_doc bundle_has_data_collection Please change to: urn:nasa:pds:dart:dartdoc #previous bullet bundle_has_document_collection - Please add lid_references to instrument_host and instrument, as the other labels do. - per https://pds.nasa.gov/datastandards/documents/policy/PolicyOnDOI10142020.pdf bundle.xml needs , which for now can be obtained as instructed in: https://pds-engineering.jpl.nasa.gov/content/doi caibration/ - If this directory contains calibration files while draco/final/calibrated/ contains calibrated data files, then the two sets of files probably should not share the same collection.xml and collection LID urn:nasa:pds:dart:dracocal and that 1) this directory should have its own collection.*, 2) collection.xml and all the files in this directory would have LIDs beginning with something like urn:nasa:pds:dart:calibration 3) bundle.xml should correspondingly add urn:nasa:pds:dart:calibration bundle_has_calibration_collection document/.../*.xml (many, but not all) - file_size does not match the actual filesize, e.g. in document/draco/overview_dracoraw.xml, overview_dracoraw.txt 1578 but the size of overview_dracoraw.txt is 515 bytes Please fix - Please add lid_references to investigation, instrument_host, instrument, and target if applicable, as the other labels do. document/collection_dartdoc.xml document/collection_dracodoc.csv - These should have the same base filename. document/draco/*pdf - These comply with PDFA-3A and almost PDSA-3B but not the required PDFA-1A document/draco/jhuapl_dart_draco_uncalibrated_calibrated_sis_210626.pdf - Suggestion: briefly describe PDS4, particularly the LID convention document/draco/jhuapl_dart_draco_uncalibrated_calibrated_sis_210626.xml document/draco/jhuapl_dart_draco_calibration_pipeline_description_210315.xml - collection.xml has LID urn:nasa:pds:dart:dartdoc which does not match these two files' LIDs of urn:nasa:pds:dart:dart_doc:jhuapl_dart_draco_calibration_... urn:nasa:pds:dart:dart_doc:jhuapl_dart_draco_uncalibrated_... Please change these two LIDs to urn:nasa:pds:dart:dartdoc:jhuapl_dart_draco_calibration_... urn:nasa:pds:dart:dartdoc:jhuapl_dart_draco_uncalibrated_... and modify collection.csv to match. document/draco/label_examples/ - Is this directory needed? It seems to have sample labels, but the actual labels are already in this bundle. If still needed, please add all the LIDs to colleciton_dracodoc.csv and add Citation_Information to each label; if not, please delete the dir and its contents. draco/ - This subdirectory is organized incorrectly. The LIDs of the lowest-level products imply three collections urn:nasa:pds:dart:dracoddp urn:nasa:pds:dart:dracocal urn:nasa:pds:dart:dracoraw The Standards Reference section 2B.2.2.2 says, "The top-level subdirectories have a one-to-one correspondence with the bundle’s collections," so draco/ should be three separate directories, one for each collection. Furthermore, Section 2b.2.2.1 lists valid names of top-level subdirs, in particular data[_*], so the top-level subdirs should be named data_dracoddp/ data_dracocal/ data_dracoraw/ Or perhaps data_ddp/ data_cal/ data_raw/ Many, certainly not all, collection LIDs match the directory name exactly, suggest changing all the LIDs from the current urn:nasa:pds:dart:dracocal:draco_bad_pixels_20210107 urn:nasa:pds:dart:dracocal:draco_bias_global_1x_n20c_20210225 ... to, assuming you chose data_cal/ et al to be the directory names, urn:nasa:pds:dart:data_cal:draco_bad_pixels_20210107 urn:nasa:pds:dart:data_cal:draco_bias_global_1x_n20c_20210225 ... - If you do change the directory structure as suggested, please create subdirs in data_dracocal/ and data_dracoraw/ because those would have too many files. draco/collection*.xml - All have lid_reference to non-existent LID urn:nasa:pds:dart:dartdoc:jhuapl_dart_draco_uncalibrated_calibrated_sis_210325 while the closest LID among the documents is urn:nasa:pds:dart:dart_doc:jhuapl_dart_draco_uncalibrated_calibrated_sis_210626 Please converge on one version of the LID draco/final/*.sh - Suggest deleting these files * - EN (and the DPH) recommends that the Root Tag include: xmlns:pds="http://pds.nasa.gov/pds4/pds/v1" This has been debated, and there is no consequence for ignoring. - EN similarly recommends, with no consequence for ignoring, that in order to create a more self-describing bundle, the bundle have xml_schema/ with secondary copies of the schema and schematron used. - None of the Product_Observational have Primary_Result_Summary. EN recommends it to facilitate searching at the product level. dart_teleobs *.xml - All labels have exactly 1 lid_reference (except documentation/*, which have none): urn:nasa:pds:context:investigation:mission.double_asteroid_redirection_test Sugggest adding lid_references to the facility, telescope, and instrument. The facility is probably urn:nasa:pds:context:facility:observatory.lowell which already exists at https://pds.nasa.gov/data/pds4/context-pds4/facility/. Currently, only two Lowell telescopes have been defined: urn:nasa:pds:context:telescope:lowell.perkins_warner1m83 (Anderson Mesa) urn:nasa:pds:context:telescope:lowell.21in0 (Mars Hill) LDT is not either of those? If not, we can define the LID and context product for it and the instrument, perhaps urn:nasa:pds:context:telescope:lowell.ldt4m3 urn:nasa:pds:context:instrument:lowell.ldt4m3.lmi Other PDS nodes should weigh in on that. - Please change urn:nasa:pds:context:target:asteroid.didymos to urn:nasa:pds:context:target:asteroid.65803.didymos - Only bundle.xml and collection*.xml have a lid_reference to the target. We suggest that all labels, especially data labels, have such. bundle_dart_teleobs.xml - Since the documetation directory is for docs, please change the second line of urn:nasa:pds:dart_teleobs:ldt_doc bundle_has_data_collection to bundle_has_documenation_collection - per https://pds.nasa.gov/datastandards/documents/policy/PolicyOnDOI10142020.pdf bundle.xml needs , which for now can be obtained via https://pds-engineering.jpl.nasa.gov/content/doi documentation/ - Suggestion: rename this to named document/. Section 2b.2.2.1 lists valid names of top-level subdirs, in particular document/ not documentation/ documentation/.../*.xml (some, not all) - file_size does not match the actual filesize, e.g. in documentation/lowell_doc/source_extractor_flags.xml source_extractor_flags.txt 840 but the size of source_extractor_flags.txt is 909 bytes Please fix - Please add lid_references to investigation, instrument_host, instrument, and target if applicable, as the other labels do. documentation/example_labels - Is this directory needed? It seems to have sample labels, but the actual labels are already in this bundle. If still needed, please add all the LIDs to colleciton_dracodoc.csv. If not, please delete the dir and its contents. documentation/lowell_doc/collection* - These files should sit at the top level of the subdir, i.e. one level higher. documentation/lowell_doc/lowell_dart_uncalibrated_calibrated_sis.pdf - Suggest to briefly describe PDS4, particularly the LID convention lowell_data/ - This subdirectory is organized incorrectly. There are 3 collections here: urn:nasa:pds:dart_teleobs:ldt_ddp urn:nasa:pds:dart_teleobs:ldt_cal urn:nasa:pds:dart_teleobs:ldt_raw The Standards Reference section 2B.2.2.2 says, "The top-level subdirectories have a one-to-one correspondence with the bundle’s collections," so lowell_data/ should be three separate directories, one for each collection. Furthermore, Section 2b.2.2.1 lists valid names of top-level subdirs, in particular data[_*], so the top-level subdirs should be named data_ldt_ddp/ data_ldt_cal/ data_ldt_raw/ Or perhaps data_ddp/ data_cal/ data_raw/ Many, certainly not all, collection LIDs match the directory name exactly, if so, suggest changing all the LIDs from the current urn:nasa:pds:dart_teleobs:ldt_cal:lmi_20201217_0035_cal_v1 urn:nasa:pds:dart_teleobs:ldt_ddp:ldt_20201217_didymos_photometry ... to, assuming you chose data_cal/ et al to be the directory names, urn:nasa:pds:dart_teleobs:data_cal:lmi_20201217_0035_cal_v1 urn:nasa:pds:dart_teleobs:data_ddp:ldt_20201217_didymos_photometry ... - If you do change the directory structure as suggested, please create subdirs in data_ldt_cal/ and data_ldt_raw/ because those would have too many files. validateXML.sh - Suggest deleting this file * - EN (and the DPH) recommends that the Root Tag include: xmlns:pds="http://pds.nasa.gov/pds4/pds/v1" This has been debated, and there is no consequence for ignoring. - EN similarly recommends, with no consequence for ignoring, that in order to create a more self-describing bundle, the bundle have xml_schema/ with secondary copies of the schema and schematron used. - None of the Product_Observational have Primary_Result_Summary. EN recommends it to facilitate searching at the product level.