Lowell Phaethon Liens ===================== LMI Images ========== --> data_type in label for some reduced images from Dec 16, 17, and 18 does not match BITPIX in FITS header. When BITPIX = -32, data_type must equal IEEE754MSBSingle. DeVeny Data =========== --> In , after , add a of 32768 to match BZERO = 32768 in FITS header. --> For reduced data, XML labels all have data_type "SignedMSB2" but BITPIX in FITS headers is either 16 or -32. Need to either make all data consistent (16-bit data vs 32-bit data) or set the data_type attribute to the proper value for each file. When BITPIX = 16, data_type must equal SignedMSB2. When BITPIX = -32, data_type must equal IEEE754MSBSingle. --> Is there a reason some data 16-bit and some are 32-bit? Not stated in documentation. DeVeny Extracted Spectra ======================== --> Reading using READ_PDS, flux values are in the range of 1 to 10 instead of 1e-14 to 1e-11. Change field_length to 13 and field_format to %13.6e to fix. --> Reduced spectra at the bluest wavelengths look weird. Either reduction needs to be fixed, or statement added in documentation that reduced data below 3800 angstroms is not reliable. Documentation ============= --> Should include LMI and DeVeny instrument manuals for reference in DOCUMENTS directory. --> May want to include a copy of the Phaethon paper (Ye et al.). file: collection.xml --> Start and stop times don't correspond to the dates when images were obtained. file: description.pdf --> In table 1, A0 calibrator stars are introduced in association with the BC images, but there is reference for them and no mention of how they are used. Suggestions --> More detail in documentation about data, e.g. for DeVeny, is blue on the left or right? No darks included, so presumably not required, but could be explicitly stated. --> More detail for reductions/extractions --> Numerous flats and wavelength cals and various positions, were these necessary for the reduction/extractions or were the “generic” ones used? --> There is only one extracted spectrum per object, so presumably multiple spectra were extracted and stacked, were they stacked in 2D and extracted, or were extracted 1D spectra averaged? No extracted spectrum for flux standard, apparently done on 2D spectrum? --> Documentation claims reduced data were background subtracted, but I think I see sky lines in the O1 ASSASN spectrum . . . --> Multiple instrument setups in the same log was somewhat confusing, possibly create digital version that only includes relevant instrument, maybe include logs closer to data in directory pathway (though maybe this would violate PDS requirements?) --> Might want to explain that there is extra structure to sky background when dichroic is used. EN Liens ======== phaethon/data/.../*.xml - All (almost all?) labels have urn:nasa:pds:context:telescope:lowell.discovery A similar context product already exists, so presumably change to urn:nasa:pds:context:telescope:lowell.discovery_4m3 - The filenames are wrong. E.g. in data/deveny/20171215/extracted/ c2017o1.cal and c2017o1.cal.xml should be c2017o1.cal and c2017o1.xml phaethon/data/deveny/.../*.xml - All (almost all?) labels have urn:nasa:pds:context:instrument:telescope.discovery.deveny No LID *deveny* exists yet. The LID should presumably be urn:nasa:pds:context:instrument:lowell.discovery_4m3.deveny EN can create this context product if desired. phaethon/data/lmi/.../*.xml - All (almost all?) labels have urn:nasa:pds:context:instrument:telescope.discovery.lmi A similar context product already exists, so presumably change to urn:nasa:pds:context:instrument:lowell.discovery_4m3.lmi