OSIRIS final 2022 delivery peer review comments by SBN:T.Barnes

===============================================
NOTE:

(1) This is a sample delivery with the full suite of data sets for two mission phases (ESC1-M12 and CR2)

(2) All but two PDF files are archive compliant.

(3) There may be more L2 data files and significantly less L5 GEO files, per version change log.


===============================================
Datasets Validated:
	RO-C-OSINAC-2-ESC1-67PCHURYUMOV-M12-V4.0
	RO-C-OSINAC-3-ESC1-67PCHURYUMOV-M12-V4.0
	RO-C-OSINAC-4-ESC1-67P-M12-INF-REFL-V2.0
	RO-C-OSINAC-4-ESC1-67P-M12-INFLDSTR-V2.0
	RO-C-OSINAC-4-ESC1-67P-M12-REFLECT-V2.0
	RO-C-OSINAC-4-ESC1-67P-M12-STR-REFL-V2.0
	RO-C-OSINAC-4-ESC1-67P-M12-STRLIGHT-V2.0
	RO-C-OSINAC-4-ESC1-67PCHURYUMOV-M12-V3.0
	RO-C-OSINAC-5-ESC1-67P-M12-GEO-V2.0
	RO-C-OSINAC-5-ESC1-67P-M12-GEOSPICE-V1.0
	RO-C-OSIWAC-2-ESC1-67PCHURYUMOV-M12-V4.0
	RO-C-OSIWAC-3-ESC1-67PCHURYUMOV-M12-V4.0
	RO-C-OSIWAC-4-ESC1-67P-M12-INF-REFL-V2.0
	RO-C-OSIWAC-4-ESC1-67P-M12-INFLDSTR-V2.0
	RO-C-OSIWAC-4-ESC1-67P-M12-REFLECT-V2.0
	RO-C-OSIWAC-4-ESC1-67P-M12-STR-REFL-V2.0
	RO-C-OSIWAC-4-ESC1-67P-M12-STRLIGHT-V2.0
	RO-C-OSIWAC-4-ESC1-67PCHURYUMOV-M12-V3.0
	RO-C-OSIWAC-5-ESC1-67P-M12-GEO-V2.0
	RO-C-OSIWAC-5-ESC1-67P-M12-GEOSPICE-V1.0
	RO-X-OSINAC-2-CR2-CHECKOUT-V3.0
	RO-X-OSINAC-3-CR2-CHECKOUT-V3.0
	RO-X-OSINAC-4-CR2-CHECKOUT-V2.0
	RO-X-OSINAC-4-CR2-CHKOUT-INF-REFL-V1.0
	RO-X-OSINAC-4-CR2-CHKOUT-INFLDSTR-V1.0
	RO-X-OSINAC-4-CR2-CHKOUT-REFLECT-V2.0
	RO-X-OSINAC-4-CR2-CHKOUT-STR-REFL-V2.0
	RO-X-OSINAC-4-CR2-CHKOUT-STRLIGHT-V2.0
	RO-X-OSIWAC-2-CR2-CHECKOUT-V3.0
	RO-X-OSIWAC-3-CR2-CHECKOUT-V3.0
	RO-X-OSIWAC-4-CR2-CHECKOUT-V2.0
	RO-X-OSIWAC-4-CR2-CHKOUT-INF-REFL-V1.0
	RO-X-OSIWAC-4-CR2-CHKOUT-INFLDSTR-V1.0
	RO-X-OSIWAC-4-CR2-CHKOUT-REFLECT-V2.0
	RO-X-OSIWAC-4-CR2-CHKOUT-STR-REFL-V2.0
	RO-X-OSIWAC-4-CR2-CHKOUT-STRLIGHT-V2.0


===============================================

VOLUME_ID
--> GEOSPICE VOLUME_ID values appear to be temporary values.  Please provide valid values that do not conflict with other data sets.  Note that this keyword is found in the BROWSE/, DATA/, INDEX/, and in VOLDESC.CAT.

file: 'AAREADME.TXT'
--> Talks about a file that does not exist: "DOCUMENT/OSIRIS_SSR/OSIRIS_SSR_V01.PDF".  Should this be: "DOCUMENT/OSIRIS_SSR/KELLER_ET_AL_2007_V01.PDF"

directory: 'BROWSE'
--> Many/most of the JPG files cannot open on a windows or mac machine.  I cannot track down why.
--> Perhaps not an error, but the vast majority of CR2 images are all black.

file: 'CATALOG/DATASET.CAT'
--> Throughout this file, you refer to SCIENCE_USER_GUIDE_V08.PDF or SCIENCE_USER_GUIDE_V07.PDF (note the version number).  But the DOCUMENT directory only contains V07.  Please correct.
--> --> Problem in at least the ABSTRACT_DESC and DATA_SET_DESC:"Change Log".
--> ABSTRACT_DESC: GEO and GEOSPICE has some missing text: "data set contains that include".  Used to be "data set contains derived data products that include".  Please fix.
--> ABSTACT_DESC:  Instead of pointing to a document to reference exactly what was updated, should briefly give the big update(s) for that particular processing level.  This shouldn't really be more than a sentence.  
--> CITATION_DESC:  year needs to be updated from 2020 to 2022.

file: 'CATALOG/REFERENCE.CAT'
--> There is a more recent version of this file that should be used (2020-12-09 w/ GEIGERETAL2020 added)

directory: 'DOCUMENT/'
--> PDF files claims to be PDF/A-1A, but fails verification.
--> --> DOCUMENT/CALIB/ADC_CORRECTION_V02.PDF
--> --> DOCUMENT/CALIB/BAD_PIXELS_V05.PDF
--> --> DOCUMENT/CALIB/BIAS_V03.PDF
--> --> DOCUMENT/CALIB/BORESIGHT_V01.PDF
--> --> DOCUMENT/CALIB/EXPOSURETIME_COR_V05.PDF
--> --> DOCUMENT/CALIB/FILTER_CURVES_V02.PDF
--> --> DOCUMENT/CALIB/FLATFIELDING_V02.PDF
--> --> DOCUMENT/CALIB/GEOMETRIC_DIST_COR_V04.PDF
--> --> DOCUMENT/CALIB/GEO_PRODUCTS_V03.PDF 
--> --> DOCUMENT/CALIB/INFIELD_STRLIGHT_V03.PDF
--> --> DOCUMENT/CALIB/LINEARITY_SATUR_V02.PDF
--> --> DOCUMENT/CALIB/OSIRIS_CAL_PIPELINE_V10.PDF
--> --> DOCUMENT/CALIB/RADIOMETRIC_CALIB_V03.PDF
--> --> DOCUMENT/EAICD/OSIRIS_EAICD_V08.PDF
--> --> DOCUMENT/SCIENCE_USER_GUIDE/SCIENCE_USER_GUIDE_V07.PDF
--> --> DOCUMENT/SIS/OSIRIS_SIS_V08.PDF
--> PDF files claims to be PDF/A-1B but fails verification.
--> --> DOCUMENT/OSIRIS_SSR/KELLER_ET_AL_2007_V01.PDF
--> I can fix the PDF files, but then for those signed documents, they will be labeled as modified from the signed state, and there are subtle differences.