DART Shape Model Liens ====================== Documentation ============= --> Need to include pointers (s) to the documentation collection in the data collection. --> Document collection label should only reference targets if there are documents about the target. file: dart_coordinate_system_for_didymos_and_dimorphos_v1.pdf --> File is incorrect, the PDF/A version must be corrected. --> Incorrect PDF/A type as reported by validate tool otherwise OK --> Given that no other document is versioned in the collections, maybe drop "v1" from the name. --> Remove instances (2) noting that the positive pole will informally be referred to as North. --> Shape and COF of Dimorphos: Might be useful to include a caveat that the information will depend on the coverage from DRACO and LICIAcube and may be incomplete. --> Typo: "Such data allows resolving surface features on of ~10 m on Didymos and ~2 m (but not all objects of this scale)." Numerous problems... --> Typo: "... structures to which the location of prime meridian can be defined relative to." -> "... structures relative to which the location of the prime meridian can be defined." file: dart_shapemodel_sis.pdf --> SPICE Kernels are mentioned as if they were present in the archive but they are not. --> Pages 4 and 5: Three instances of the following error: "Error! Bookmark not defined." --> Page 7: The following text: "These data products are PDS4 compliant ASCII or binary FITS files and ASCII text (OBJ) files with associated header information. Page 7: Appendix Error! Reference source not found." --> Should also mention text and binary SPICE Kernels as indicated later in the described data products where we can read: SPICE PCK, SPK, and CK kernels. Please note that DSK kernels could also be considered. --> Page 8: Missing reference in the last line of the page: "Appendix Error! Reference source not found." --> Page 39: Missing reference at the bottom of the page: "Error! Reference source not found." --> Page 20: The following text is present: "All planes values are described in Section 5.2.1.4." But such section does not exist, it should be Section 5.2.2. --> Update Daly et al reference if possible (published?) --> Page 10-11: Talk about providing average tilt information and relative tilt information. But these sound like they are dependent on what the user wants for the average. Is this actually being provided, or is it simply defining how the user would compute it from what is provided (normals and radial vectors). --> Table 3 title: "Alimetry"? --> Page 13: Naming convention list has two underscores in a row (between "mm" and SDP area) --> Tables 4 and 5: Value column says "example values in parentheses", but there are some that are obviously examples that are not in parens. Coordinates given to 13 decimal places?? --> Table 5 • Secondary header: • Axis descriptions don't match what's in the data files • Formats are given as "E16.0" which is not valid. • The XML headers in the data set list a data type of IEEE754MSBSingle which is single precision. --> Page 34: Definition of the shape model coordinates. "the +z axis along the direction of the smallest moment of inertia nearest the right-handed rotation axis". Presumably this is not in conflict with the rotational frame, but is accounting for wobble or libration? --> Sec 5.2.6. BODY920065803_POLE_RA says "and first order and second order time dependence of declination". Presumably this should be "Right Ascension" Page 7 typos: "The effects of Dimorphos pull on Didymos " -> "The effects of Dimorphos' pull on Didymos " "entire surface of either Dimorphos and Didymos" -> "entire surface of either Dimorphos or Didymos" "distance of a few 15 cm or better." -> distance of 15 cm or better." Page 9 typos: "surfaces of Dimorphos and Didymos are taken to slowly create" -> remove "slowly" "the tilts of a piece of asteroid surface imagined at multiple emission" -> "imaged at" Page 10 typos: "With surface terrain models in hand, it is now possible to compute" -> "With surface terrain models in hand, it is possible to compute" --> In example of starting lines on page 34 "The x, y, and z components of the vertices precede the letter 'v' ..." -> the components in the data table follow the letter 'v' Data ==== --> All FITS and OBJ labels mention an UNKNOWN shape model. The shape model is known and included in the bundle the label. Fields affected are: Identification_Area/title, File_Area_Observational/File/comment --> The header of the global image cube is missing (or the documentation is wrong): HDRVERS (The version number of this FITS header) --> The header has an incorrect value for the target keyword (or the documentation is wrong): TARGET = 'DIMORPHOS' instead of '920065803 Dimorphos’ --> There is a plane (ALBEDO) missing in the global image cube, that is present as an ancillary FITS file: g_08440mm_spc_alb_dimo_0000n00000_v002.fits --> SIGMA values for most of binary tables are "nan". A value compliant with the format specified by the label: IEEE 754 MSB single precision floating point, could be used e.g.: -999 --> SPICE kernels for shape models (DSKs) are missing in the collection. This is perfectly OK, and in fact is somehow documented in dart_shapemodel_sis.pdf There are two different approaches: 1. Include the relevant SPICE Kernels for full exploitation of the shape model in the collection. The SPICE Kernels would be duplicated then in the SPICE Kernel Bundle. 2. Do not include the SPICE Kernels in the collection --> In addition, there should be a PCK for the Didymos system, a SPK for both bodies, and maybe a CK for each body (in the case the rotation cannot be modeled by the PCK subsystem). These files are necessary to understand the rotation model and they should be referenced by this collections if they are not included. --> IDL FITS reader is not properly reading the tables. This should be investigated. --> Format statements in FITS extension headers are invalid. Are SIS values correct? Contradictions between FITS (SIS document) and XML header formats? --> The collection descriptions (i.e. abstracts) are vague but probably fine for the document collection. For the data collection, recommend including the target names and expanding out "DART" as was done for LICIACube. file: g_08440mm_spc_dtm_dimo_0000n00000_v002.fits --> Missing XML label files: g_08440mm_spc_nvf_dimo_0000n00000_v002.xml l_08575mm_spc_nvf_dimo_1325s10722_v002.xml g_08440mm_spc_grv_dimo_0000n00000_v002.xml l_08575mm_spc_grv_dimo_1325s10722_v002.xml --> 6 does not match actual number of fields (10). file: l_08575mm_spc_obj_dimo_1325s10722_v002.fits --> Wrong offset in a table entry. file: l_08575mm_spc_dtm_dimo_1325s10722_v002.fits --> Image cube FITS missing for the local model. file: overview.txt --> Typos in the abstract. geiod -> geoid. asteroid's -> asteroids' --> naming convention in Data Set Overview ahs two underscores in a row. --> Use spaces instead of tabs in table of data type identifiers to force proper alignment. --> Suggested corrections for typos and errors provided in overview_mcosta.txt. EN Review ========= *** shapemodel *** collection.xml - For lid_references to urn:nasa:pds:context:instrument:liciacube.leia urn:nasa:pds:context:instrument:liciacube.luke please provide those context products to EN if/when ready model01/l_08575mm_spc_obj_dimo_1325s10722_v002.xml - The header, as defined, overlaps the data table:
0 2916 [...]
VERTEX_TABLE 2909 I think the right solution is to change header/object_length 2909 [...] *** shapemodeldoc *** collection.xml - For lid_references to urn:nasa:pds:context:instrument:liciacube.leia urn:nasa:pds:context:instrument:liciacube.luke please provide those context products to EN if/when ready dart_coordinate_system_for_didymos_and_dimorphos_v1.pdf - This is PDF/A-2b, not -1a or -1b.