LICIACube Liens =============== Documentation ============= --> Documentation needs Della Corte et al 2022 paper when it is ready. Inconsistencies in calibrated units --> SIS page 12 says they are "represented in radiance (W m-2 nm-1 sr-1)." --> SIS Figure 3 lists units as "W/SR/nm/s." --> overview.txt for LEIA and LUKE calibrated data: "All observations are calibrated data reported in units of [W*s]/[m^2*sr]." --> In calibrated data XML for LEIA and LUKE, for X0-X3 should be W*m**-2*sr**-1 for all. What about nm? file: lcc_leia_luke_sis_v2.pdf --> Add page numbers to each page. --> Consider adding a table of acronyms. --> Page 5 mentions the LICIACube Calibration Pipeline Description. Is this document available? --> FOV should be defined as 2.9 deg along the horizontal and vertical axis rather than 2.06 deg along the diagonal. --> Table 4: Add Luke to table title and define PL. --> Page 8: The sentence that begins "An AR coating will be included..." seems like it is leftover from a pre-construction document. Presumably it is known whether or not the anti-reflective coating is included now. And AR needs to be defined. --> Table 5: Add Luke to the table title. --> Table 5: Number of pixels should be 2048 x 1088 (not 2088). --> FITS capitalization throughout document should be consistent. --> Page 12, 14: In "Plane 0: bias for corresponding (I,j) pixel in DN" the "I" should be lower case. --> Page 13: The line "Errore. L'origine riferimento non è stata trovata" appears in the first paragraph of section 4.4.2.2. Is this a bad Latex reference? --> Page 14: Sentence beginning "At the present time the filter used..." is leftover from pre-construction. --> Page 26, section 4.5.1: What is AD3? --> Table 9 and 12, dart:window_y_end: X in second column should be Y. --> Table 9, dart:readout_time: Include units is description column. --> Page 8: Explain the algorithm used to save the "best bits" when LUKE's 10-bit per pixel images are truncated to 8-bit. --> Page 9: will there be error/bias introduced when the 10 or 12 bit data are constituted as 16 bit? It would be helpful to explain how this is accomplished. --> Page 13: "The MCC reconstructs 8-bit images from the raw telemetry by performing the cut of the signal to the 8 chosen bit per pixel per channel (i.e., most or least significant ones), in order to select the best part of the acquired histogram for LUKE". How does this affect uncertainties/interpretation of the data? --> Page 9: Add a reference to a document that explains what a bayer filter is and a sentence describing it. --> Explain how the color values use the calibration coefficients. Are the same coefficients used for each of R, G, B? Are the three colors combined or treated independently? --> Table 2, 4: F/N should be given as f/ratio or f/stop. --> Table 2: Resolution says "Diffraction limit". Give explicit number? --> Page 7: What does obscuration refer to? Is the overall transmission of "92% if obscuration is not considered" the same as #10 in Table 2 (Relative illumination >90%)? Isn’t the overall transmission the thing that is important? --> Clarify explanation for 250 ms delay for CORT_UTC and CORTJDAT. Explain what tCUC means, as it is not a FITS keyword. --> Describe mission phases. --> In session 4.1. Provide more info in the overview of the DART and LICIACube mission with some key details when producing the real dataset. Such as mission key phase and dates, observation sequence --> Describe the measured distortion for both cameras. --> Explain the mission phases used in metadata, e.g. what's TERMINAL and FINAL? --> Add description to "DATE", make it clear it's the time of file production. file: liciacube/readme.txt --> Document labels need context objects for DART mission, the LICIACube mission, S/C, instruments, calibrations, observation phases, and those context objects will have pointers to individuals documents in the document collection for the mission. --> 4.4.2.2 a quote Error --> In the real data package, add more stats of the data in each collection, e.g. numbers of images, time range of phases, and a complete reference list that sufficiently explains the mission, instrument and calibration... file: collection.xml --> Collection descriptions are vague. It would be nice to include some more detail of what was/will-be observed and perhaps even when. --> The collection descriptions (i.e. abstracts) say they are part of the LICIACube mission, but the Investigation_Area says it is DART. The description should probably at least mention DART, but should there be an investigation area for LUCIACube? Data ==== --> Many keyword explanations are truncated in FITS headers and not all are given in XML labels. SIS PDF (p. 18) says "Metadata descriptions may be abbreviated in the FITS header, with full description in the label." They should be described in the SIS, not the XML label. --> Included in XML but not SIS PDF: dart.test_pattern -> comparable FITS keyword is ‘HIERARCH TESTPTTRN’ Also, this keyword probably has a typo in the FITS file? --> CORT_UTC and CORTJDAT don't agree because this is fake data. Make sure they do match with real data. --> Add middle "T" to data format. --> What is Application ID (APID)? [please expand definition in SIS PDF] --> Missing Class.Attribute Name? SIS PDF (p. 20 and 28) lists dart.correct_image_time (CORT_UTC in FITS header), but it isn’t in the XML. --> Explicitly define "primary target" and "secondary target." --> Labels should use Imaging dictionary classes and attributes to describe the debayering process. --> in FITS header, add description that IMG_UTC is start time. --> In XML of SIS.pdf, typo: cubseat --> LUKE calib collection is called "derived" instead of "calibrated" in the description and title. Which is correct? LEIA is as expected. EN Review ========= *** document *** collection.xml - For lid_references to urn:nasa:pds:context:instrument:liciacube.leia urn:nasa:pds:context:instrument:liciacube.luke please provide those context products to EN if/when ready *** leia_calibrated *** collection.xml - For lid_references to urn:nasa:pds:context:instrument:liciacube.leia please provide those context products to EN if/when ready *** leia_raw *** collection.xml - For lid_references to urn:nasa:pds:context:instrument:liciacube.leia please provide those context products to EN if/when ready *** luke_calibrated *** collection.xml - For lid_references to urn:nasa:pds:context:instrument:liciacube.luke please provide those context products to EN if/when ready - The following LID is unknown - is this lid_reference correct: urn:nasa:pds:liciacube:luke_derived:luke_calibrated_overview The leia_calibrated file had a lid_reference to urn:nasa:pds:liciacube:leia_calibrated:leia_calibrated_overview If this is what's intended, please ensure that file exists someday. *** luke_raw *** collection.xml - For lid_references to urn:nasa:pds:context:instrument:liciacube.luke please provide those context products to EN if/when ready