General Comments for the DART DRACO collections for the 2022 June 13 Peer review by SBN: T.Barnes urn:nasa:pds:dart:data_dracocal::1.0 urn:nasa:pds:dart:data_dracoddp::1.0 urn:nasa:pds:dart:data_dracoraw::1.0 urn:nasa:pds:dart:document_draco::1.0 Note: I did not include issues fully identified in the pre review liens by B. Hircsh. ------------------------------------------------------------------------------ Issue #1: Change in collection LID from prior review. ------------------------------------------------------------------------------ Why has the collection LIDs changed? What should they be? July 2021 -> June 2022 urn:nasa:pds:dart:dracoraw -> urn:nasa:pds:dart:data_dracoraw urn:nasa:pds:dart:dracoddp -> urn:nasa:pds:dart:data_dracoddp urn:nasa:pds:dart:dracocal -> urn:nasa:pds:dart:data_dracocal urn:nasa:pds:dart:dart_doc -> urn:nasa:pds:dart:document_draco Will there be a document collection for just DART, not just DART-DRACO? I ask since with this change in LID, there does not appear to be a collection to house any mission wide documents. Previously these draco docs were found in the general dart document collection. ------------------------------------------------------------------------------ Issue #2: Collection Names ------------------------------------------------------------------------------ For the collection names ( ), DRACO is mentioned three times, twice as an acronym and once spelled out. This is very redundant. Please consider rethinking how to name these collections. Example: <title>Draco Calibrated Data Collection for the Didymos Reconnaissance and Asteroid Camera for OpNav (DRACO) instrument Suggested rename for the above example: * Didymos Reconnaissance and Asteroid Camera for OpNav (DRACO) Calibrated Data * Calibrated Data Collection for the Didymos Reconnaissance and Asteroid Camera for OpNav (DRACO) instrument As a side not, there is no mention of mission acronym or name in collection name. This may be fine. But if you wanted to add it, I would suggest adding it just before "Didymos ..." in the examples above, as "DART Didymos ...". These 's are important because we use them for citation information in the DOIs (which will be sent to the ADS) and on webpages for the collections. They will also be important later for once PDS search services are avaiable. ------------------------------------------------------------------------------ Issue #3: Abstract Information ------------------------------------------------------------------------------ The collections have some very terse <description> information in the <Citation_Information> class for their collection products. I would recommend adding mention of the DART mission at least. Remember that this information will be ingested as if it were an abstract for this publication. This is used for DOI generation and will be one field used in searches (ADS and PDS search services). Please add a little bit more description for this high level product, but continue to be brief. ------------------------------------------------------------------------------ Issue #4: Calibration files found in data collection ------------------------------------------------------------------------------ May want to consider moving the calibration files found in 'data_dracocal/calibration/' to its own collection (ex: calibration_draco). ------------------------------------------------------------------------------ Issue #5: Imaging Dictionary referenced but never used. ------------------------------------------------------------------------------ Imaging dictionary is referenced in many data files, but is never used. Are the files missing this class or was this included in error? Example line: xmlns:img="http://pds.nasa.gov/pds4/img/v1" Please remove these entries if they are not being used, otherwise please add the class to the labels. ------------------------------------------------------------------------------ Issue #6: Author Lists ------------------------------------------------------------------------------ Sanity check: In the previous peer review R. Espiritu was listed as an editor, not an author. Please ensure that all those listed as authors are really authors and not editors. This information gets feed into the DOI and we should ensure correct credit is where it should be. Typo: There are many instances where the <author_list> does not have a space after a semi-colon. Please add it to be consistant. Example from bundle*.xml file, noting the missing space between the first two authors: <author_list>Ernst, C.;Daly, T.; Barnouin, O.; Espiritu, R.</author_list> If you have any questions, SBN personnell should be able to clarify, but ultimately it is the decision of the data providers. ------------------------------------------------------------------------------ Issue #7: Invalid collection product filenames? ------------------------------------------------------------------------------ I believe the three data collections have their collection.xml and inventory files with illegal file names. The expected format is "collection[_*].xml" and for the inventory file, "collection[_*].csv" or sometimes "collection[_*]_inventory.csv". "collection[_*].xml" is a reserved filename. Here are the current values: data_dracocal/data_dracocal_collection.csv data_dracocal/data_dracocal_collection.xml data_dracoddp/data_dracoddp_collection.csv data_dracoddp/data_dracoddp_collection.xml data_dracoraw/data_dracoraw_collection.csv data_dracoraw/data_dracoraw_collection.xml document_draco/collection_document_draco.csv document_draco/collection_document_draco.xml Please note that for the peer review posting, the collection and bundle xml files were renamed to {collection,bundle}.xml, and the inventory files were left unchanged. ------------------------------------------------------------------------------ Issue #8: Duplicate LIDVID found ------------------------------------------------------------------------------ The LIDVID urn:nasa:pds:dart:data_dracoddp:dart_0717892213_00957_01_geo::1.0 is being used in the following files: * data_dracoddp/dart_0717892213_00957_01_geo.xml) * data_dracoddp/final/2022/274/dart_0717892213_00957_01_geo.xml LIDs must be unique. Please fix.