PDS/SBN New Horizons K4 GOEPHYS data set peer review liens =============================================== NOTE: (1) The GEOPHYS data set went to peer review again in Oct 2022. All reviewer presentations and notes can be found here: https://sbnreview.astro.umd.edu/202210_NH_KEM/notes-presentations/ OR linked into the agenda here: https://sbnreview.astro.umd.edu/202210_NH_KEM/agenda.shtml =============================================== Datasets Validated: NH-A-LORRI/MVIC-5-GEOPHYS-V1.0 =============================================== Errors unique to: NH-A-LORRI/MVIC-5-GEOPHYS-V1.0 Certification Status: CERTIFIED, with minor liens (per Oct 2022 peer review). Reviewers want to double check coordinate system doc again. Delta review required if team decides to edit shape models instead of document. Most recent Delivery Date: 2022-09-20 Note that during the Oct 2022 peer review that it the NH team wanted to get the data out, so would prefer to not touch the data bytes which would require yet another review. Those liens below can be taken as suggestions, but they are recorded below. file: 'catalog/dataset.cat' --> NEW 9/20: should the new paragraph on lines 28-30 about ARROKOTH_CSD.PDF have a blank line between it and the prior section? --> NEW 9/20: Please update the publication year from 2021 to 2022 in the CITATION_DESC. file: 'catalog/nh_kem.cat' --> RF (pepssi slide 5): The mission phases have been completed at this stage of the mission and in some places it is reported correctly, but in others it is not. --> --> line 148-161: There is an inconsistency with the paragraph on lines 160-161 and the text on line 153. Assuming that the mission phase name and times are now static, I recommend removing the paragraph on lines 160-161. --> --> line 169: We assume the mission phase end time for KEM 1 Encounter is known, so please replace the TBD. Assuming that the mission phase name and times are now static, I recommend removing the paragraph on lines 183-184. files: 'data/shape_models/*' --> BS (slide 4): Possible improvements for the DSK models (take as suggestions): --> --> (1) remake with different voxel scales to increase access speed (see detailed example in BS slide 5). Can be done using updated makedsk code. --> --> (2) Remake mu69_asp_ca04_06_icp_spice_v01.bds from rectangular coordinates to improve segment coverage boundaries (see details in BS slide 6) --> --> SBN-TB: Please note if files are remade they will need to be delta reviewed. --> LJ (slide 6): There are duplicate vertices in the Lobes lopoly model. Consider removing them. This may cause problems with some software. --> --> SBN-TB: It was discussed at the peer review that this was not a problem that would prevent archiving. If this is fixed, it would need to be delta reviewed. Please document this issue in the label if it remains unfixed. --> LJ (slide 6): The two Lobes (both hipoly and lowpoly) have TJunctions. --> --> SBN-TB: It was discussed at the peer review that this was not a problem that would prevent archiving. If this is fixed, it would need to be delta reviewed. Please document this issue in the label if it remains unfixed. files: 'data/albedo/*' --> (SBN-TB: NOTE this data was previously certified, but a new reviewer noted some things you may consider, but are not required to change.) --> LJ (slide 7): The Acquisition time is missing. This would be needed to georeference pixels. --> LJ (slide 7): Some values are out of physical range, especially near the edges. It would be useful to define a "nodata" value for these instead. --> --> SBN-TB: I recall a similar suggestion from the prior review. But it may require changing the data files, and so a delta review. --> LJ (slide 7): For reflectance: bidirectional reflectance (assumed) or I/F? It would be good to be clear in documentation. --> LJ (slide 7): Suggest producing PNG snapshot? file: 'index/index.{lbl,tab}' --> NEW 9/20: Column 2 length was fixed, but the FORMAT in the label needs to be updated from "A31" to "A34" to match the BYTES. --> NEW 9/20: It was not recognized due to old column 2 error, but column 4 also needs its length extended in both the file and label due to line 917 PRODUCT_ID length. Don't forget to adjust the RECORD_LENGTH, ROW_BYTES, column 4's FORMAT and BYTES, and the START_BYTE for all columns after column 4 as well. file: 'document/arrakoth_CSD.{lbl,pdf}' --> NEW 9/20: please force the filename to all lowercase --> NEW 9/20: The PDF file conforms to PDF/A-2B, but it must conform to PDF/A-1a or 1b. Please fix. --> BS (slide 4): Currently does not include complete set of rotation constants, missing W0. It should be updated to include the complete set of IAU style rotation constants, e.g. like found in the nh_stars_kbo_centaur_tpc4.txt file. --> --> SBN-TB: The needed information can be found in the spice kernels, it just needs to be in this document as well. I believe this includes W_0, the rotation rate, and epoch or J2000. There may be others. --> LJ: Two typos in Section 4, par 1 (pg 3): --> --> "imagining" => "imaging" --> --> "equitorial" => "equatorial" file: 'voldesc.cat' --> Note that PDS-SBN will need to update the PUBLICATION_DATE field for when the data sets are actually released to the public. --> --> 6/6 NH-Team: Understood --> --> 8/4 BLE: No change (PDS-SBN will handle)