Review comments for DART SC DRACO and RS data sets by SBN: T. Barnes =============================================== NOTE: (1) Delivery has been updated since original delivery date to reflect missing document file. (2) Going to Feb 2023 peer review. =============================================== Datasets Validated: urn:nasa:pds:dart:2.0 urn:nasa:pds:dart:data_dracoraw::2.0 urn:nasa:pds:dart:data_dracocal::2.0 urn:nasa:pds:dart:document_draco::2.0 urn:nasa:pds:dart:data_maf::1.0 urn:nasa:pds:dart:data_trk223::1.0 urn:nasa:pds:dart:data_trk234::1.0 urn:nasa:pds:dart:document_rs::1.0 =============================================== Errors for: all Missing context products: --> urn:nasa:pds:context:instrument:dart.hga --> urn:nasa:pds:context:asteroid.dimorphos file: 'bundle_dart_spacecraft.xml' --> line 17: should be updated to 2023 from 2022. file: 'data_dracocal/collection_data_dracocal.xml' --> line 12: should be "2.0" not "1.0" --> Please add Dimorphos as a target since it was the primary target. file: 'data_dracocal/*/*/*/*.xml' --> There are many examples of the value 513 being used for window2_y_start where the max value is defined as 512. --> --> Ex: data_dracocal/approach/2022/262/dart_0401325228_12877_01_rad.xml --> --> Ex: data_dracocal/cruise/2022/090/dart_0386444960_04314_02_rad.xml --> There are many examples of the value 1024 being used for window2_x_end where the max value is defined as 1023. --> --> Ex: data_dracocal/cruise/2022/090/dart_0386445111_12784_02_rad.xml --> There are many examples of the value 1025 being used for window2_y_end where the max value is defined as 1024. --> --> Ex: data_dracocal/cruise/2022/090/dart_0386444960_04314_02_rad.xml file: 'data_dracoraw/collection_data_dracoraw.xml' --> Please add Dimorphos as a target since it was the primary target. file: 'data_dracoraw/approach/2022/269/dart_0401865397_35385_01_raw.xml' (and similar other examples) ERROR [error.label.schema] line 93, 30: cvc-minLength-valid: Value '' with length = '0' is not facet-valid with respect to minLength '1' for type 'imaging_mode'. ERROR [error.label.schema] line 93, 30: cvc-type.3.1.3: The value '' of element 'dart:imaging_mode' is not valid. ERROR [error.label.schema] line 94, 22: cvc-minLength-valid: Value '' with length = '0' is not facet-valid with respect to minLength '1' for type 'gain'. ERROR [error.label.schema] line 94, 22: cvc-type.3.1.3: The value '' of element 'dart:gain' is not valid. ERROR [error.label.schema] line 99, 40: cvc-pattern-valid: Value '' is not facet-valid with respect to pattern '(\+|-)?([0-9]+(\.[0-9]*)?|\.[0-9]+)([Ee](\+|-)?[0-9]+)?|[^aFIN,]* ' for type 'exposure_time_WO_Units'. ERROR [error.label.schema] line 99, 40: cvc-complex-type.2.2: Element 'dart:exposure_time' must have no element [children], and the value must be valid. ERROR [error.label.schema] line 100, 25: cvc-minLength-valid: Value '' with length = '0' is not facet-valid with respect to minLength '1' for type 'binning'. ERROR [error.label.schema] line 100, 25: cvc-type.3.1.3: The value '' of element 'dart:binning' is not valid. ERROR [error.label.schema] line 101, 33: cvc-datatype-valid.1.2.1: '' is not a valid value for 'integer'. ERROR [error.label.schema] line 101, 33: cvc-type.3.1.3: The value '' of element 'dart:window2_x_start' is not valid. ERROR [error.label.schema] line 102, 33: cvc-datatype-valid.1.2.1: '' is not a valid value for 'integer'. ERROR [error.label.schema] line 102, 33: cvc-type.3.1.3: The value '' of element 'dart:window2_y_start' is not valid. ERROR [error.label.schema] line 105, 29: cvc-minLength-valid: Value '' with length = '0' is not facet-valid with respect to minLength '1' for type 'onboard_cal'. ERROR [error.label.schema] line 105, 29: cvc-type.3.1.3: The value '' of element 'dart:onboard_cal' is not valid. ERROR [error.label.schema] line 107, 42: cvc-minLength-valid: Value '' with length = '0' is not facet-valid with respect to minLength '1' for type 'badpix_invalidation_mode'. ERROR [error.label.schema] line 107, 42: cvc-type.3.1.3: The value '' of element 'dart:badpix_invalidation_mode' is not valid. ERROR [error.label.schema] line 108, 44: cvc-pattern-valid: Value '' is not facet-valid with respect to pattern '(\+|-)?([0-9]+(\.[0-9]*)?|\.[0-9]+)([Ee](\+|-)?[0-9]+)?|[^aFIN,]* ' for type 'detector1_temp_WO_Units'. ERROR [error.label.schema] line 108, 44: cvc-complex-type.2.2: Element 'dart:detector1_temp' must have no element [children], and the value must be valid. ERROR [error.label.schema] line 109, 44: cvc-pattern-valid: Value '' is not facet-valid with respect to pattern '(\+|-)?([0-9]+(\.[0-9]*)?|\.[0-9]+)([Ee](\+|-)?[0-9]+)?|[^aFIN,]* ' for type 'detector2_temp_WO_Units'. ERROR [error.label.schema] line 109, 44: cvc-complex-type.2.2: Element 'dart:detector2_temp' must have no element [children], and the value must be valid. ERROR [error.label.schema] line 110, 38: cvc-pattern-valid: Value '' is not facet-valid with respect to pattern '(\+|-)?([0-9]+(\.[0-9]*)?|\.[0-9]+)([Ee](\+|-)?[0-9]+)?|[^aFIN,]* ' for type 'fpe_temp_WO_Units'. ERROR [error.label.schema] line 110, 38: cvc-complex-type.2.2: Element 'dart:fpe_temp' must have no element [children], and the value must be valid. ERROR [error.label.schema] line 111, 47: cvc-pattern-valid: Value '' is not facet-valid with respect to pattern '(\+|-)?([0-9]+(\.[0-9]*)?|\.[0-9]+)([Ee](\+|-)?[0-9]+)?|[^aFIN,]* ' for type 'current_18vd_supply_WO_Units'. ERROR [error.label.schema] line 111, 47: cvc-complex-type.2.2: Element 'dart:current_18vd_supply' must have no element [children], and the value must be valid. ERROR [error.label.schema] line 112, 47: cvc-pattern-valid: Value '' is not facet-valid with respect to pattern '(\+|-)?([0-9]+(\.[0-9]*)?|\.[0-9]+)([Ee](\+|-)?[0-9]+)?|[^aFIN,]* ' for type 'current_33va_supply_WO_Units'. ERROR [error.label.schema] line 112, 47: cvc-complex-type.2.2: Element 'dart:current_33va_supply' must have no element [children], and the value must be valid. ERROR [error.label.schema] line 113, 47: cvc-pattern-valid: Value '' is not facet-valid with respect to pattern '(\+|-)?([0-9]+(\.[0-9]*)?|\.[0-9]+)([Ee](\+|-)?[0-9]+)?|[^aFIN,]* ' for type 'current_33vd_supply_WO_Units'. ERROR [error.label.schema] line 113, 47: cvc-complex-type.2.2: Element 'dart:current_33vd_supply' must have no element [children], and the value must be valid. ERROR [error.label.schema] line 114, 55: cvc-pattern-valid: Value '' is not facet-valid with respect to pattern '(\+|-)?([0-9]+(\.[0-9]*)?|\.[0-9]+)([Ee](\+|-)?[0-9]+)?|[^aFIN,]* ' for type 'current_analog_reset_supply_WO_Units'. ERROR [error.label.schema] line 114, 55: cvc-complex-type.2.2: Element 'dart:current_analog_reset_supply' must have no element [children], and the value must be valid. ERROR [error.label.schematron] line 107, 42: The attribute dart:DRACO_Instrument_Attributes/dart:badpix_invalidation_mode must be equal to one of the following values 'BYPASS', 'USE'. ERROR [error.label.schematron] line 100, 25: The attribute dart:DRACO_Instrument_Attributes/dart:binning must be equal to one of the following values 'OFF', 'ON'. ERROR [error.label.schematron] line 94, 22: The attribute dart:DRACO_Instrument_Attributes/dart:gain must be equal to one of the following values '10X', '1X', '2X', '30X'. ERROR [error.label.schematron] line 93, 30: The attribute dart:DRACO_Instrument_Attributes/dart:imaging_mode must be equal to one of the following values 'GLOBAL', 'ROLLING'. ERROR [error.label.schematron] line 105, 29: The attribute dart:DRACO_Instrument_Attributes/dart:onboard_cal must be equal to one of the following values 'OFF', 'ON'. file: 'document_draco/collection_document_draco.xml' --> Should Didymos be listed as a target? If so, shouldn't Dimorphos as well? file: 'document_rs/collection_document_rs.xml' --> line 11: The collection LID has the wrong bundle listed. Please change "dart_rs" to "dart". The dart_rs bundle does not exist and I think plans for it have been dropped. --> line 13: The collection matches that of the data_trk234 collection. Please update it to be for this collection. --> Should Didymos be listed as a target? If so, shouldn't Dimorphos as well?