LEISA Data Format Liens
=======================

Documentation
=============

file: 22668.07-LEISA-SIS-01 R0 C0_Amy.docx
--> Still seems to be somewhat a work in progress (some information labeled as TBD or TBR like estimated size of data files, Word track changes comments still included)

--> Section 2.2. Paragraph 4 says "L’Ralph/MVIC" instead of "L’Ralph/LEISA".

--> Some of the FITS header field names in Table 3-1 don’t seem to match what is actually used in the files- e.g. INSTRU should be INSTRUME (already noted in a comment), LRSTART should be STRTSCLK?

--> What do color-text entries in Table 3-1 like that for OBJECT or BORERA mean?

--> The instrument overview in section 2.1 is very useful but needs a lot more details, figures, etc. 

--> The CONOPS in the use of the scan mirror presented in the last paragraph of 2.1 needs further detailing. It is apparently autonomous. Understanding how it works will help future data users to understand possible data characteristics and nuances.

--> The flatfield that will be provided is not mentioned and needs describing. Is Gain linear? Will a single flatfield suffice or will a look up table be needed as well?

--> The cadence of dark measurements need describing. When will they be obtained?  Will darks be obtained only by slewing the mirror to deep space?

--> Calibration steps need more description.  
- For instance, in 2a which frames being discussed need to be clarified.
- The calibration file and use in step 6 need more description. A single file? Mirror-position dependent files are to be expected? How is the non-uniform spectral nature of the mirror accounted for? Given MVIC and LEISA use the mirror, either the gold coating affects MVIC or a non-gold coating affects the IR, even only out to 4microns. 
- Mirror temperature needs to be provided for removing effects of thermal emission. (or is the removed through dark measurements?)


Data
====

--> Minor Note: The target name in FITS headers is blank, but included in XML files

--> In either the science or housekeeping data, information on the actual (preferred) or predicted mirror position needs to be provided corresponding to each line in the image and preferably at much higher temporal resolution, so, again, future users can interpret nuances in the data. 

--> 

Labels
======
--> Names in <author_list> should be separated by semicolons, not commas.
--> If Citation_Information is the same across all basic observational products, it can probably be omitted and just appear the collection or bundle level.
--> Primary_Result_Summary should be expanded to include discipline, facets, wavelength range, and any other applicable attributes to aid search.
--> The local_identifier_reference in the Processing_Information class is pointing to the array object specifically rather than the file. Is this correct? If processing modifies values in the data header, then the reference should probably be to the whole file, and not just the bytes of the array.

file: lei_0719078053_02200_eng_01.xml
--> In disp:Display_Direction, horizontal_display_axis and vertical_display_axis have the same value, "atrack". In geom:Display_Direction, the values are Sample and Line, which aren't used in this file.

--> data_type is UnsignedMSB2, which corresponds to the data type represented in the FITS file rather than the type as stored. With BITXPIX=16 and BZERO=32768, data_type should be SignedMSB2, and the value_offset attribute should be added to Element_Array with a value of 32768.

file: lei_0719078053_02200_sci_01.xml
--> Using the latest version of the information model, a more compact form of Display_Settings is permitted that eliminates the need to repeat the class for each array object. Instead, you can include just one instance of the class and repeat the local_identifier_reference as needed, like so:

<disp:Display_Settings>
  <Local_Internal_Reference>
    <local_identifier_reference>image</local_identifier_reference>
	<local_identifier_reference>wavelength_map</local_identifier_reference>
	<local_identifier_reference>darks</local_identifier_reference>
	...
  </Local_Internal_Reference>
  <disp:Display_Direction>
    <disp:horizontal_display_axis>Sample</disp:horizontal_display_axis>
	<disp:horizontal_display_direction>Left to Right</disp:horizontal_display_direction>
	<disp:vertical_display_axis>Line</disp:vertical_display_axis>
	<disp:vertical_display_direction>Bottom to Top</disp:vertical_display_direction>
  </disp:Display_Direction>
</disp:Display_Settings>

(Note this is only acceptable if the settings in Display_Direction are consistent across all array objects.)
	

EN Review
=========

lucy.leisa/data_*/lei_acqtime_obsid_*.xml
- These files look like templates, not intended for review, e.g. the $'s in:
    <file_name>$filename.fit</...>
    <local_identifier>fits_image_file</...>
    <creation_date_time>$creationdatetime</...>
    <file_size unit="byte">$file_size</...>
    <records>$num_records</...>