L'LORRI Data Format Liens
=========================

Documentation
=============

file: 22668.07-LLORRI-SIS-01 R0 C0 draft 2021-08-02.docx
--> Page 12: Data products organization described in 3.1 is inconsistent with the actual directory structure. Calibration and geometry directories missing. Cruise1 mission phase is at the same level as data processing level. Suggest adding various cruise phases to the structure.

--> Pages 13-15: More detail about data format is need. What are the histogram, image header, image description data stored in raw fits extensions? What are data quality flags definitions?

--> Page 3: “a SNR” should be “an SNR”
--> Page 3: "I/F = 0:0014 148" should be "I/F = 0.00148”
--> Page 3: Therefore, the Lucy mission set the *182º* phase angle …?
--> Page 3: "I=F = 0:40" should be "I/F = 0.40”
--> Page 4: Fig. 1 missing
--> Page 5: Bullet 2 in Section 2.2 seems to be copied from bullet 1.  Needs to be updated
--> Page 5: First sentence in 2.3, something missing after "located”
--> Page 5: Section 2.3.1, reference to Table 2-3 should be Table 2-2
--> Page 7: many empty sections need to be completed
--> Page 9: Table 2-3 needs to be populated
--> Page 11: 2.4.2 is not completed

--> Many sections are incomplete.

--> Not obvious if any sections are missing.

--> Calibrated data appears to be in units of DNs, but SIS indicates they should be DN/s. Clarify the units and make consistent throughout.


Data
====

--> Consider adding thumbnails of all images in popular image format (e.g., jpg)
--> Error and quality arrays in the calibrated data are all 0 now – needs to be updated to more meaning values for a more complete review

--> Many geometric parameters are in the header/labels. Suggestions for additional parameters:
– Solar phase angle
– Celestial North clock angle
– Ecliptic North clock angle
– Sun clock angle
– Target positive pole clock angle
– Sub-observer latitude and longitude
– Sub-solar latitude and longitude

--> Some keywords (e.g., PA_ZINST and PA_SUN_Z) are undefined, shouldn't be keywords.

--> <processing_level> for these data should be "Partially Processed".


EN Review
=========

lucy.llorri/data_cruise1_calibrated/lor_0705960615_02254_00002_sci_01.xml 
- This lid_reference may be wrong
  urn:nasa:pds:lucy.llorri:data_cruise1_calibrated:lor_0705960615_02254_00002_eng
Should it match the provided label:
  urn:nasa:pds:lucy.llorri:data_cruise1_raw:lor_0705960615_02254_00002_eng

lucy.llorri/document/
- This looks unready. No pdf file, and the label has 
    <Document>
        <publication_date>$year</publication_date>
        <description>$description</description>
        ...
            <Document_File>
                <file_name>$filename.pdf</file_name>
                <document_standard_id>PDF/A</document_standard_id>
            </Document_File>