LTES Data Format Liens
======================

Documentation
=============

file: 22668.07-TTCAM-SIS-01 R0 C0 draft_JFB2.docx
--> There are some places where the descriptions will need to be improved when calibrated and geometry data becomes available.

--> On page 7, highlight that 6.5 mrad is the FWHM.
--> On page 7, Vicky has a comment about the data having a minimum of 4 locations across the asteroid. Perhaps clarify.

--> Section 2.3.1 is not very helpful as currently written.
--> Table 2-3 is missing where ENG data falls (or at least its not clear).
--> Table 2-5 must be TBR as there are no volume data shown.
--> The table on Page 25 is either a duplicate or one table is uncalibrated and the other is ENG. I can't tell.
--> P. 10/33 (page 6): "cal files" should be spelled "calibrated files".
--> Observation ID = ObsID is defined on P.12/33, whereas its first occurrence is on P.10/33
--> PPS is not clearly defined (Number of tic (PPS) pulses received.). Does PPS stand for Pulses Per Second?

--> Page 8, I find fig2-1 to be a bit confusing. Is the pointing uncertainty always 1/8 of the asteroid's diameter? Won't this vary with distance and size? Also- is the scan direction going to towards the left?
--> Figure 2-1 (LTES scan of a Trojan asteroid) illustrates the projected LTES instantaneous field of view (IFOV) and observation path on a schematic representation of an asteroid as a sphere. Given the irregular shapes of the asteroids, how can we be sure that the IFOV always intersects with the surface and does not include space, especially for observations of the non-illuminated side?
--> Are the conditions for a minimum of 4 observations at different times of day always met, regardless of the shape of the asteroid?
--> How 1/8 of the Trojan's diameter is defined on a body that has an irregular shape?


Labels/Data
===========

--> "Iterferogram" is misspelled in labels:description, but not in the ifgm axis_name labels.

--> Table 3-1 has a label for cmd_fc_echo and cmd_seq_echo but in the meta data “cmd” is replaced with “cal”

--> Table 3-1 index starts at 1 but the PDS4 Label has it starting at 0.

--> Only the engineering data is readable.


EN Review
=========

lucy.ltes/data_cruise1_calibrated/tes_0719078834_00000_sci_01.xml
- xsi:schemaLocation is missing the definition of DISP, and LUCY's URL
looks like the developer's local copy. Maybe replace the last line with
  http://pds.nasa.gov/pds4/disp/v1 https://pds.nasa.gov/pds4/disp/v1/PDS4_DISP_1I00_1510.xsd
  http://pds.nasa.gov/pds4/mission/lucy/v1 https://pds.nasa.gov/pds4/mission/lucy/v1/PDS4_LUCY_1I00_1000.xsd
- Many elements are blank but can't be, e.g. type, lid_reference,
lucy:mission_segment, ...
- Many other syntax errors
- This label had many data_to_raw_product lid_references, e.g.
  urn:nasa:pds:lucy.ltes:data_cruise1_raw:tes_0719077727_02063_eng
The format slightly mismatches the LIDs in data_cruise1_raw, e.g.
  urn:nasa:pds:lucy.ltes:data_cruise1_raw:tes_0719077727_02063_eng_01

lucy.ltes/data_cruise1_calibrated/lte_0874281421_sci_1.xml
- This file looks like a template, not intended for review, e.g. the $'s in:
		<File>
			<file_name>$filename.hdf</file_name>
			<local_identifier>data</local_identifier>
			<creation_date_time>$creationdatetime</creation_date_time>
			<file_size unit="byte">$file_size</file_size>
			<records>$num_records</records>
		</File>

lucy.ltes/document/ltes_document.xml
- This looks unready. No pdf file, and the label has 
    <Document>
        <publication_date>$year</publication_date>
        <description>$description</description>
        ...
            <Document_File>
                <file_name>$filename.pdf</file_name>
                <document_standard_id>PDF/A</document_standard_id>
            </Document_File>