TTCAM Data Format Liens
=======================

Documentation
=============

file: 22668.07-TTCAM-SIS-01 R0 C0 draft_JFB2.docx
--> Section 2.3.2.2.1 - Bad pixel correction. Section header implies that the bad pixels will be changed in some way, but it sounds like they are only being flagged in the bad pixel image. If they are not being corrected, the section header should be re-worded. If corrections are being applied, they need to be described.

--> Page 12: Hierarchical description of Product_Observational is not consistent with the actual xml (same as for MVIC sample data):
In xml but not in description: Citation_Information, Reference_List
In description but not in xml: File_Area_Supplemental
In both but using different names (?): Discipline_Dictionaries vs. Discipline_Area

--> Page 15: Data bundle structure described here is inconsistent with the actual directory structure. data_hkraw and data_hkcalibrated missing. Subdirectories should be created in data_raw/ and data_calibrated/.
Should SIS include description of those files, as well as calibration data?

--> The PDS4 .xml label is missing for this document.
--> Page 6: "Primary Terminal Tracking Images are ....  Other images may be ...", what are primary terminal tracking images and what are other images?
--> Page 6: From Section 2.2, the units of calibrated data are either radiance or I/F.  How does the pipeline decide which unit to use?
--> Page 6: Section 2.3 says that the size of calibrated image is ~3x that of raw.  Is this correct, given raw is 8-bit, and calibrated has one 16-bit image and four 8-bit image extensions?
--> Page 8: Usage of the word "companding" is not precise.  12-bit to 8-bit is compressing, 8-bit back to 12-bit is expanding, and the whole process is called companding.  It's confusing to say companding and de-companding.
--> Page 9, section 2.3.2.2.1: extrta should be extra
--> Page 9 - 10, section 2.3.2.2: All subsections cite Bell et al. (2021).  Can be cited once in the overview part.
--> Page 10: Do you need to provide different radiance conversion factors for targets of different colors like for L'LORRI images, given the wide bandpass?
--> Page 13: Naming convention uses ttc, but sample image is tt2


Data
====

--> Bad pixel map has values of 0 and 4.  What does 4 mean?  Distribution seems to correlate with signal level?

--> Many geometric parameters are in the header/labels. Suggestions for additional parameters:
– Solar phase angle
– Celestial North clock angle
– Ecliptic North clock angle
– Sun clock angle
– Target positive pole clock angle
– Sub-observer latitude and longitude
– Sub-solar latitude and longitude

--> Some keywords (e.g., PA_ZINST and PA_SUN_Z) are undefined, shouldn't be keywords.

file: data_calibrated/tt2_0719081654_51205_sci_01.*
--> Radiance units are given as µW/cm2/sr in XML label and FITS header. Missing "/nm".


EN Review
=========

lucy.ttcam/.../*xml
- These URLs in the prolog and root tag are off:
  https://pds.nasa.gov/pds4/mss/v1/PDS4_MSSS_CAM_1I00_1030.sch
  https://pds.nasa.gov/pds4/mss/v1/PDS4_MSSS_CAM_1I00_1030.xsd
should be
  https://pds.nasa.gov/pds4/mss/v1/PDS4_MSSS_CAM_MH_1I00_1030.sch
  https://pds.nasa.gov/pds4/mss/v1/PDS4_MSSS_CAM_MH_1I00_1030.xsd

lucy.ttcam/data_calibrated/tt2_0719081654_51205_sci_01.xml
- No LID provided matches this lid_reference:
  urn:nasa:pds:lucy.ttcam:data_raw:tt2_0719081654_51205_eng_01.fit
That may be fine, but the provided raw file's LID had a different format
  urn:nasa:pds:lucy.ttcam:data_ega1_raw:tt2_0719081654_51205_eng