Comments provided by SBN: Tilden Barnes for 2023 May 31 Lucy peer review. =============================================== NOTE: (1) Understanding these are minimal labels and effort to get this data into the archive, I have limited my comments. There are many other things that would be best to add, but I hope/believe they are not required at this time. =============================================== Datasets Validated: urn:nasa:pds:lucy.llorri:data_didymos =============================================== Errors for: urn:nasa:pds:lucy.llorri:data_didymos It is my understanding that these data will later be re-delivered having run thru the lucy archive pipeline. Has any thought been taken how the current data products will be superseded? Are they in the same collection? Highly recommend not using the PDS4_MSN_1I00_1300 dictionary. The keywords are generic and the contents can not be validated against the unique values your (or any) mission may have. Will a version (PDS4_LUCY_1I00_1000) of the LUCY dictionary be available, compatible, and finalized to be published before release of this data? We should have the first version of all lucy related context objects posted before public release of the data. The ones needed for this collection is: --> urn:nasa:pds:context:investigation:mission.lucy --> urn:nasa:pds:context:instrument_host:spacecraft.lucy --> urn:nasa:pds:context:instrument:lucy.llorri file: ../bundle.xml --> file missing. Needs to be produced. Is there anything the team wants for this since it will be the first archived version of this. We need to sort out citation related information. Sanity check: Please confirm if the data products are "Raw" or "Partially Processed" or "Calibrated". See https://pds.nasa.gov/datastandards/documents/dd/common/current/#ch05s608.html#N-502758666 for definitions. --> If changed need, please remember to update the collection.xml and 'uncalibrated/' data file text where ever "[Rr]aw" or "[Cc]alibrated" is mentioned. file: 'collection.xml' --> A DOI should be produced and added to the . SBN can help with this. --> typo in : "instrumnet" => "instrument" --> Since this data set claims to have raw data, should add to the another instance of to be added to the "Calibrated" instance. files: 'data/.../*.xml' --> In the , please make the values unique. Currently they are the same for all products of a similar type or processing level. Adding the unique LID part should be sufficient. --> The <Target_Identification><name> is listed as "65803". I believe this should be expanded to say "(65803) Didymos". Alternatively could this have a <type> of "Planetary System" to recognize it is the the Didymos system? --> I see that the first item for the SPICE kernels is a meta kernel, but it is not available at NAIF yet from what I can see. Is that why both the meta kernel and the long list of kernels are included? --> --> Question for PDS: Is there a way we can have meta kernels available prior to peer review so they are available for the peer review and for public release of the data sets (which may happen immediately after the review)? --> For every data label, I see that the <geom:celestial_north_clock_angle unit="deg" xsi:nil="true" nilReason="unknown" />. Why is the nilReason "unknown"? Can't this be calculated? --> Please do not use the msn ldd. I see that you are using it for the <msn:mission_phase_name>. I recommend adding this to the lucy ldd where you can spell out your unique mission phase names. --> For the uncalibrated products only, the <Reference_List> has a carriage return in the <lid_reference> value. Please remove it. --> I believe that the intention of the current <Reference_List><Internal_Reference> is to make a connection between the uncalibrated and calibrated products. I strongly suggest you consider using the small bodies ldd to make this connection. --> typo line 8 of uncalibrated products: "https://pds.nasa.gov/pds4/img/v1/PDS4_DISP_1I00_1510.sch" => "https://pds.nasa.gov/pds4/disp/v1/PDS4_DISP_1I00_1510.sch" Note the "/img/" vs "/disp/". --> For the calibrated products, is it true that the primary image has a units of "DN/s"? Does this mean they are not actually fully calibrated but only partially processed? --> For the calibrated products, is there a definition for the values in the LLORRI Quality Flag Image object? --> For the calibrated products, there are no image Display Settings in the label for the error and quality 2d arrays, only for the image 2d array. file: 'LLORRI_Users_Guide.xml' --> <doi> is empty. If it is to be present it needs to have a DOI created and this field populated, otherwise remove the field. Do we really want a DOI for this document?