DART Shapemodel Liens ===================== Documentation ============= --> readme.txt is missing --> Document collection is not in the bundle xml XML Labels ========== file: collection_data_derived_didymos_model_v003.xml --> records mismatch --> inventory file has 4 files that have truncated filenames (lids) file: *spc_grv*.xml --> is 6 but there are 10 fields file: *spc_obj*.xml --> bad file read error OBJ files --> The header described in the SIS (5.2.2) does not match the files. --> The xml of all files is identical. --> Resolution in description does not match the file --> Dimorphos is used for all Didymos shape models file: dimorphos_impact_point_model_v004.txt --> REFERENCE_SHAPE = dimorphos_g_1960mm_spc_obj_0000n00000_v004.obj – File does not exist. Should this be dimorphos_g_1940mm_spc_obj_0000n00000_v004.obj ? file: dart_shapemodel_sis.pdf --> LIEN from 2022 review - dart_coordinate_system_for_didymos_and_dimorphos_v1.pdf is incorrect, the PDF/A version must be corrected. This document no longer exists but is referenced in sections 4.3.7 & 5.2.4. --> 4.3.4 Wording makes it sound like the SPICE-kernel products are in this archive. Please make the wording clearer to emphasize these products are in the DART SPICE archive at the NAIF Node. --> 4.3.5 states this archive conforms to PDS 1.7 IM - BUT 1.4 is used in the labels --> 5.2.5 talks about SPICE PCK kernels and mentions 'BODY920065803_NUT_*' terms which are not included in the DART 'didymos_system' PCK. This should be removed if they are not planning on being added to the PCK file --> 5.2.5 section states 920065803 is assigned for Dimorphos which is incorrect This ID is assigned for Didymos. From the NAIF IDs - 920065803 'DIDYMOS' 120065803 'DIMORPHOS’ --> 5.2.7 says spacecraft pointing and trajectory will be provided as SPICE kernels - please make it clear they are located at NAIF in the DART SPICE archive and not within this archive --> 7.1 The SPICE definition should be changed to ‘NASA's observation geometry information system developed and maintained by NAIF. SPICE acronym comes from Spacecraft ephemeris (SPK), Planetary constants (PCK), Instrument (IK), Camera-matrix (CK), and Events (EK).’ --> [Page 14] When elaborating the dtm folder, it only says: dtm - contains the digital terrain models as FITS FTM files. However, the dtm folder also includes slp files which are FITS binary table files. The descriptions on each folder should be revised, or details should be added. --> Likewise, Shape folder also includes alb files which are FITS binary table files. --> [Table 6] Recommend to add the unit of the values in Table 6. Data ==== data_derived_didymos_model_v003 --> Most of the Global DTM data was not viewable via image and table data_derived_dimorphos_model_v003 --> Some of the Local and Global DTM data was not viewable via image and table --> LIEN from 2022 review - The header has an incorrect value for the target keyword (or the documentation is wrong). TARGET = 'DIMORPHOS' instead of '920065803 Dimorphos’ TARGET = '20065803 DIMORPHOS’ OR TARGET = '20065803 DIDYMOS’ These values differ from the SIS. This sis says – TARGET = ‘920065803 Dimorphos’ OR ‘120065803 Didymos’ Strings that include NAIF ID and name are not (and will not be) recognized by SPICE. The header TARGET naming convention should be updated. Please update to something along the lines of 'DIDYMOS'/'DIMORPHOS', or '65803 DIDYMOS'/'DIMORPHOS', or '65803 Didymos'/'(65803) Didymos I (Dimorphos)’ as used in the XML labels fields. --> LIEN from 2022 review - There is a plane (ALBEDO) missing in the global image cube, that is present as an ancillary FITS file: g_08440mm_spc_alb_dimo_0000n00000_v002.fits Local Dimorphos DTMs v3 & v4 have albedo Global DTMs are still missing Albedo FITS DTM --> All elements have the same unit (m/s^2). FITS binary table files (2D) xx_slp_xx (dtm folder) --> The label for xx_slp_xx.xml has incorrect information: 1) the unit of slope (m/s^2 >> degree), 2) the unit of SIGMA is not labeled (degree). FITS binary table files (2D) xx_elv_xx, xx_pot_xx (gravity folder) --> The label for xx_elv_xx.xml has incorrect information: 1) the unit of elevation (M/S^2 >> m), 2) the unit of gravitational potential (M/S^2 >> J/KG), 3) the unit of SIGMA is not labeled (m). FITS binary table files (2D) xx_grm_xx, xx_grv_xx (gravity folder) --> The label for xx_grm_xx.xml and xx_grv_xx.xml has incorrect information: 1) the unit of SIGMA is not labeled (M/S^2). FITS binary table files (2D) xx_alb_xx (shape folder) --> The label for xx_alb_xx.xml has incorrect information: 1) the unit of albeo should be unitless (M/S^2 >> unitless). FITS binary table files (2D) (tilt folder) --> All files in 'tilt folder' also have the same label issue: wrong unit or unlabeled unit. EN Review ========= urn:nasa:pds:dart_shapemodel:data_derived_dimorphos_model_v004 bundle_dart_shapemodel.xml - If this file is under review, readme.txt Introduction to the bundle but https://sbnreview.astro.umd.edu/revpro/dart202309/dart_shapemodel/ has no readme.txt collection_data_derived_dimorphos_model_v004.csv - Line 64 has a LID not in any label in this directory P,urn:nasa:pds:dart_shapemodel:data_derived_dimorphos_model_v004:dimorphos_impact_point_model::1.0 collection_data_derived_dimorphos_model_v004.xml - Line 118: urn:nasa:pds:dart:data_dracoraw:overview_dracoraw should be, to match dart/data_dracoraw/overview_data_dracoraw.xml: urn:nasa:pds:dart:data_dracoraw:overview_data_dracoraw - https://pds.nasa.gov/datastandards/documents/policy/PolicyOnDOI10142020.pdf requires all bundles have a doi. For SBN, perhaps collections should. These can be obtained from https://pds-engineering.jpl.nasa.gov/content/doi dtm/dimorphos_g_0972mm_spc_dtm_0000n00000_v004.fits dtm/dimorphos_g_1940mm_spc_dtm_0000n00000_v004.fits - Did these files get chopped? Their sizes are 15Meg and 6.5Meg, but the final Array_2D_Image in both labels is 26036740 (26Meg) gravity/*_grv_*.xml - 6 should be 10 shape/*_obj_*.obj - The lines must end in CRLF, as specified by line 168 in the .xml file shape/*_obj_*.xml - Line 101: element records should precede element comment - Lines 111, 161: local_identifier can't have spaces, so perhaps change Vertex Table Facet Table to VertexTable FacetTable - Line 163: element records must have a value - If the line endings of the .obj files stay as LF, many field_location and record_length values will need correcting. If the .obj files are converted to CRLF, the offset values of the two tables must be fixed. For example, the first file dimorphos_g_0243mm_spc_obj_0000n00000_v004.xml: 2792 1579014 should be 2855 1579014 104217779 3145728