=============================================== NOTE: (1) These comments are for the 2023 Sept 15 DART Peer review. =============================================== Datasets Validated: urn:nasa:pds:liciacube::1.0 urn:nasa:pds:liciacube:data_tnf::1.0 urn:nasa:pds:liciacube:document::1.0 urn:nasa:pds:liciacube:leia_raw::1.0 urn:nasa:pds:liciacube:leia_calibrated::1.0 urn:nasa:pds:liciacube:luke_raw::1.0 urn:nasa:pds:liciacube:luke_calibrated::1.0 =============================================== Errors for: General comments Target of Didymos, but many times text talks about Didymos system. Should add target? I recall this being talked about during the previous review. --> Important ingested target context LIDS: --> --> (65803) Didymos: urn:nasa:pds:context:target:asteroid.65803_didymos --> --> (65803) Didymos I (Dimorphos): urn:nasa:pds:context:target:satellite.65803_didymos.dimorphos Consider making the collection.xml internal reference to the overview document a LIDVID reference instead of LID reference. This is due to newer versions of an overview document being pointed to by an older version of the collection when the newer version overview document may not correctly apply to it. --> This especially pertinent to the LDT DDP data collection where the overview document changed, and the newer version is not relevant to the older collection. SBN should generate DOIs and put the into the collection.xml files (and bundle.xml?). =============================================== Errors for: LICIACube Please note that the data_tnf collections uses the 1.18.0.0 information model whereas all other collections and bundle products use the 1.14.0.0 information model. Context Products Need to be provided: --> urn:nasa:pds:context:instrument:liciacube.hga --> urn:nasa:pds:context:instrument:liciacube.leia --> urn:nasa:pds:context:instrument:liciacube.luke file: 'bundle_liciacube_spacecraft.xml' --> Please come up with a better more concise . The <title> might make a good <description> though; you may want to add it to the <description>. --> References readme.txt file, but it is not present. Please provide or remove the reference. --> There is no need to include in this file the target Didymos. But if it must be here, the LID should be corrected to: "urn:nasa:pds:context:target:asteroid.65803_didymos". Please note the change of a period to an underscore in "65803.didymos" --> The data_tnf collection reference needs to be added. --> All collections listed should use <lidvid_reference> instead of <lid_reference>. --> Need to include data_tnf as a Bundle_Member_Entry. files: '*/collection*.xml' --> The <description>s in collection.xml file describe a LICIACube mission, but cites the DART mission. Should there be an association in the verbiage between DART and LICIACube? --> typo in <description> for leia_calibrated: "RedirectionTest" to "Redirection Test" --> update <publication_year> from 2022 to 2023 in leia_raw --> The data collections do not have unique <title>s, probably because they do not mention the instrument. Please make the <title> more concise and unique within the bundle by including the instrument name/abbreviation. --> Sanity check on the Primary_Result_Summary. All luke/leia data collections list the following: Dynamical Properties, Physical Properties, Flux Measurements. --> For the target Didymos, the LID should be corrected to: "urn:nasa:pds:context:target:asteroid.65803_didymos". Please note the change of a period to an underscore in "65803.didymos" --> --> Note that the document collection should remove the this target. files: '*/collection*.csv' --> The luke and leia data collections need to have all records end in carriage return line feed (/r/n), not just line feed (/n). Please fix. --> The LIDVIDs in the calibrated collections for this inventory file do not match those found in the data files. They are missing "_01" at the end of the LID, but this should be confirmed. --> Some LIDs are missing from the data collection inventory files or LIDVIDs found therein are not found in the collections. Please regenerate these files. TNF Collection LID mismatch. --> The collection part of the data_tnf collection LID is different than what is found in all of the data products: "data_tnf" vs "tnf". --> --> If going to use data_tnf, than fix the (1) collection_data_tnf.csv file and (2) all other products except the overview and collection product. --> --> If going to use tnf, please update the (1) bundle_liciacube_spacecraft.xml file, collection_data_tnf.xml, and overview_data_tnf.xml. directory: 'data_tnf/' --> Please move all the data products into a subdirectory. PDS can do this. file: 'document/asi_liciacube_leialuke_calibration_pipeline_description.xml' --> The <file_name> listed, "asi_liciacube_leialuke_calibration_pipeline_description_v1," for this document product is not correct. Please correct it to match the PDF filename. file: 'document/asi_liciacube_leialuke_calibration_pipeline_description.pdf' --> This PDF file claims to follow the PDF/A-3A standards, but fails verification. But that aside, to be in the PDS archive, it must abide by the PDF/A-1a or PDF/A-1b standards. Please correct. --> The document imbedded title (what shows up on the Adobe header bar) should be updated, as it currently states "[Notes: Document owner is to please ascertain in advance whether ITAR statement is required ...]". Please fix. --> The Graphical depiction in 4.1 (figure 1) may be missing some imagines because it does not make much sense. --> I found at least 37 images that were not calibrated. Perhaps I missed this, but I do not see where in the documentation it states what should not be calibrated. file: 'document/collection_document.xml' --> The file size for collection_document.csv should be updated from 137 to 500. file: 'document/lcc_leia_luke_sis.pdf' --> This file using the PDF/A-3A standards. To be in the PDS archive, it must abide by the PDF/A-1a or PDF/A-1b standards. Please correct. file: 'document/lcc_rs_sis.pdf' --> "Error! Bookmark not defined." found in the table of contents on the 7.3 line. --> The footer of this document says "Version 4" yet the Revision Log on page 3 only goes thru version 0.1. --> pag 7, section 4.1, first sentence has a new line inserted between "Network" and "(DSN)" --> Is the LID "urn:nasa:pds:dart.spice:spice_kernels" found on page 8 Table 2 real? --> Is the Data Processing Levels table (Table 4 on pg 16) correct? It says that PDS4 "Calibrated Data" is the same as PDS3 Resampled Level 4, with a description of irreversibly transformed data. --> The document imbedded title should be updated, as it currently states "[Notes: Document owner is to please ascertain in advance whether ITAR statement is required ...]". Please fix. --> I found at least 37 images that were not calibrated. Perhaps I missed this, but I do not see where in the documentation it states what should not be calibrated. files: '{luke,leia}_*/*/*.xml' --> The <dart:correct_image_time> value must end in a "Z" to be valid. --> There are two instances of <dart:liciacube_calibration_file> but the dictionary only allows zero to one instance. file: 'leia_calibrated/calibration/liciacube_leia_cal_col_001.xml' --> The Special_Constants object should be found within the Array_3D, not outside of it. file: 'luke_raw/collection_luke_raw_.*' --> Delete these xml and csv files which are duplicates of the non-underscore files. file: 'luke_calibrated/calibration/liciacube_luke_cal_gen_001.xml' --> The values 'Flat Red', 'Flat Green', 'Flat Blue' are not valid local_identifier_references. If you replace the whitespace with an underscore that should fix the issue. --> For human readability, please properly tab out each xml section. And put "</disp:Display_Settings><disp:Display_Settings>" on separate lines. Note that following files are present and should probably be deleted as they are not referenced: --> leia_calibrated/calibration/liciacube_leia_cal_col_001.xml.old --> leia_calibrated/calibration/liciacube_leia_cal_gen_001.xml.old --> luke_calibrated/calibration/liciacube_luke_cal_col_001.xml.old --> luke_calibrated/calibration/liciacube_luke_cal_gen_001.xml.old At first glance the browse PNG files do not appear to be aligned the same as the images. They appear to be mirror flipped along the x-axis. Please confirm and correct if needed. --> Also some of these pictures do not look like the fits images in ds9. Some png files appear to be windowed, others appear to have the noise on the reverse side of where it is shown in ds9. Very weird. --> --> Example: leia_*/final/liciacube_leia_l[02]_1664616366_00006_01.*