Lucy LLORI Bundle Liens ======================= Bundle ====== --> There are versioning issues that need to be worked out during the real delivery. --> There are inconsistencies in names across the dataset: LLORRI vs. L’LORRI. --> Reference List should include LIDs and DOIs for Space Science Reviews paper. --> Attribute definitions in the Lucy dictionary are often just restatements of the names of the keywords, and they are also not explained very well in the documentation. --> Problems from the Known Issues list (such as exposure time) need to be fixed. --> Target names in basic products are automatically populated from FITS headers as UNKNOWN, but in the collection file it’s given as space. These should be made consistent if they’re supposed to be the same thing. --> Richard Chen’s comments should be taken as liens --> Remember that the version needs to be 2.0 for bundle, and the calibration and document collections due to the v1.0 being for the Didymos release. --> Citation_Information author list is placeholder. --> Citation_Information lacks a . --> Suggestion: Add appropriate s in Citation_Information --> Modification_History has a Modification_Detail for version 0.1, which doesn't exist. The label should have modification detail for its own version and for all earlier versions. --> for the bundle is in 1970, probably an error. --> descriptions for observing system components are placeholders. (The descriptions do appear in the collection labels.) collection: calibration ======================= --> Calibration target names given are the purpose of the observation rather than the actual target. (Target would be a lamp or something equivalent in a spacecraft.) Alternative is to not label calibration files as Product_Observational, in which case target attributes are not required. --> Except for the collection.xml file, none of theses labels include the spacecraft as part of the Observing_System. Is this correct? Expected LID: 'urn:nasa:pds:context:instrument_host:spacecraft.lucy' --> Exposure time - How and when should it be corrected seems to be missing. Also, in the PDS4 XML label the exposure time is 30 s. And in the files llorri_toffsets_1x1.txt and llorri_toffsets_4x4.txt the exposure time is in ms with a max exposure of 999ms. --> Bias substraction – systematic offset of 3.2 DN for 1 x 1 and 5.1 DN for 4 x 4. It’s unclear how this should be corrected --> Smear Removal - The Texp is an array and should be Texp(i) or Texp(j) in the equation. However, in the equation it looks like a single value. When reproducing the steps, I didn’t take into account the smear removal. --> Label: Author list and description in Citation_Information have “TBS” collection: data_cruise2_partially_processed =========================================== --> Some geometry vectors in raw and calibrated FITS headers are in the opposite direction compared to the vectors in the PDS labels. --> FV crashes on raw and calibrated data. Carol Neese had the same problem. --> PP (partially processed) error and quality arrays are all 0. This is a known issue and should get filled in later. --> References to the individual products used in calibration are missing. --> Suggestion: Add FITS keywords missing from labels: -->--> Angle between Earth and instrument boresight (EARTH_ELONG -->--> Angle between target and instrument boresight (TFT_ELON) -->--> Position angles (PA_X/Y/ZINS, PA_SUN, PA_SUN_X/Y/Z) -->--> Spice status (SPCSTAT) – It’s either OK or INCOMPLETE and I would think a user would want to know if it’s incomplete -->--> I would add the short and long wavelengths of the instrument -->--> add the target NAIF ID if applicable collection: data_cruise2_raw ============================ --> Some geometry vectors in raw and calibrated FITS headers are in the opposite direction compared to the vectors in the PDS labels. --> FV crashes on raw and calibrated data. Carol Neese had the same problem. --> Author lists have last names only. --> Raw histogram and image_descriptor arrays are all 0s. --> Suggestion: Add FITS keywords missing from labels: -->--> Angle between Earth and instrument boresight (EARTH_ELONG -->--> Angle between target and instrument boresight (TFT_ELON) -->--> Position angles (PA_X/Y/ZINS, PA_SUN, PA_SUN_X/Y/Z) -->--> Spice status (SPCSTAT) – It’s either OK or INCOMPLETE and I would think a user would want to know if it’s incomplete -->--> I would add the short and long wavelengths of the instrument -->--> add the target NAIF ID if applicable collection: document ==================== --> SIS refers to a specific information model version that does not match what’s used in the labels. Should be made consistent. --> SIS refers to calibrated data in numerous places, but elsewhere it’s partially processed in accordance with PDS4 terminology. Should be made consistent. --> SIS does not give adequate information on quality extensions. --> SIS mentions FITS keywords for converting to physical units, but these do not appear in the FITS headers or in the PDS4 labels. These would have to be written into the mission dictionary. file: 'document/llorri_sis.xml' --> The LID is wrong for this file. Note the bundle part is for leisa, not lorri: 'urn:nasa:pds:lucy.leisa:document:llorri_sis' --> Section 2.3.2 has Word warning "Error! Reference source not found.” --> Section 2.3.2.2.8 Conversion to Physical Units: It says the "photometry" keyword devisors for scaling count rates in the data product to physical units are added to the FITS header. These FITS header keywords are not identified, and I can't find anything like this in the FITS header or in the PDS4 label. Instrument paper has more information about this, and gives specific values for keywords in Table 6. Are these the keywords to use rather than having custom keywords in each image label and header? In that case the SIS should say that, and give the keyword values. --> Filename definition in section 2.3.4.1 doesn't match the product filenames. --> Header of SIS wrongly says "Lucy SOC to PDS SBN Interface Control Document". --> Table 3.2 and the 2nd Table 3.2 (it should be 3.3?) need to be corrected. Probably not a full list -->--> MIDUTC is not lucy:mid_sclk but lucy:mid_utc -->--> PRODLVL is not processing_level -->--> TRGFOVN is not lucy:target_fov_name because it’s the the number of target -->--> SPCSCNM is Lucy in the PDS3 fits header and the geom:Reference_Frame_Identification/geom:frame_spice_name is J2000 -->--> For the Vectors you should list the geom:vectors/geom:Vectors_Cartesian_Specific/geom:Vector_Cartesian_Position/velocity_XX_To_XX instead of just geom:vectors -->--> SOL_ELON is not geom:vectors but geom:Illumination_Geometry/geom:Illumination_Geometry/geom:solar_elongation -->--> SPCTRANG is not geom:vectors but geom:Distances/geom:Distances_Specific/geom:spacecraft_target_center_distance -->--> SPCTSORN/SPCTEORN/SPCSCSRN/SPCESCRN you need to list the geom:distances/geom:Distances Specific/ - geom:target_heliocentric_distance/ geom:target_geocentric_distance/geom:spacecraft_heliocentric_distance/geom:spacecraft_geocentric_distance instead of just geom:distances -->--> SPCKMK is geom:SPICE_Kernel_Identification/geom:spice_kernel_file_name and not only geom:SPICE_Kernel_Identification -->--> SPCKNUM is not in the PDS4 XML -->--> CD[n]_[n] are ebt:Transformation_Element/ebt:element_value and not only ebt:Transformation_Element -->--> CTYPE1/2 are not ebt:coordinate_system_projection but ebt:coordinate_name -->--> CUNIT1/2 are not the ebt:frame_spice_name because it’s the unit (deg) -->--> CRVAL1/2 are not not ebt:Reference_Frame_Identification/ebt:frame_spice_name but ebt:World_Axis/ebt:world_coordinate_reference_point -->--> A/B/AP/BP_ORDER are ebt:A/B/AP/BP_ORDER/bt:polynomial_order and not only ebt:A/B/AP/BP_ORDER -->--> A/B/AP/BP_[n]_[n] are ebt:A/B/AP/BP_ORDER/ebt:SIP_Element/ebt:element_value and not only ebt:A/B/AP/BP_ORDER -->--> ASM is not lucy:lralph_status but lucy:LLORRI_Instrument_Parameters/lucy:attached_sync_marker_dec EN Review ========= calibration/collection.xml document/collection.xml - Both labels have Indentification_Area/version_id = 2.0, which does not match the highest Modification_Detail/version_id or bundle.xml's lidvid_references. calibration/*xml - In case this is accidental, none has a lid_reference to urn:nasa:pds:context:instrument_host:spacecraft.lucy - disp:Display_Settings is missing. pds4_viewer orients the image vertically flipped from fv (the native? .fits viewer). data_cruise2_partially_processed/*.xml - ebt:World_Axis must have exactly one of ebt:vertical_coordinate_pixel and ebt:horizontal_coordinate_pixel Having both or none is wrong, as defined by PDS4_EBT_1I00_1000.xsd. Each label has two ebt:World_Axis with both vertical_ and horizontal_, e.g. 1 Right Ascension Gnomonic plus SIP 79.39099040656998 128.5 128.5 2 Declination Gnomonic plus SIP 31.76716443156087 128.5 128.5 - These files do not use the Display dictionary, which sets PDS4's orientation of the images. data_cruise2_raw/*xml - Each has a slightly incorrect lid_reference to a calibrated product, e.g. urn:nasa:pds:lucy.llorri:data_cruise2partially_processed:lor_0747013512_... should be urn:nasa:pds:lucy.llorri:data_cruise2_partially_processed:lor_0747013512_... - These files do not use the Display dictionary, which sets PDS4's orientation of the images. document/llorri_sis.xml - This product's LID is presumably wrong: urn:nasa:pds:lucy.leisa:document:llorri_sis document/collection_inventory.csv expects LID (presumably correct) urn:nasa:pds:lucy.llorri:document:llorri_sis