Lucy MVIC Bundle Liens
======================

Bundle
======
--> Add appropriate keywords in Citation Information. (These should be at the collection level because that’s where the DOIs are.)
--> Richard Chen’s comments should be taken as liens
--> Except for the collection.xml file, none of theses labels include the spacecraft as part of the Observing_System.  Is this correct?  Expected LID: 'urn:nasa:pds:context:instrument_host:spacecraft.lucy'
--> According to SIS, MVIC data products can have up to 6 bands.  All products provided for review have only 1 band, so the case of more than one band has not yet been reviewed.  Additional review will be needed once multi-band data are available.
--> According to SIS, MVIC data products can have binning set independently for along-track and cross-track.  All data products provided for review have the same binning, so cases of variable binning have not yet been reviewed.  Additional review will be needed once variable binning data are available.
--> All MVIC calibrated products under review use the default space calibration file.  Additional review will be needed once the “nearby” space files are available and in use.
--> Author lists have placeholder.
--> Citation information description is appropriate for bundle label, not collection labels.
--> Modification details have <version_id> 0.1, which doesn’t exist.
Target names and types should be the same as that of the products in the collection.  They are not.  (Include multiple target names and types if needed.)

collection: calibration
=======================
--> What is the modified space file? It is in the collection but is not mentioned in the SIS and has different dimensions than what is in the default space file.
--> Default space file has only one band, but what if data file to be reduced has multiple bands?
--> The SIS doesn’t make it clear where you would find the nearby space files.
--> Calibration arrays should have band and sample instead of line and sample.
--> No display settings.

collection: data_ega1_calibrated
================================
--> Values in background arrays are all the same, a small integer. Replace with non-placeholder value.
--> Target name is UNKNOWN (ported from blank FITS keyword, probably).
--> Modification detail has <version_id> 0.1, which doesn’t exist.
--> Target names for all data labels is UNKNOWN.  Choose a real target name from the context collection appropriate for cruise data.  (TARGET keyword in FITS label is blank, which may be producing this problem.)
--> Target context object cited is Calibration Field, Scat Light, which doesn’t agree with the target.
--> <purpose> is given as Science, but target type is Calibration Field, implying the <purpose> ought to be Calibration or maybe the target type is inappropriate.  In general, the target names and types and the <purpose>(s) should be used consistently across bundle, collection, and basic product labels, across processing levels, and across instruments.
--> Suggestion:  Give a description for the Array_3D_Image.  (Raw has "Image Array”.)
--> Element_Array has no <unit>. According to SIS it should be W/cm^2/sr/micron.
--> Background and Calibration Coefficients 2D Arrays both have the Band and Sample <elements> reversed.

collection: data_ega1_raw
=========================
--> Band and sample element numbers are reversed, so the 3d arrays cannot be displayed correctly with PDS4 viewers. Data can be read correctly if those numbers are swapped.
--> Author list Deenis —> Dennis
--> Modification detail has <version_id> 0.1, which doesn’t exist.
--> Target names for all data labels is UNKNOWN.  Choose a real target name from the context collection appropriate for cruise data.  (TARGET keyword in FITS label is blank, which may be producing this problem.)
--> Target context object cited is Calibration Field, Scat Light, which doesn’t agree with the target.
--> <purpose> is given as Science, but target type is Calibration Field, implying the <purpose> ought to be Calibration or maybe the target type is inappropriate.  In general, the target names and types and the <purpose>(s) should be used consistently across bundle, collection, and basic product labels, across processing levels, and across instruments.

collection: document
====================
--> Helpful to have a diagram to clarify the along-track pixels, cross-track pixels and their relation to the TDI and binning
--> SIS 2.3.2.2 second para - provide criteria SOC used to select “nearby” space block.
--> Header of SIS wrongly says "Lucy SOC to PDS SBN Interface Control Document".
--> Section 1.2 Applicable Documents cites documents with IM version 1.16, but bundle uses 1.18.  This can be fixed by changing the SIS references to say "1.16 or later”.
--> Suggestion:  Section 2.1 It would be helpful to have a diagram to clarify the along-track pixels, cross-track pixels, pre-scan pixels, and their relation to the TDI and binning.
--> Section 2.2 Part 2 describing the calibration files doesn't mention the space files or tell anything about them.  There is insufficient information about the contents of the calibration collection.
--> Section 2.3.2.2 second paragraph - Provide the criteria SOC uses to select the "nearby" space block. 
--> Section 2.3.2.2 There is a TBD in step 4.
--> Section 3.2:  Sections 3.1.1 and 3.1.2 describe the raw and calibrated data formats.  It would be good to specify the axes more specifically, i.e. order of the axes in the array, which one is cross track, along track, and band, and what their sizes are, with a range or description for those with variable size.
--> There is no section 3.1.3 to describe the formats of the calibration data.


EN Review
=========

calibration/*xml
- In case this is accidental, none has a lid_reference to
  urn:nasa:pds:context:instrument_host:spacecraft.lucy

calibration/MVIC_radcal_tdi64.xml (& others?)
- disp:Display_Settings is missing. pds4_viewer orients the image vertically
flipped from fv.
- For pds4_viewer to match fv visually, change
  <Axis_Array>
    <axis_name>Line</axis_name>
    <elements>5024</elements>
    <sequence_number>1</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Sample</axis_name>
    <elements>6</elements>
    <sequence_number>2</sequence_number>
  </Axis_Array>
to
  <Axis_Array>
    <axis_name>Line</axis_name>
    <elements>6</elements>
    <sequence_number>1</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Sample</axis_name>
    <elements>5024</elements>
    <sequence_number>2</sequence_number>
  </Axis_Array>

data_ega1_raw/*.xml
- Each has a slightly incorrect lid_reference to a calibrated product, e.g.
  urn:nasa:pds:lucy.mvic:data_ega1calibrated:mvi_0719079343_02209_sci
should be
  urn:nasa:pds:lucy.mvic:data_ega1_calibrated:mvi_0719079343_02209_sci
- For pds4_viewer to match fv visually, change
  <Axis_Array>
    <axis_name>Band</axis_name>
    <elements>5024</elements>
    <sequence_number>1</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Line</axis_name>
    <elements>2698</elements>
    <sequence_number>2</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Sample</axis_name>
    <elements>1</elements>
    <sequence_number>3</sequence_number>
  </Axis_Array>
to
  <Axis_Array>
    <axis_name>Band</axis_name>
    <elements>1</elements>
    <sequence_number>1</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Line</axis_name>
    <elements>2698</elements>
    <sequence_number>2</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Sample</axis_name>
    <elements>5024</elements>
    <sequence_number>3</sequence_number>
  </Axis_Array>
It makes sense that there's only 1 band, right?

document/mvic_sis.pdf
- Is EGA1 data going to be archived? If so probably add
  urn:nasa:pds:lucy.mvic:data_ega1_raw and _calibrated
to Table 3-1.