Lucy TTCAM Bundle Liens ======================= Bundle ====== --> Richard Chen’s comments should be taken as liens --> Except for the collection.xml file, none of theses labels include the spacecraft as part of the Observing_System. Is this correct? Expected LID: 'urn:nasa:pds:context:instrument_host:spacecraft.lucy' collection: calibration ======================= --> Target names should be to the actual target, not the purpose or the product itself. --> References to incorrect or missing documents. --> Radiance units between FITS header and SIS are inconsistent. --> Dark pixel values extraction row and columns are outside the size of the image and don’t match what’s in the SIS either, so calibration could not be done. --> No explanation given of how to divide by exposure time. collection: data_ega1_calibrated ================================ --> Geometry vector keywords in FITS headers may need to be reversed in PDS4 labels. --> Calibrated data references a master flat file that does not exist in the calibration collection. --> Fill out Primary_Result_Summary. --> Suggestion: Add FITS keywords missing from labels: -->--> Angle between Earth and instrument boresight (EARTH_ELONG -->--> Angle between target and instrument boresight (TFT_ELON) -->--> Position angles (PA_X/Y/ZINS, PA_SUN, PA_SUN_X/Y/Z) -->--> Spice status (SPCSTAT) – It’s either OK or INCOMPLETE and I would think a user would want to know if it’s incomplete -->--> I would add the short and long wavelengths of the instrument -->--> add the target NAIF ID if applicable collection: data_ega1_raw ========================= --> Geometry vector keywords in FITS headers may need to be reversed in PDS4 labels. --> Fill out Primary_Result_Summary. --> Suggestion: Add FITS keywords missing from labels: -->--> Angle between Earth and instrument boresight (EARTH_ELONG -->--> Angle between target and instrument boresight (TFT_ELON) -->--> Position angles (PA_X/Y/ZINS, PA_SUN, PA_SUN_X/Y/Z) -->--> Spice status (SPCSTAT) – It’s either OK or INCOMPLETE and I would think a user would want to know if it’s incomplete -->--> I would add the short and long wavelengths of the instrument -->--> add the target NAIF ID if applicable collection: document ==================== --> Some typos ”error! Reference source not found --> Table 3.2 and the 2nd Table 3.2 (it should be 3.3?) need to be corrected. Probably not a full list -->--> INSTRUME is Lucy Terminal Tracking Cameras in the PDS4 XML file. It doesn’t refer to tt1 and tt2. -->--> MIDUTC is not lucy:mid_sclk but lucy:mid_utc -->--> PRODLVL is not processing_level -->--> SPCEMEN is not in the PDS3 fits header -->--> UDPVER is not proc:software_version_id/node but proc:software_version_id -->--> TRGFOVN is not lucy:target_fov_name because it’s the the number of target -->--> SPCSCNM is Lucy in the PDS3 fits header and the geom:Reference_Frame_Identification/geom:frame_spice_name is J2000 -->--> For the Vectors you should list the geom:vectors/geom:Vectors_Cartesian_Specific/geom:Vector_Cartesian_Position/Velocity_XX_To_XX instead of just geom:vectors -->--> SOL_ELON is not geom:vectors but geom:Illumination_Geometry/geom:Illumination_Geometry/geom:solar_elongation -->--> SPCTRANG is not geom:vectors but geom:Distances/geom:Distances_Specific/geom:spacecraft_target_center_distance -->--> SPCTSORN/SPCTEORN/SPCSCSRN/SPCESCRN you need to list the geom:distances/geom:Distances Specific/ - geom:target_heliocentric_distance/ geom:target_geocentric_distance/geom:spacecraft_heliocentric_distance/geom:spacecraft_geocentric_distance instead of just geom:distances -->--> SPCKMK is geom:SPICE_Kernel_Identification/geom:spice_kernel_file_name and not only geom:SPICE_Kernel_Identification -->--> SPCKNUM is not in the PDS4 XML -->--> SPCK00[n] is not in the PDS3 fits header it’s SPCK[n] -->--> CD[n]_[n] are ebt:Transformation_Element/ebt:element_value and not only ebt:Transformation_Element -->--> CTYPE1/2 are not ebt:coordinate_system_projection but ebt:coordinate_name -->--> CUNIT1/2 are not the ebt:frame_spice_name because it’s the unit (deg) -->--> CRVAL1/2 are not not ebt:Reference_Frame_Identification/ebt:frame_spice_name but ebt:World_Axis/ebt:world_coordinate_reference_point -->--> I believe T2CMH001 is msss_cam_mh:camera_product_id and not T2CMH002. And I believe T2CMH002 is msss_cam_mh:analog_offset -->--> T2CMH004 is not msss_cam_mh:spacecraft_clock_start -->--> T2CAI010 is not mg:samples/node but mg:samples -->--> Table 3.6. The BZERO is in the PDS3 XML and the PDS XML Label Class/Attribute should be listed -->--> Section 2.3.2.2 : Why are the size of the calibrated images 2592x2000 and not 2752X2004 as mentioned in section 2.3.2.2 EN Review ========= calibration/*xml - In case this is accidental, none has a lid_reference to urn:nasa:pds:context:instrument_host:spacecraft.lucy calibration/sn194504flat_v0.xml (& others?) - disp:Display_Settings is missing. pds4_viewer orients the image vertically flipped from fv (the native? .fits viewer). - fv shows 2 images, but this label has only a single Array_2D_Image data_ega1_calibrated/*.xml data_ega1_raw/*.xml - ebt:World_Axis must have exactly one of ebt:vertical_coordinate_pixel and ebt:horizontal_coordinate_pixel Having both or none is wrong, as defined by PDS4_EBT_1I00_1000.xsd. Each label has two ebt:World_Axis with both vertical_ and horizontal_, e.g. 1 Right Ascension Gnomonic 43.23373146965288 1296.5 974.5 2 Declination Gnomonic 15.73848568167289 1296.5 974.5 data_ega1_calibrated/*.xml - Each has 3 slightly incorrect lid_references to calibration products: urn:nasa:pds:lucy.ttcam:calibration:sn194504param.txt urn:nasa:pds:lucy.ttcam:calibration:ssn194504bpm_v1.fit urn:nasa:pds:lucy.ttcam:calibration:sn194504masterflat_v1 These LIDs do exist in calibration/: urn:nasa:pds:lucy.ttcam:calibration:sn194504param urn:nasa:pds:lucy.ttcam:calibration:sn194504bpm urn:nasa:pds:lucy.ttcam:calibration:sn194504flat - Each has 5 images, but Display_Settings has 1 local_identifier_reference, to the first Array_2D_Image "image". It should add the other four local_identifiers: bad_pixel_map, radiance_error, iof_image, iof_error_image data_ega1_raw/*.xml - Each has a slightly incorrect lid_reference to a calibrated product, e.g. urn:nasa:pds:lucy.ttcam:data_ega1calibrated:tt1_0719085921_51251_sci should be urn:nasa:pds:lucy.ttcam:data_ega1_calibrated:tt1_0719085921_51251_sci document/ttcam_sis.pdf - Is EGA1 data going to be archived? If so probably add urn:nasa:pds:lucy.ttcam:data_ega1_raw and _calibrated to Table 3-1.