* (relevant to all bundles)

*.xml
- Please provide context products for the context LIDs referenced here, i.e.
  urn:nasa:pds:context:instrument:lucy.leisa
  urn:nasa:pds:context:instrument:lucy.llorri
  urn:nasa:pds:context:instrument:lucy.ltes
  urn:nasa:pds:context:instrument:lucy.mvic
  urn:nasa:pds:context:instrument:lucy.rss
  urn:nasa:pds:context:instrument:lucy.ttcam
  urn:nasa:pds:context:instrument_host:spacecraft.lucy
  urn:nasa:pds:context:investigation:mission.lucy
- Dictionaries PDS4_EBT_1I00_1000.* and PDS4_SB_1I00_0100.* don't exist at
https://pds.nasa.gov/datastandards/dictionaries/index-1.18.0.0.shtml
The first version of EBT at pds.nasa.gov is PDS4_EBT_1K00_1000.*;
no versions of SB are there yet.

*/bundle.xml
- per https://pds.nasa.gov/datastandards/documents/policy/PolicyOnDOI10142020.pdf
bundle.xml needs Citation_Information/doi, obtainable via
  https://pds-engineering.jpl.nasa.gov/content/doi
- None has any lid_reference to a target. Ideally, bundle.xml has a union of
lid_references of its collections, which in turn have a union of lid_references
from their products.

PDS4_EBT_1I00_1000.* 
- This is logically flawed when
ebt:Reference_Frame_Identification/ebt:name = ICRS or GAPPT.
PDS4_EBT_1I00_1000.xsd's Reference_Frame_Parameters/coordinate_system_equinox
has no attribute nillable="true", which means coordinate_system_equinox is
not nillable. But PDS4_EBT_1I00_1000.sch asserts:
  If ebt:Reference_Frame_Identification/ebt:name = GAPPT or ICRS, then ebt:coordinate_system_equinox must be nill.
However, the .sch's test also requires that coordinate_system_equinox exist.
lucy.ttcam/data_ega1_raw/*.xml, lucy.ttcam/data_ega1_raw/*.xml, and
lucy.llorri/data_cruise2_raw/*.xml all hit this flaw.

*/*/collection_inventory.csv
- Every line is missing its VID, as primary members must be LIDVIDs not LIDs

*/*/collection.xml
- All have a lid_reference to
  urn:nasa:pds:lucy.inst:document:ocamssis
Is there such a bundle and such a document? If so, no problem.
- All have a lid_reference to
  urn:nasa:pds:lucy.mission:document:lucymissioninfo
Please check that this LID will exist. The lucy.radioscience review bundle
in May 2023 also had this lid_reference

*/data_*/
- If these directories will have more data files later, the PDS4 Standards
Reference suggests dividing them into subdirectories.

*.xml
- Some URLs of dictionaries point to local files but should be https://pds.nasa.gov/...



lucy.leisa

calibration/*xml
- In case this is accidental, none has a lid_reference to
  urn:nasa:pds:context:instrument_host:spacecraft.lucy
- disp:Display_Settings is missing. pds4_viewer orients the image vertically
flipped from fv (the native? .fits viewer).
- The two elements should swap values in:
  <axis_index_order>Last Index Fastest</axis_index_order>
  <Axis_Array>
    <axis_name>Line</axis_name>
    <elements>1472</elements>
    <sequence_number>1</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Sample</axis_name>
    <elements>1024</elements>
    <sequence_number>2</sequence_number>
  </Axis_Array>
because fv display the images as 1472 wide, so pds4_viewer should as well.

data_ega1_raw/*xml
- Each has a slightly incorrect lid_reference to a calibrated product, e.g.
  urn:nasa:pds:lucy.leisa:data_ega1calibrated:lei_0719078053_02200_sci
should be
  urn:nasa:pds:lucy.leisa:data_ega1_calibrated:lei_0719078053_02200_sci

data_ega1_raw/lei_0719078143_02201_eng_01.xml (& the others?)
- For pds4_viewer to match fv visually, change
  <Axis_Array>
    <axis_name>frames</axis_name>
    <elements>1472</elements>
    <sequence_number>1</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>xtrack</axis_name>
    <elements>20</elements>
    <sequence_number>2</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>atrack</axis_name>
    <elements>2168</elements>
    <sequence_number>3</sequence_number>
  </Axis_Array>
to
  <Axis_Array>
    <axis_name>frames</axis_name>
    <elements>2168</elements>
    <sequence_number>1</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>atrack</axis_name>
    <elements>20</elements>
    <sequence_number>2</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>xtrack</axis_name>
    <elements>1472</elements>
    <sequence_number>3</sequence_number>
  </Axis_Array>

document/leisa_sis.pdf
- Is EGA1 data going to be archived? If so probably add
  urn:nasa:pds:lucy.leisa:data_ega1_raw and _calibrated
to Table 3-1.



lucy.llorri

calibration/collection.xml
document/collection.xml
- Both labels have Indentification_Area/version_id = 2.0, which does not match
the highest Modification_Detail/version_id or bundle.xml's lidvid_references.

calibration/*xml
- In case this is accidental, none has a lid_reference to
  urn:nasa:pds:context:instrument_host:spacecraft.lucy
- disp:Display_Settings is missing. pds4_viewer orients the image vertically
flipped from fv (the native? .fits viewer).

data_cruise2_partially_processed/*.xml
- ebt:World_Axis must have exactly one of
  ebt:vertical_coordinate_pixel and
  ebt:horizontal_coordinate_pixel
Having both or none is wrong, as defined by PDS4_EBT_1I00_1000.xsd.
Each label has two ebt:World_Axis with both vertical_ and horizontal_, e.g.
  <ebt:World_Axis>
    <ebt:axis_index>1</...>
    <ebt:coordinate_name>Right Ascension</...>
    <ebt:coordinate_system_projection>Gnomonic plus SIP</...>
    <ebt:world_coordinate_reference_point unit="deg">79.39099040656998</...>
    <ebt:vertical_coordinate_pixel unit="pixel">128.5</...>
    <ebt:horizontal_coordinate_pixel unit="pixel">128.5</...>
  </ebt:World_Axis>
  <ebt:World_Axis>
    <ebt:axis_index>2</...>
    <ebt:coordinate_name>Declination</...>
    <ebt:coordinate_system_projection>Gnomonic plus SIP</...>
    <ebt:world_coordinate_reference_point unit="deg">31.76716443156087</...>
    <ebt:vertical_coordinate_pixel unit="pixel">128.5</...>
    <ebt:horizontal_coordinate_pixel unit="pixel">128.5</...>
  </ebt:World_Axis>
- These files do not use the Display dictionary, which sets PDS4's orientation
of the images.

data_cruise2_raw/*xml
- Each has a slightly incorrect lid_reference to a calibrated product, e.g.
  urn:nasa:pds:lucy.llorri:data_cruise2partially_processed:lor_0747013512_...
should be
  urn:nasa:pds:lucy.llorri:data_cruise2_partially_processed:lor_0747013512_...
- These files do not use the Display dictionary, which sets PDS4's orientation
of the images.

document/llorri_sis.xml
- This product's LID is presumably wrong:
  urn:nasa:pds:lucy.leisa:document:llorri_sis
document/collection_inventory.csv expects LID (presumably correct)
  urn:nasa:pds:lucy.llorri:document:llorri_sis



lucy.ltes

data_ega1_calibrated/tes_seq_2022286_sci_l2_01.xml
- This has slightly incorrect lid_references to raw products, e.g.
  urn:nasa:pds:lucy.ltes:data_raw:tes_0718933452_02051_eng
  urn:nasa:pds:lucy.ltes:data_raw:tes_0718933492_02052_eng
  ...
should be
  urn:nasa:pds:lucy.ltes:data_ega1_raw:tes_0718933452_02051_eng
  urn:nasa:pds:lucy.ltes:data_ega1_raw:tes_0718933492_02052_eng
  ...
- This file does not use the Display dictionary, which sets PDS4's orientation
of the images.

data_ega1_raw/*.xml
- Each has a slightly incorrect lid_reference to the calibrated product, e.g.
  urn:nasa:pds:lucy.ltes:data_ega1calibrated:tes_0718933452_02051_sci
should be
  urn:nasa:pds:lucy.ltes:data_ega1_calibrated:tes_seq_2022286_sci_l2_01.hdf
- These files include but do not use the Display dictionary, which sets PDS4's
orientation of the images.

document/ltes_sis.pdf
- Is EGA1 data going to be archived? If so probably add
  urn:nasa:pds:lucy.ltes:data_ega1_raw and _calibrated
to Table 3-1.



lucy.mvic

calibration/*xml
- In case this is accidental, none has a lid_reference to
  urn:nasa:pds:context:instrument_host:spacecraft.lucy

calibration/MVIC_radcal_tdi64.xml (& others?)
- disp:Display_Settings is missing. pds4_viewer orients the image vertically
flipped from fv.
- For pds4_viewer to match fv visually, change
  <Axis_Array>
    <axis_name>Line</axis_name>
    <elements>5024</elements>
    <sequence_number>1</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Sample</axis_name>
    <elements>6</elements>
    <sequence_number>2</sequence_number>
  </Axis_Array>
to
  <Axis_Array>
    <axis_name>Line</axis_name>
    <elements>6</elements>
    <sequence_number>1</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Sample</axis_name>
    <elements>5024</elements>
    <sequence_number>2</sequence_number>
  </Axis_Array>

data_ega1_raw/*.xml
- Each has a slightly incorrect lid_reference to a calibrated product, e.g.
  urn:nasa:pds:lucy.mvic:data_ega1calibrated:mvi_0719079343_02209_sci
should be
  urn:nasa:pds:lucy.mvic:data_ega1_calibrated:mvi_0719079343_02209_sci
- For pds4_viewer to match fv visually, change
  <Axis_Array>
    <axis_name>Band</axis_name>
    <elements>5024</elements>
    <sequence_number>1</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Line</axis_name>
    <elements>2698</elements>
    <sequence_number>2</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Sample</axis_name>
    <elements>1</elements>
    <sequence_number>3</sequence_number>
  </Axis_Array>
to
  <Axis_Array>
    <axis_name>Band</axis_name>
    <elements>1</elements>
    <sequence_number>1</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Line</axis_name>
    <elements>2698</elements>
    <sequence_number>2</sequence_number>
  </Axis_Array>
  <Axis_Array>
    <axis_name>Sample</axis_name>
    <elements>5024</elements>
    <sequence_number>3</sequence_number>
  </Axis_Array>
It makes sense that there's only 1 band, right?

document/mvic_sis.pdf
- Is EGA1 data going to be archived? If so probably add
  urn:nasa:pds:lucy.mvic:data_ega1_raw and _calibrated
to Table 3-1.



lucy.rss

data_cruise1_ion/lucy_2022_274_2022_305_ion.xml

data_cruise1_sff/*.xml
- These have a lid_reference to another unknown LID:
  urn:nasa:pds:context:instrument:lucy.prop
If there's debate about what the instrument for such data should be,
other similar data reviewed by EN were:
  urn:nasa:pds:orex.dsn:naf018_sff:* for OSIRIS-REx and
  urn:nasa:pds:dart:data_maf:* for DART
which used the telecommunication system and the high-gain antenna. If there's
no debate, that's fine, and please provide a context product.
- These have a lid_reference to unknown LID
  urn:nasa:pds:lucy.rss:document:naf018
The only LID in this bundle's document directory is
  urn:nasa:pds:lucy.rss:document:rss_info

data_cruise1_skyfreq/L25TNFXL02_DPX_220820628_00.xml
- This has a lid_reference to unknown LID
  urn:nasa:pds:lucy.rss:document:naf018
The only LID in this bundle's document directory is
  urn:nasa:pds:lucy.rss:document:rss_info
- Many fields' descriptions say, "If not known or irrelevant, the value
-99999.999999 may appear." 1) The .TAB file often has -999.999999 (100x
smaller). 2) Suggestion: put such info into a Special_Constant to allow
programmatic detection.



lucy.ttcam

calibration/*xml
- In case this is accidental, none has a lid_reference to
  urn:nasa:pds:context:instrument_host:spacecraft.lucy

calibration/sn194504flat_v0.xml (& others?)
- disp:Display_Settings is missing. pds4_viewer orients the image vertically
flipped from fv (the native? .fits viewer).
- fv shows 2 images, but this label has only a single Array_2D_Image

data_ega1_calibrated/*.xml
data_ega1_raw/*.xml
- ebt:World_Axis must have exactly one of
  ebt:vertical_coordinate_pixel and
  ebt:horizontal_coordinate_pixel
Having both or none is wrong, as defined by PDS4_EBT_1I00_1000.xsd.
Each label has two ebt:World_Axis with both vertical_ and horizontal_, e.g.
  <ebt:World_Axis>
    <ebt:axis_index>1</...>
    <ebt:coordinate_name>Right Ascension</...>
    <ebt:coordinate_system_projection>Gnomonic</...>
    <ebt:world_coordinate_reference_point unit="deg">43.23373146965288</...>
    <ebt:horizontal_coordinate_pixel unit="pixel">1296.5</...>
    <ebt:vertical_coordinate_pixel unit="pixel">974.5</...>
  </ebt:World_Axis>
  <ebt:World_Axis>
    <ebt:axis_index>2</...>
    <ebt:coordinate_name>Declination</...>
    <ebt:coordinate_system_projection>Gnomonic</...>
    <ebt:world_coordinate_reference_point unit="deg">15.73848568167289</...>
    <ebt:horizontal_coordinate_pixel unit="pixel">1296.5</...>
    <ebt:vertical_coordinate_pixel unit="pixel">974.5</...>
  </ebt:World_Axis>

data_ega1_calibrated/*.xml
- Each has 3 slightly incorrect lid_references to calibration products:
  urn:nasa:pds:lucy.ttcam:calibration:sn194504param.txt
  urn:nasa:pds:lucy.ttcam:calibration:ssn194504bpm_v1.fit
  urn:nasa:pds:lucy.ttcam:calibration:sn194504masterflat_v1
These LIDs do exist in calibration/:
  urn:nasa:pds:lucy.ttcam:calibration:sn194504param
  urn:nasa:pds:lucy.ttcam:calibration:sn194504bpm
  urn:nasa:pds:lucy.ttcam:calibration:sn194504flat
- Each has 5 images, but Display_Settings has 1 local_identifier_reference,
to the first Array_2D_Image "image". It should add the other four
local_identifiers: bad_pixel_map, radiance_error, iof_image, iof_error_image

data_ega1_raw/*.xml
- Each has a slightly incorrect lid_reference to a calibrated product, e.g.
  urn:nasa:pds:lucy.ttcam:data_ega1calibrated:tt1_0719085921_51251_sci
should be
  urn:nasa:pds:lucy.ttcam:data_ega1_calibrated:tt1_0719085921_51251_sci

document/ttcam_sis.pdf
- Is EGA1 data going to be archived? If so probably add
  urn:nasa:pds:lucy.ttcam:data_ega1_raw and _calibrated
to Table 3-1.