[ERROR] means that there is an error that needs to be fixed. [WARN] means that there may be an error or that there is an error that may be ignored. =============================================== NOTE: (1) Second full delivery of the KEM2 K6 delivery on 2023-11-03. The prior full delivery was on 2023-08-02, to which a follow up updated delivery of SWAP was received on 2023-08-10. (2) In addition to normal checks, these were made: (a) checked ICD for changes from K5 (b) checked for K5 lien resolution of postponed liens (c) confirmed all pdf files are archive valid and md5s match across data sets (d) confirmed all *.tab files in document/ pass (or are noted below) (e) confirmed *tab files in calib/ are the same as prior versions or a sampling pass (3) I deleted any prior issues that have been resolved. Some are kept if they are for reminders of situations, no action required for those items. =============================================== Datasets Validated: NH-A-LEISA-2-KEM2-V1.0 NH-A-LEISA-3-KEM2-V1.0 NH-A-LORRI-2-KEM2-V1.0 NH-A-LORRI-3-KEM2-V1.0 NH-A-PEPSSI-2-KEM2-V1.0 NH-A-PEPSSI-3-KEM2-V1.0 NH-A-SDC-2-KEM2-V1.0 NH-A-SDC-3-KEM2-V1.0 NH-A-SWAP-2-KEM2-V1.0 NH-A-SWAP-3-KEM2-V1.0 =============================================== Errors for: GLOBAL (all datasets) SPICE files: --> The dataset.cat files state that these datasets "corresponds to New Horizons NAIF SPICE distribution v0007." From what I can tell, only distributions thru "Release 0005" are available at NAIF. For the peer review we will need a copy of the v0007 distribution. --> NH-BLE: Here's a link to the latest version of the NAIF v0007 SPICE release: https://cloud.boulder.swri.edu/index.php/s/FXDAy5yekpEG3kF --> --> SBN-TB 9/8: In recent emails with NAIF, it appears you are still working with NAIF to resolve some issues before v0007 can be archived with NAIF. Will any of these liens affect the geometry information derived from the spice kernels? --> --> --> NH-BLE: At this point in time, I don't think there will be any effects on geometry. --> --> --> SBN-TB 11/3: Great! --> --> If not done so already, it may easy to use a meta kernel instead of giving a long list of spice files. We would strongly encourage this. It may even simplify your pipeline output. --> --> --> NH-BLE: The latest metakernel is provided inside the NAIF release, as 'extras/mk/nh_v07.tm'. --> --> --> SBN-TB 11/3 : But unless I'm mistaken, the PDS3 labels doesn't use the meta kernel but lists each file the meta kernel references. We can sort this out during the review in coordination with NAIF. file: 'catalog/nh_kem2.cat' --> The Mission Overview section and Mission Design section may need to be updated to reflect the change from KEM1 to KEM2. I do see that some of the language was changed to past tense in these sections. --> --> NH-JP: A new “KEM2 Cruise” section was added in the nh_kem2.cat file describing the continuing and new objectives of this continuation of the extended mission. --> --> SBN-TB 11/3: The "Formal mission phase name" matches that of the MISSION_NAME, which is different from the MISSION_PHASE_NAME. But if this correct, I think we can leave it alone. =============================================== Errors for: LEISA file: 'document/seq_leisa_kem2.*' --> The label describes an empty file. Probably okay. --> The label START_TIME and STOP_TIME is empty. Odd, maybe okay? Using "N/A" would be better or using the expected range of the mission. --> --> NH-BLE: START_TIME and STOP_TIME values are now “N/A”. --> --> SBN-TB: Thx [NONE] =============================================== Errors for: LORRI file: 'catalog/dataset.cat' --> SBN-TB 11/3: Thank you for adding two new descriptions regarding the superseded KEM1 files. But in the Version section, can you change the text "previous (KEM1) mission phase" to also specify the DATA_SET_ID(s). I believe those are NH-A-LORRI-2-KEM1-V6.0 and NH-A-LORRI-3-KEM1-V6.0. file: 'document/superseded_files_*' --> SBN-TB 11/3: The third column NAME = OLD_PRODUCT_ID, but should be "NEW_PRODUCT_ID". --> SBN-TB 11/3: The table file needs to have all end of line characters match carriage return line feed ("\r\n"). The label is correct assuming make this fix (correct record length, etc.). --> SBN-TB 11/3: The filename cannot have a dash in it. I suggest you change the dash to an underscore. Don't forget to update the DOCINFO.TXT and DATASET.CAT files. file: 'document/seq_lorri_kem2.*' --> The label describes an empty file. Probably okay. --> The label START_TIME and STOP_TIME is empty. Odd, maybe okay? Using "N/A" would be better or using the expected range of the mission. --> --> NH-BLE: START_TIME and STOP_TIME values are now “N/A”. --> --> SBN-TB: Thx. file: 'document/soc_inst_icd.pdf' (LIEN from K5) --> There is mention of two new ApIDs 0x63C/D for co-added LORRI data in the DS.CAT file, but they are not mentioned in the ICD. This may not be a concern at this stage, but I mention it as an issue that might come up. --> --> 9/15 [BLE] It would be great if we could hold these ICD updates off until the next release, when there is actual data for the new ApIDs. So far, the ICD has NOT been updated yet. --> --> SBN-TB: This is probably fine at this stage. --> --> NH-JP 3/10: No action needed yet. None taken. --> --> SBN-TB 3/15: Accepted. Keeping note for K6 delivery follow up. --> --> SBN-TB 8/3: I see no updates, but I also see none of the new ApIDs being used in the current data set. --> --> NH-JP: Correct, the new ApID data are not in this dateset, so will defer to K7. directory: 'data/' --> Per 8/10 email from Joel and Brian E: "The following LORRI files (4 each of raw and calibrated) supersede the K5 versions, which were corrupt by the playback window bug that we fixed:"" --> --> nh-a-lorri-2-kem2-v1.0/data/20190101_040861/lor_0408617170_0x630_eng.fit --> --> nh-a-lorri-2-kem2-v1.0/data/20190101_040861/lor_0408617171_0x630_eng.fit --> --> nh-a-lorri-2-kem2-v1.0/data/20190101_040861/lor_0408617244_0x630_eng.fit --> --> nh-a-lorri-2-kem2-v1.0/data/20190101_040861/lor_0408617245_0x630_eng.fit --> --> nh-a-lorri-3-kem2-v1.0/data/20190101_040861/lor_0408617170_0x630_sci.fit --> --> nh-a-lorri-3-kem2-v1.0/data/20190101_040861/lor_0408617171_0x630_sci.fit --> --> nh-a-lorri-3-kem2-v1.0/data/20190101_040861/lor_0408617244_0x630_sci.fit --> --> nh-a-lorri-3-kem2-v1.0/data/20190101_040861/lor_0408617245_0x630_sci.fit --> --> We need to some how make clear that these products supersede specific products from K5 and why. This should include their product_id in the form of [DATA_SET_ID]:[PRODUCT_ID], for example: "NH-A-LORRI-2-KEM1-V6.0:LOR_0408617170_0X630_ENG". We will need to figure out what to do in cases where there is not a one to one relationship. After Anne and I talked, we suggest creating a table file with each record having the PRODUCT_ID of the current product, and full PRODUCT_ID (including DS_ID) of the superseded product. It may also be helpful to include a filename path to each product as separate columns as well. A PDS3 label will need to be created for this file, and we believe it should be put into the document directory and referenced in the dataset.cat version history section at minimum (here would also be good to explain why they were superseded, if not also in the table file as a separate column). --> --> NH-BLE: created ‘superseded_files*.tab/.lbl’ files in the document directory as suggested, and explanation added in the dataset.cat. --> --> SBN-TB 11/3: Addressed. Thanks! =============================================== Errors unique to: MVIC file: 'document/soc_inst_icd.pdf' (LIEN from K5) --> There is mention of two new ApIDs 0x54e/f for co-added MVIC data in the DS.CAT file, but they are not mentioned in the ICD. Should they be? --> --> 9/15 [BLE] Ditto with above comment. Hopefully we can hold the ICD updates off for a while until we know exactly what the PDS updates will look like. Note – the real issue here is that the FITS header info (and therefore the labels) for post-FSW FITS files may need to include more info, and that will affect (probably) how we describe the co-adding process within the ICD. We don’t have all those answers yet. I’ll keep working this with LORRI, Howard, and Carly. --> --> SBN-TB: This is probably fine at this stage. --> --> NH-JP 3/10: No action needed yet. None taken. --> --> SBN-TB 3/15: Accepted. Keeping note for K6 delivery follow up. --> --> NH-JP: Correct, the new ApID data are not in this dateset (no MVIC data at all), so will defer to K7. =============================================== Errors for: PEPSSI file: 'catalog/dataset.cat' --> SBN-TB 11/3: Please include mention of the 13 superseded products in the version history section. Similar to LORRI, also please include the DATA_SET_IDs: NH-A-PEPSSI-2-KEM1-V6.0 and NH-A-PEPSSI-3-KEM1-V6.0. directory: 'data/' --> Per 8/10 email from Joel and Brian E.: "The following PEPSSI files (13 each of raw and calibrated), do contain new data played back during the K6 interval. The first two had most of their data copied from K5 and overridden with a few packets of new K6 data. The others had the same thing, but more K6 data:" --> --> nh-a-pepssi-2-kem2-v1.0/data/20181228_040826/pep_0408261117_0x691_eng.fit --> --> nh-a-pepssi-2-kem2-v1.0/data/20181229_040834/pep_0408347517_0x691_eng.fit --> --> nh-a-pepssi-2-kem2-v1.0/data/20220331_051099/pep_0510990716_0x691_eng.fit --> --> nh-a-pepssi-2-kem2-v1.0/data/20220401_051107/pep_0511077116_0x691_eng.fit --> --> nh-a-pepssi-2-kem2-v1.0/data/20220402_051116/pep_0511163516_0x691_eng.fit --> --> nh-a-pepssi-2-kem2-v1.0/data/20220403_051124/pep_0511249916_0x691_eng.fit --> --> nh-a-pepssi-2-kem2-v1.0/data/20220404_051133/pep_0511336316_0x691_eng.fit --> --> nh-a-pepssi-2-kem2-v1.0/data/20220405_051142/pep_0511422716_0x691_eng.fit --> --> nh-a-pepssi-2-kem2-v1.0/data/20220406_051150/pep_0511509116_0x691_eng.fit --> --> nh-a-pepssi-2-kem2-v1.0/data/20220407_051159/pep_0511595516_0x691_eng.fit --> --> nh-a-pepssi-2-kem2-v1.0/data/20220408_051168/pep_0511681916_0x691_eng.fit --> --> nh-a-pepssi-2-kem2-v1.0/data/20220409_051176/pep_0511768316_0x691_eng.fit --> --> nh-a-pepssi-2-kem2-v1.0/data/20220410_051185/pep_0511854716_0x691_eng.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20181228_040826/pep_0408261117_0x691_sci.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20181229_040834/pep_0408347517_0x691_sci.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20220331_051099/pep_0510990716_0x691_sci.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20220401_051107/pep_0511077116_0x691_sci.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20220402_051116/pep_0511163516_0x691_sci.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20220403_051124/pep_0511249916_0x691_sci.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20220404_051133/pep_0511336316_0x691_sci.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20220405_051142/pep_0511422716_0x691_sci.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20220406_051150/pep_0511509116_0x691_sci.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20220407_051159/pep_0511595516_0x691_sci.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20220408_051168/pep_0511681916_0x691_sci.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20220409_051176/pep_0511768316_0x691_sci.fit --> --> nh-a-pepssi-3-kem2-v1.0/data/20220410_051185/pep_0511854716_0x691_sci.fit --> --> We need to some how make clear that these products supersede specific products from K5 and why. This should include their product_id in the form of [DATA_SET_ID]:[PRODUCT_ID], for example: "NH-A-PEPSSI-2-KEM1-V6.0:PEP_0408261117_0X691_ENG". We will need to figure out what to do in cases where there is not a one to one relationship. After Anne and I talked, we suggest creating a table file with each record having the PRODUCT_ID of the current product, and full PRODUCT_ID (including DS_ID) of the superseded product. It may also be helpful to include a filename path to each product as separate columns as well. A PDS3 label will need to be created for this file, and we believe it should be put into the document directory and referenced in the dataset.cat version history section at minimum (here would also be good to explain why they were superseded, if not also in the table file as a separate column). --> --> NH-BLE: created ‘superseded_files*.tab/.lbl’ files in the document directory as suggested, and explanation added in the dataset.cat. --> --> SBN-TB 11/3: Addressed. Thanks! file: 'document/superseded_files_*' --> SBN-TB 11/3: The third column NAME = OLD_PRODUCT_ID, but should be "NEW_PRODUCT_ID". --> SBN-TB 11/3: The table file needs to have all end of line characters match carriage return line feed ("\r\n"). The label is correct assuming make this fix (correct record length, etc.). --> SBN-TB 11/3: The filename cannot have a dash in it. I suggest you change the dash to an underscore. Don't forget to update the DOCINFO.TXT and DATASET.CAT files. file: 'document/seq_pepssi_kem1.tab' --> SBN-TB 11/3: Note that this file is different from the one in the K5 archived data set. --> --> lines 819-829 have a subtle change in column two of "20293" to "20298" --> --> 55 additional lines added at the end of the file. This is expected. =============================================== Errors for: SDC [NONE] =============================================== Errors for: SWAP file: 'catalog/dataset.cat' --> STOP_TIME may need to be updated from "2023-04-24T18:08:02.680" to "2023-03-09T02:03:46.637" for L3 data set, but it is probably fine. --> --> Note that all data after 2023-03-09 (~1.5 months worth) has not been calibrated. --> --> NH-BLE: No change needed. The STOP_TIME difference and the lack of calibrated files after 2023-03-09 are both OK since all files after that date are level2-only 0x585 files. --> --> SBN-TB 11/3: Sounds good. --> SBN-TB 11/3: Please include mention of the 6 superseded products in the version history section (for raw only). Similar to LORRI, also please include the DATA_SET_IDs: NH-A-SWAP-2-KEM1-V6.0 and NH-A-sWAP-3-KEM1-V6.0. directory: 'data/' --> Per 8/10 email by Joel and Brian E.: "SWAP had some overlapping 0x585 files (6 raw only). Some of the older data packets were missing and the new K6 data forced the files to be created:" --> --> nh-a-swap-2-kem2-v1.0/data/20220425_051312/swa_0513129600_0x585_eng.fit --> --> nh-a-swap-2-kem2-v1.0/data/20220426_051321/swa_0513216000_0x585_eng.fit --> --> nh-a-swap-2-kem2-v1.0/data/20220427_051330/swa_0513302400_0x585_eng.fit --> --> nh-a-swap-2-kem2-v1.0/data/20220428_051338/swa_0513388800_0x585_eng.fit --> --> nh-a-swap-2-kem2-v1.0/data/20220429_051347/swa_0513475200_0x585_eng.fit --> --> nh-a-swap-2-kem2-v1.0/data/20220430_051356/swa_0513561600_0x585_eng.fit --> --> We need to some how make clear that these products supersede specific products from K5. This should include their product_id in the form of [DATA_SET_ID]:[PRODUCT_ID], for example: "NH-A-SWAP-2-KEM1-V6.0:SWA_0513129600_0X585_ENG". We will need to figure out what to do in cases where there is not a one to one relationship. After Anne and I talked, we suggest creating a table file with each record having the PRODUCT_ID of the current product, and full PRODUCT_ID (including DS_ID) of the superseded product. It may also be helpful to include a filename path to each product as separate columns as well. A PDS3 label will need to be created for this file, and we believe it should be put into the document directory and referenced in the dataset.cat version history section (and anywhere else you feel it be referenced). --> --> NH-BLE: created ‘superseded_files*.tab/.lbl’ files in the document directory as suggested, and explanation added in the dataset.cat. --> --> SBN-TB 11/3: Addressed. Thanks! --> Note that all data after 2023-03-09 (~1.5 months worth) has not been calibrated. --> --> NH-BLE: This is expected because it is a data file that doesn’t get calibrated. --> --> SBN-TB 11/3: Roger that. directory: 'document/data_summary_plots/' --> SBN-TB 11/3: Minor point, but please update the PUBLICATION_DATE in each label. --> SBN-TB 11/3: Please note that the annual plots do not follow the same filename structure as described in the label. file: 'document/seq_swap_kem1.tab' --> SBN-TB 11/3: Note that this file is different from the one in the K5 archived data set. --> --> lines 817,824,827 have a subtle change in column two of "20293" to "20298" or visa versa. --> --> 44 additional lines added at the end of the file. This is expected. file: 'nh-a-swap-2-kem2-v1/document/superseded_files_*' --> SBN-TB 11/3: The third column NAME = OLD_PRODUCT_ID, but should be "NEW_PRODUCT_ID". --> SBN-TB 11/3: The table file needs to have all end of line characters match carriage return line feed ("\r\n"). The label is correct assuming make this fix (correct record length, etc.). --> SBN-TB 11/3: The filename cannot have a dash in it. I suggest you change the dash to an underscore. Don't forget to update the DOCINFO.TXT and DATASET.CAT files. file: 'document/swap_ssr.pdf' --> I noticed that the file title when you open the pdf is "Author template for journal articles". If easily possible, please fix, but not required. --> --> NH-JP: Fixed. --> --> SBN-TB: Thanks! Keeping this here as a reminder to those migrating that this file has changed.