L'Ralph LEISA Liens =================== Bundle ====== file: readme.txt --> Remove contact information. Documentation ============= file: leisa_sis.pdf --> Possible discrepancy between documentation and some of the files: Documentation states dimensions of individual layers are 1472x1024, which matches some of the individual calibration files, but not the data cubes and other individual calibration files. Ensure documentation explains why full frame is not always read out. --> The array temperature is 119K, but calcorr for temperature only goes to 117K. Discrepancy should be explained. --> Ensure calibration steps are clearly explained. e.g. clarify distinction between flat field and fringe flat. file: 'calibration/collection_overview.txt' --> There are mentioned three major types of files, but not the Wavemap and BPM products. file: 'document/collection_overview.txt' --> The Documents section mentions that documents are named in one of two ways, the first descriptive, the second being based on Open Access DOI. This second is not the case for filename, nor document title. It then starts to describe what a descriptive case might be, but ends up describing a single case in detail. Then finally mentions "two additional documents", which reads as if they should not conform to the prior methods, but they kind of do. Please clarify or correct this whole paragraph. file: 'document/lralph_ssr.xml' --> line 60 typo: The Context_Area.Observing_System_Component.Internal_Reference.lid_reference for the MVIC instrument, points to LEISA instead of MVIC. It should be 'urn:nasa:pds:context:instrument:lucy.mvic'. Data ==== --> Unclear on how to determine integration time. from the file label: int_time=73.89ms sp net integration time int_time=69.84ms. leisa integration time From the SIS: LEIINT = (XTNUM + 3 + (2048 - XTNUM) / 144 + DF) * 0.72ms – equation in SIS leiint=(80+3 + ((2048-80)/144)+0)*.72ms which gives 69.6ms. --> The calibrated data in lei_0752129956_02302_sci_04.fit seem to have some pedestal coming and going between frames. Labels ====== --> Provide valid Display_Settings where missing to eliminate PDS4viewer warning about display settings. Should double check the following Label Context Reference Mismatches, if they are using the correct target reference LID. Note there is always the option to not use a reference LID when none other is appropriate, or one may be created if it makes sense: --> --> 'Fringe Flat' vs 'Flat Field' (urn:nasa:pds:context:target:calibrator.flat_field) (note this is a migration for PDS3, description is lacking....) --> --> --> Affected files: 'calibration/*_fflat_0*.xml' --> --> 'Space Stare' vs 'SPACE' (urn:nasa:pds:context:target:calibration_field.space) --> --> --> Affected files: 'calibration/*_space_01.xml' --> --> --> Note that L'TES uses 'SPACE_CAL' instead. files: 'calibration/[BLWl]*.xml' (data products) --> Specify units if applicable. files: 'data_dinkinesh_calibrated/lei*.xml' --> Should the Array_3D and Array_2D objects have a unit? The raw data specifies in the label "DN" as expected. EN Review ========= lucy.leisa:calibration *.xml (many, not all) - Suggestion: to match the context products, change LEISA Fringe Flat Space Stare Lucy Spacecraft Lucy Mission to Lucy Ralph Linear Etalon Imaging Spectral Array (LEISA) FLAT FIELD SPACE Lucy Lucy collection.xml - The product in this lid_reference isn't given here. Verify the LID is correct urn:nasa:pds:lucy.mission:document:lucy_mission_info In the 2023.05 review, many collection.xml had a lid_reference to urn:nasa:pds:lucy.mission:document:lucymissioninfo and one file lucy.misson/document_mission/mission_document.xml had LID urn:nasa:pds:lucy.mission:document:$lid lucy.leisa:data_dinkinesh_calibrated *.xml (many, not all) - Suggestion: to match the context products, change Lucy Mission Lucy Spacecraft DINKINESH to Lucy Lucy (152830) Dinkinesh collection.xml - The product in this lid_reference isn't given here. Verify the LID is correct urn:nasa:pds:lucy.mission:document:lucy_mission_info In the 2023.05 review, many collection.xml had a lid_reference to urn:nasa:pds:lucy.mission:document:lucymissioninfo lei_0752129330_02298_sci_04.xml lei_0752129711_02300_sci_03.xml lei_0752129956_02302_sci_04.xml - Each has a lid_reference that doesn't match LIDs in leisa.calibrated. Here: urn:nasa:pds:lucy.leisa:calibration:lei_0752129330_02298_space urn:nasa:pds:lucy.leisa:calibration:lei_0752129711_02300_space urn:nasa:pds:lucy.leisa:calibration:lei_0752129956_02302_space The LIDs in leisa.calibrated: urn:nasa:pds:lucy.leisa:calibration:lei_0752129330_02298_space_01 urn:nasa:pds:lucy.leisa:calibration:lei_0752129711_02300_space_01 urn:nasa:pds:lucy.leisa:calibration:lei_0752129956_02302_space_01 lucy.leisa:data_dinkinesh_raw *.xml (many, not all) - Suggestion: to match the context products, change Lucy Mission Lucy Spacecraft DINKINESH to Lucy Lucy (152830) Dinkinesh collection.xml - The product in this lid_reference isn't given here. Verify the LID is correct urn:nasa:pds:lucy.mission:document:lucy_mission_info In the 2023.05 review, many collection.xml had a lid_reference to urn:nasa:pds:lucy.mission:document:lucymissioninfo lucy.leisa:document *.xml (many, not all) - Suggestion: to match the context products, change Lucy Mission Lucy Spacecraft to Lucy Lucy - Suggestion: add lid_reference to target collection.xml - The product in this lid_reference isn't given here. Verify the LID is correct urn:nasa:pds:lucy.mission:document:lucy_mission_info In the 2023.05 review, many collection.xml had a lid_reference to urn:nasa:pds:lucy.mission:document:lucymissioninfo lralph_ssr.xml - bug: Lucy Ralph Linear Etalon Imaging Spectral Array (LEISA) urn:nasa:pds:context:instrument:lucy.leisa Lucy Ralph Multispectral Visible Imaging Camera (MVIC) urn:nasa:pds:context:instrument:lucy.leisa Presumably, the second should be urn:nasa:pds:context:instrument:lucy.mvic