Lucy L'Ralph LEISA Liens ======================== Author name mismatch? --> "Lunsford, A." vs "Lunsford, H." --> --> Instance of "H." in document collection. Documentation ============= file: document/collection_overview.txt --> File is empty. --> The document/collection_overview.txt is empty. The xml file says it is version 1.0, but I would expect it to be version 2.0. The collection.xml reference_list expects a version 2.0 overview file, but the inventory says it is version 1.0. Was including a new collection_overview a mistake? I see no new files, only versioned products. Either (1) include an updated overview file and overview label, and update the LIDVID reference in the collection.xml and collection_inventory.csv files or (2) drop the new overview files, and rely on the copy found in VID 1.0 of this collection. --> author_list entry: "Lunsford, H." => "Lunsford, A." file: calibrated/ollection_overview.txt --> first sentence needs to be updated to say calibrated data from Donaldjohanson encounter, not raw from Dinkinesh, also title --> line 3 says these are "raw images products" but they are calibrated. file: calibration/collection_overview.txt --> Under Bad Pixel Map Heading, “file” should be plural --> Thank you for adding the paragraph (or lines?) describing which space calibration files are for Dinkinesh vs DJ. But they read as if they are one paragraph. Also, they say they are only for space calibration files, but the description could also apply to the Fringe Files. Suggest rewording in such a way to make it a table, or separating out the lines so they don't read as one sentence. file: LRalph_LEISA_activities.pdf --> Typo in word “effective” for details column of Dinkinesh flyby --> Asterisk note on table for temperature notes that T > 103K are off-nominal. So is all data included in these submissions considered off-nominal? file: LRalph_LEISA_PostCalibration.pdf --> Is the algorithm described something that will be included as a tool for users to use, or is it just the description of what should be done? file: calibrated/README.txt --> Says it “contains partially processed images”. Does this just refer to the fact that they haven’t had the post-processing with the fringe flats? file: 'readme.txt' --> The Calibration section only mentions three of the five types, leaving out BPM and Wave map. --> The Calibrated collection sections say they are "partially processed images", but it should say "calibrated". Data ==== --> Data has variety of sizes, reflects different scan strategies? Also seems most are split into short wavelength (1-2.4 microns) and long wavelength (2.4-4 microns) files, except for 607 and 610 --> Discrepancy in object motion. Object moved about 2.0195 pixels per frame, on average; not the ~ 1.53 pixels per integration time, which was stated relevant to Dinkinesh. --> Why do the wavelengths only begin after the bond gap, at 2.7um? --> Size the flatfield (there were two) did not match the size of the image, preventing calibration. --> Tadiometric conversion file missing. Calibrated Data --> Is the overall shape as expected? And is the drop in radiance longward of 3.8um due to saturation? If so, should that be included in the calibrated data? Calibration Data --> Space files seem to have two different appearances and sizes (which alternate), but I think this just reflects the short and long wavelength coverage of the data? directory: 'calibration/' --> The lucy.leisa/calibration collection does not conform with Dinkinesh lien addressed delivery. In the Dinkinesh lien resolved delivery all the fflat and space LIDs had the run version number removed from the LID (example: urn:nasa:pds:lucy.leisa:calibration:lei_0752129330_02298_fflat_03::1.0 to urn:nasa:pds:lucy.leisa:calibration:lei_0752129330_02298_fflat::1.0). This was to conform with standing practice to not include it, but also because the data products referencing these calibration products assumed it didn't either.  But these run version numbers have been reintroduced in the calibration products in this delivery, and the DJ data products cannot properly reference them as a result.  Please fix. SBN-TB used the following mac csh code to fix the files for the peer review: sed -i '' 's#_0[0-9] The Context_Area.Time_Coordinates are only for DJ, not for the entire range of collections (including Dinkinesh). Are the optional Time_Coordinates really appropriate for the bundle? --> Please provide the missing File_Area_Text for the readme.txt file. file: 'calibration/collection.xml' --> Update the Reference_List item for collection_overview VID from 1.0 to 2.0, to match the updated overview file's VID. file: 'calibration/collection_inventory.csv' --> Update the LIDVID item for collection_overview's VID from 1.0 to 2.0, to match the updated overview file's VID. files: 'calibration/lei*.xml' --> [Dinkinesh lien] Provide valid Display_Settings where missing to eliminate PDS4viewer warning about display settings. --> Should the Array_2D_Image objects have a unit? --> Is the "Spectral Cube" really appropriate for a Array_2D_Image? file: 'data_donaldjohanson_*/collection_overview.xml' --> The LID for these files says dinkinesh, but it should be for donaldjohanson. Please correct the logical_identifier. file: 'data_donaldjohanson_raw/lei_*.xml' --> 10 of 28 products reference in their Reference_List a calibrated version of the raw product which does not exist. Assuming the products were not calibrated, please update the pipeline code to check to see if the calibrated product exists before adding a reference. Please remove such references. file: 'data_donaldjohanson_raw/lei_*.xml' --> [Dinkinesh lien] Please add units. This was fixed in the Dinkinesh lien addressed delivery. EN Liens ======== */collection_overview.* - "collection" is a "reserved base name component" in the PDS4 Standards. Suggestion: rename these files to "overview.*". bundle.xml - This has lid_references to collections not in the bundle under review: urn:nasa:pds:lucy.leisa:data_dinkinesh_raw::1.0 urn:nasa:pds:lucy.leisa:data_dinkinesh_calibrated::1.0 Please ensure those collections will still be in the real bundle. - Since readme.txt exists, bundle.xml should point to it, something like readme.txt 0 7-Bit ASCII Text Carriage-Return Line-Feed between Bundle and Bundle_Member_Entry - Within Reference_List (with stuff chopped), these are incorrect: urn:nasa:pds:lucy.mission:document::2.0 bundle_to_document urn:nasa:pds:lucy.leisa:document::2.0 bundle_to_document A bundle_to_document should point to a specific document, not a collection. A Bundle_Member_Entry points to a collection, including documents. This bundle.xml already points to u:n:p:lucy.leisa:document that way. It could also point to the other collection via urn:nasa:pds:lucy.mission:document::2.0 Secondary bundle_has_document_collection calibration/collection.xml - The VID in this lidvid_reference urn:nasa:pds:lucy.leisa:calibration:collection_overview::1.0 doesn't match the calibration/collection_overview.xml's VID, 2.0 - Suggestion: since labels in this collection have them, add lid_references to urn:nasa:pds:context:target:calibration_field.space urn:nasa:pds:context:target:calibrator.flat_field bundle.xml should add these as well calibration/collection_inventory.csv - This contains P,urn:nasa:pds:lucy.leisa:calibration:collection_overview::1.0 but calibration/collection_overview.xml's VID is 2.0 - This contains many LIDs previously delivered but not included in this review. That's fine if those files are available in the real collection. However, 6 such LIDs don't match previously ingested LIDs. In this file: P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129330_02298_fflat::1.0 P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129330_02298_space::1.0 P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129711_02300_fflat::1.0 P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129711_02300_space::1.0 P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129956_02302_fflat::1.0 P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129956_02302_space::1.0 but collection_calibration_inventory.csv, ingested in 2024.10, has P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129330_02298_fflat_03::1.0 P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129711_02300_fflat_02::1.0 P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129956_02302_fflat_03::1.0 P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129330_02298_space_01::1.0 P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129711_02300_space_01::1.0 P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129956_02302_space_01::1.0 data_donaldjohanson_calibrated/collection_overview.xml - Presumably, this file's LID is wrong: urn:nasa:pds:lucy.leisa:data_dinkinesh_calibrated:collection_overview and should be urn:nasa:pds:lucy.leisa:data_donaldjohanson_raw:collection_overview That would solve many missing references in this bundle. data_donaldjohanson_raw/ - This directory file has 27 labels while data_donaldjohanson_calibrated/ has 17. 10 of the files in _raw have lid_references to calibrated labels not in this review, e.g. file lei_0798443091_02608_eng_04.xml references u:n:p:lucy.leisa:data_donaldjohanson_calibrated:lei_0798443091_02608_sci which isn't in this review. This may be an artifcat of selecting files for the review. Please ensure that the delivered products all refer to existing calibrated products. data_donaldjohanson_raw/collection.xml - Suggestion: since a label in this collection has this, add a lid_reference to urn:nasa:pds:context:target:calibrator.internal_source bundle.xml should add this as well data_donaldjohanson_raw/collection_overview.xml - Presumably, this file's LID is wrong: urn:nasa:pds:lucy.leisa:data_dinkinesh_raw:collection_overview and should be urn:nasa:pds:lucy.leisa:data_donaldjohanson_raw:collection_overview That would solve many missing references in this bundle. document/collection_inventory.csv - These LIDs are listed here, but the corresponding docs are missing. P,urn:nasa:pds:lucy.leisa:document:leisa_sis::1.0 P,urn:nasa:pds:lucy.leisa:document:lralph_ssr::1.0 Please ensure they will be available in the bundle. Many labels reference them