Lucy L'LORRI Liens ================== Documentation ============= --> The User’s Guide explains the file naming scheme, but differs from the SIS. Must include the image_counter and image_format parts in the file names. file: readme.txt --> Wrong mission phase for the Donaldjohanson sets. Dinkinesh -> Donaldjohanson. file: 'data_didymos_partially_processed/collection_overview.txt' --> First line and first overview paragraph describe Dinkinesh, not Didymos. Please correct. --> Second overview paragraph describes the DonaldJohanson closest approach, which should be removed. Perhaps you may want to add the approximate distance to Didymos. file: 'data_didymos_raw/collection_overview.txt' --> First paragraph mentions "Lucy Mission Didymos Encounter". Can this really be described as an encounter or is it remote observations. --> First paragraph typo: citing a document title, "LLORRI" => "L'LORRI", per pdf document title (unfortunately, the archived xml title for this pdf document is not quite correct, not even mentioning Didymos) --> Second overview paragraph describes the DonaldJohanson closest approach, which should be removed. Perhaps you may want to add the approximate distance to Didymos. file: data_didymos_partially_processed/Collection_overview.txt --> Entire text refers to Dinkinesh encounter, but this file is supposed to describe Didymos observations. Needs full mission context correction. --> “Closest Approach occurred at 17:51:16 UT April 20, 2025 at a distance of 962 km. All tCA calculations (time of closest approach) are calculated from this date.” unrelated. --> Wrong reference paper --> Add bundle context --> Add usage guidance of this data Data ==== Didymos Data --> Appears as if every other frame of the dataset has strange saturation issues. Flatfield does not show the same pattern. There was either no mention of this phenomenon is the User’s Guide, or it was unclear. Labels ====== --> Target name for DJ should be "(52246) Donaldjohanson". --> Add the target NAIF ID attribute () if applicable. --> lucy:dinkinesh_constant attribute is present. Requires Lucy DD update. --> In both raw and calibrated data labels, the ebt:AP_ORDER and ebt:BP_ORDER classes are missing s that appear in the FITS headers. --> It was unclear where to find spacecraft health data contained in the Image Header/Descriptor headers… are they included with the raw images somewhere? Represented in label files/FITS headers? --> Can the time before/after DART impact be included in the metadata? files: 'data_*/l*.xml' --> [Dinkinesh lien] Add the target NAIF ID if applicable. For example, (152830) Dinkinesh it is 920152830 (TARGETID in the FITS header). // --> Please add the sb:Quality_Map class to help describe the meaning of each value in the quality map which is not described in the xml labels. file: 'bundle.xml' --> typo in Modification_Detail "theDonaldjohanson" => "the Donaldjohanson" file: collection_inventory.csv --> LIDs must be full LIDVIDs. file: 'lucy.llorri/data_didymos_*/collection.xml' --> For the raw colleciton, the Reference_List reference to the overview document is malformed ("overview" mispelled and missing double colons before VID). Please fix from "urn:nasa:pds:lucy.llorri:data_didymos_raw:collection_ovrview:1.0" to "urn:nasa:pds:lucy.llorri:data_didymos_raw:collection_overview::1.0". --> Why was the target urn:nasa:pds:context:target:satellite.65803_didymos.dimorphos added? It was not listed in version 1.0 of the collection and is not found in any of the data product labels. --> The collection overview document (at least for the raw, pp has issues), mentions a description of the LLORRI DART observations being in the User's Guide V2.0. I would highly recommend adding a LIDVID reference to this document in the Reference_List of each of the two Didymos data collection products. --> Please add a single sentence to the Citation_Information.description explaining the major difference between V1.0 and V2.0 of the collection; something similar to the modification history entry should be sufficient. We want to differentiate this data collection version from the prior one. file: 'lucy.llorri/data_donaldjohanson_*/collection.xml' --> [Dinkinesh lien] You have the purpose Science but Navigation in the PDS4 XML data labels. Multiple purposes can be added if applicable. This was fixed in Dinkinesh, but the same situation is for the data_donaldjohanson collections, but not fixed here as well. Test Images. See lor_0798446314_04697_00001_1x1_sci_03.xml --> should not be Science. --> Target name "TEST_IMAGE" does not match test image context object. --> Remove empty geom:Orbiter_Identification. Raw Data --> Either include calibration files specific to this dataset in Reference_List (dj_auto_flat_1x1.xml and dj_auto_flat_4x4.xml) or remove because this is the raw collection. --> Unit for histogram as DN. It’s a count too, but should not mix with DN. --> --> Confirmed with Lucy team that the unit of DN is correct. The x-axis is labeled with a unit of DN, but the y-axis has an implicit unit for histograms of either frequency or something like count/bin or pixels/bin. Partially Processed Data --> All partially processed image extension unit, image, error and quality flag are DN/s, but this is different from the SIS. --> --> Confirmed with the Lucy team that the SIS is correct and the error is in the labels. The units should be in DN for the image and error extension data, and no units for the quality flag extension data. --> Change "calibrated" to "partially processed" in Citation_Information description. --> Add time offset corrections from the sb:Calibration_Applied class in the Small Bodies LDD. --> Remove duplidate urn:nasa:pds:lucy.llorri:calibration:llorri_superbias_1x1 reference. --> Remove duplidate urn:nasa:pds:lucy.llorri:calibration:llorri_toffsets_1x1 reference. --> Only dj_auto_flat_1x1 is listed as a calibration reference file in the Small Bodies dictionary, even though llorri_flat_1x1 is referenced elsewhere. Include both or remove superfluous reference. --> For references to calibration files, use LIDVID instead of LID. Calibration files described in the SB LDD do not need to be included as general Reference_List entries. Calibration Data files: dj_auto_flat_1x1.xml, dj_auto_flat_4x4.xml --> Start and stop date time should be more specific than just a year. --> In the PDS4 XML label the exposure time is 30 s. And in the files llorri_toffsets_1x1.txt and llorri_toffsets_4x4.txt the exposure time is in ms with a max exposure of 999ms. file: 'calibration/collection.xml' --> Please add back the Citation_Information.description from prior versions as it was more verbose and useful. --> Funding_Acknowledgement removed? --> changed from Derived to Raw. Is this correct? --> The number of for the inventory should be updated from 2 to the correct number. --> The inventory file needs to include all v1.0 products. Missing the collection_overview, default_config, and two dinky_flat LIDVIDs. file: 'calibration/collection_inventory.csv' --> When versioning a collection, the collection inventory files should contain a full list of products (best copy usually), not just new or updated products. Please add back all the products from v2.0 of this collection. file: 'calibration/collection_overview.txt' --> This file should be versioned (from dinkinesh) to include mention of the new dj_auto_flat files and update the statements about the flats being valid thru dinkinesh. Don't forget to update any VID references in the collection label and inventory file. file: 'lucy.llorri/calibration/dj_auto_flat_1x1.xml' --> The has the text ".xml" in it that should be removed. EN Liens ======== *.xml - Most (all?) labels have a lid_reference to urn:nasa:pds:lucy.llorri:document:llorri_sis but this delivery doesn't have this file or even a directory document/. Please ensure that label will be availabe in the bundle. calibration/collection_inventory.csv - The labels for the first 8 LIDs listed aren't provided in this review, but many labels in this review have lid_references to them. Please ensure they will be availabe in the real bundle. data_*/ - All four directories have too many files at the top level. Is there a natural split into subdirectories, perhaps by lucy:observation_id? data_didymos_partially_processed/collection.xml - Suggestion: change type from Asteroid to Satellite for <name>(65803) Didymos I (Dimorphos)</...> <type>Asteroid</...> <Internal_Reference> <lid_reference>urn:nasa:pds:context:target:satellite.65803_didymos.dimorphos</...> "Asteroid" matches the currect value in the context product, but that should be corrected to "Satellite" data_didymos_raw/collection.xml - typo in lidvid_reference urn:nasa:pds:lucy.llorri:data_didymos_raw:collection_ovrview:1.0 should be urn:nasa:pds:lucy.llorri:data_didymos_raw:collection_overview:1.0 - Suggestion: change type from Asteroid to Satellite for <name>(65803) Didymos I (Dimorphos)</...> <type>Asteroid</...> <Internal_Reference> <lid_reference>urn:nasa:pds:context:target:satellite.65803_didymos.dimorphos</...> "Asteroid" matches the currect value in the context product, but that should be corrected to "Satellite"