Lucy Radio Science Liens
========================

Documentation
=============

file: rss_sis.pdf
--> Section 2.4.4 states that ASCII files generally end in line feed. However, SFF and ION files, two of the three text type files, actually end in in new-line. The simplest resolution would be to simply delete the second sentence, which is grammatically incorrect anyway. “ASCII or UTF-8 text file generally, line endings are line-feed.”

--> Section 3.2.1 correct the link to https://pds-geosciences.wustl.edu/radiosciencedocs/urn-nasa-pds-jpl_dsn_mmm/ (missing a hyphen at “pdsjpl”

--> Items 4-6 are based on the originally posted SIS. The newly posted SIS, 22668.07-RSS-SIS-01 R0 C1, no longer contains the sky frequency data format description table, which is good to have.

--> 3.2.3 Columns 6 and 7 are declared as not used in closed loop mode. However, the data files contain values other than 0000-00-00T00:00:00.000 or -999999999.999999, respectively. Perhaps the data were collected in “open loop” mode? Please clarify.

--> 3.2.3 Column 8 designated as -99999.999999 but data files contain -999.999999

--> 3.2.3 Column 14 designated as -999.999999 but data files contain 0.000000

--> Acronym List contains several entries that don’t appear in the document.

--> Some entries that should be included in the acronym list are TNF and SFF 

--> (2.1) Lucy will encounter a Main Belt asteroid in 2025, and (REMOVE "and") visit its first Trojan asteroid in 2027, and accomplish its remarkable succession of encounters by 2033,

--> (2.1.1.1) For SPE (ADD "angle") less than 14 degrees

--> (2.1.1.1) For SPEs(CHANGE "SPEs" -> "SPE angle") between 14 and 53 degrees 

--> (2.1.1.1) The LGA is used for SPEs (CHANGE "SPEs" -> "SPE angle") greater than 53 degrees.

--> (2.1.1.1) when SPE (ADD "angle") is less than 60 degrees

--> (2.1.2) Note that the Lucy project has been approved to use of (REMOVE "of") the uplink and downlink X-band frequencies/channels assigned to the OSIRIS-REx and MAVEN projects.

--> (2.3.4.1) Each of the radio science data products have (CHANGE "have" -> "has") a unique naming convention

--> (2.3.4.1) The naming convention for the tracking data products (trk-2-34) products are (CHANGE "are" -> "is")

Data
====
--> Small forces are only present on 2025-04-20 to 2025-04-21. Either document why there are missing small forces files OR provide them.
--> --> Per the Lucy team: The submitted and reviewed SFF file (lcy_r_250420_250421_v05.sff) covers the time period near the Donaldjohanson encounter, and there are no relevant missing data. A data gap before and after that time period is intentional since, per plan, there is no thruster activity around any encounter in order to optimize mass determination. Data outside of the time range of this file do not scientifically improve this dataset, are not necessary for interpretation for the flyby, and will be archived later as cruise data.
--> --> Adjusting lien to document this in the data collection overview file.

--> Skyfreq data only cover 9 passes near the Flyby on DOY 110, whereas TNF data cover DOYs 100 to 117. Either document why there are missing skyfreq files OR provide them.
--> --> Per the Lucy team: The submitted and reviewed sky frequency data covers the time period near the Donaldjohanson encounter, and there are no relevant missing data. Data outside of the time range of these files do not scientifically improve this dataset, are not necessary for interpretation for the flyby, and will be archived later as cruise data.
--> --> Adjusting lien to document this in the data collection overview file.

--> "The SOURCE_PRODUCT_ID mentioned in the label header above links to the different data files used for processing of the DOPPLER output file." Where is this?

Labels
======

Issue: Context object name mismatch
--> The lucy.rss context object should include the alternate name of "Lucy Radio Science Subsystem" or change the delivered product labels' value to "Lucy Radio Science".  Ask PDS-EN for including this alternate name if desired to use it, but submitting a GetHub ticket.  SBN can support making this request.

issue: processing_level
--> There appears to be confusion about what the correct processing level for each data collection and data product is, based on the last review Dinkinesh delivery, lien addressed delivery and the current DJ delivery.  During Dinkinesh lien resolution, the review response to a similar lien said that ion data should be raw. Please confirm what is correct and fix if necessary.
         DJ           Dinkinesh (data labels)
ion      Calibrated   Raw (Partially Processed)
sff      Derived      Raw (Derived)
skyfreq  Calibrated   Calibrated
trk234   Raw          Raw

issue: inconsistent Observing_System_Component
--> The Observing_System_Component does not match between the collection.xml file and the data product labels in the collection.
--> Please note you can have more than one Observing_System, one for Lucy and one for DSN.
--> Sometimes there is an Observing_System that says Lucy is the host with lucy.rss and dsn.rss as its instruments (like in the skyfreq collection).  But the dsn.rss is not an instrument for Lucy.
--> Sometimes only the Lucy spacecraft is listed as the only observing system.

file: 'data_donaldjohanson_*/collection.xml'
--> [Dinkinish Lien reworded] The Target_Identification should not be DJ.  In general these should reflect the primary target(s) or targets of note, observed and listed in the data product labels.  This was fixed in Dinkinesh, but appears again here.
--> All but the Ion collection has a reference in the Reference_List to urn:nasa:pds:lucy.rss:document:rss_info::1.0.  But this LID is unknown.
--> --> Joel suspects it is for the SIS, urn:nasa:pds:lucy.rss:document:rss_sis

files: 'data_donaldjohanson_skyfreq/L*.xml'
--> [Dinkinesh lien] labels contain internal reference to small forces. i think this is an oversight and actually belongs in the SFF labels.
        <Internal_Reference>
            <lid_reference>urn:nasa:pds:orex.radioscience:document:naf018</lid_reference>
            <reference_type>data_to_document</reference_type>
            <comment>
                Although this document does not explicitly pertain to Lucy, its content is still applicable.
                Until a new version of this document is created for Lucy, this reference will have to suffice.
            </comment>
        </Internal_Reference>
--> [Dinkinesh Lien] label <description> makes reference to a SOURCE_PRODUCT_ID but I can't find that anywhere else in the label. the description also makes reference to S-band which Lucy is not capable of. Can the description be updated?
--> [Dinkinesh Lien] The Primary_Result_Summary.description states "The SOURCE_PRODUCT_ID mentioned in the label header above links to the different data files used for processing of the DOPPLER output file. ..." Where is this?
--> --> This appears to be PDS3 jargon and text from a PDS3 label.  Please correct this for the PDS4 environment.

EN Liens
========

- Add lid_references to any context LIDs its collections have, i.e.:
  urn:nasa:pds:context:instrument:dsn.media
  urn:nasa:pds:context:instrument:dsn.rss