Lucy TTCam Liens
================

Correct Author: "Zhao, A." => "Zhao, Y." per Sept 8 thru Sept 10th email chain between SBN:TB and Lucy:JP.

Documentation
=============
file:collection_overview.txt
--> Add the name of the files or the date of observations that correspond to this statement “TTCam images that are 2000 x 2592 rows x columns are “Calibration Mode” images, primarily of stars and star clusters, that are acquired during periodic calibration campaigns not associated with the mission’s actual asteroid flybys.”

files: 'data_*/collection_overview.txt'
--> The text files contain paper references Bell et al. (2023) and Zhao et al. (2024).  Please resolve these references in the text.  One way of doing this is adding a reference list to the bottom of the document.


Labels
======
--> Target name for DJ should be "(52246) Donaldjohanson".

--> Add the target NAIF ID attribute (<geom:body_spice_name>) if applicable.

--> In both raw and calibrated data labels, the ebt:AP_ORDER and ebt:BP_ORDER classes are missing <ebt:SIP_Element>s that appear in the FITS headers.

file: collection_overview.xml
--> Correct <publication_date>2024-08</publication_date> .

Raw Images
--> Remove duplicate <proc:name>Lucy Data Processing Pipeline</proc:name>, <proc:process_owner_name>,
--> Correct "?" lucy:target_fov_name in e.g. tt1_0793310281_03584_eng.xml.

Test Images. See tt1_0798446013_29460_sci_02.xml
--> <purpose> should not be Science.
--> Target name "TEST_IMAGE" does not match test image context object.
--> Remove empty geom:Orbiter_Identification.

Calibration Mode Images
--> Remove all the geometry metadata associated with a target (Distances and Vectors).
--> Change purpose to Calibration. 
--> Remove "Surface" <domain>.
--> Correct lucy:Lucy_Target_List and lucy:target_fov_count.
--> Target name should be the calibration star, not DJ.
--> Target type should be Star, not Asteroid.
--> Remove lid reference to DJ target.

files: 'data_*/t*.xml'
--> The Citation_Information.description is nearly identical in text, but is identical in content between raw and calibrated.  Suggest adding processing level in the description.
--> For the calibrated images, the Bad Pixel Map values are programmatically hidden in the <description> may be able to be mapped using the sb:Quality_Map_Definition class.  Clarify with SBN A. Raugh if there are any issues.
--> [Dinkinesh Lien reworded]  For the raw products, Delete the first block of the following text, since it is duplicated unnecessarily.  Otherwise is the first block missing further information to make it unique from the second block?
                <proc:Process>
                    <proc:name>Lucy Data Processing Pipeline</proc:name>
                    <proc:process_owner_name>Lucy Science Operations Center</proc:process_owner_name>
                    <proc:process_owner_institution_name>Southwest Research Institute</proc:process_owner_institution_name>
                </proc:Process>
                <proc:Process>
                    <proc:name>Lucy Data Processing Pipeline</proc:name>
                    <proc:process_owner_name>Lucy Science Operations Center</proc:process_owner_name>
                    <proc:process_owner_institution_name>Southwest Research Institute</proc:process_owner_institution_name>
                    <proc:Software>
                        <proc:software_id>UDP</proc:software_id>
                        <proc:software_version_id>1.0.10</proc:software_version_id>
                    </proc:Software>
                </proc:Process>
--> [Dinkinish Lien] Does the PDS4 attribute msss_cam_mh:instrument_mode_id refer to the fits header T2CAI001=   1 / camera: 1=DVR, 2=test image injection in the port IMAGE MINI-HEADER  section? If yes, then replace the number by the description text if possible. 
--> --> Lucy-SOC response: no  msss_cam_mh:instrument_mode_id corresponds to T2CAI012 as noted in the SIS.  This is the mode of image or video readout. will take the comment under advisement to translate to text.
--> --> SBN-TB: Recommend a comment be added as it is not found in DJ delivery.
--> [Dinkinish Lien Reworded]  Several observations are related to standard functional test or calibrations, but several of the PDS4 XML label attributes do not reflect this:
--> --> <purpose> should be Calibration, not Science
--> --> Ensure that the Target <name> (in Target_Identification and geom:Geometry_Target_Identification), Target <type, Target internal_reference, <lucy:target_fov_name> do not reflect DJ as the target, but the correct target.


EN Liens
========

bundle.xml
- Suggestion: on lines , remove
  <Internal_Reference>
    <lidvid_reference>urn:nasa:pds:lucy.ttcam:document::1.0</lidvid_reference>
    <reference_type>bundle_to_document</reference_type>
    <comment>Document collection for the TTCam instrument.</comment>
  </Internal_Reference>
because 1) the LIDVID is for a collection, not a document, and 2) that LIDVID
appears later, more appropriately, as a Bundle_Member_Entry
- Since its collection has this lid_reference, add a lid_reference to
  urn:nasa:pds:context:target:asteroid.52246_donaldjohanson