validate finished for leisa ltes mission
checkBundleLids.py finished for leisa ltes mission


lucy.leisa

*/collection_overview.*
- "collection" is a "reserved base name component" in the PDS4 Standards.
Suggestion: rename these files to "overview.*".

bundle.xml
- This has lid_references to collections not in the bundle under review:
  urn:nasa:pds:lucy.leisa:data_dinkinesh_raw::1.0
  urn:nasa:pds:lucy.leisa:data_dinkinesh_calibrated::1.0
Please ensure those collections will still be in the real bundle.
- Since readme.txt exists, bundle.xml should point to it, something like
  <File_Area_Text>
    <File>
      <file_name>readme.txt</file_name>
    </File>
    <Stream_Text>
      <offset unit="byte">0</offset>
      <parsing_standard_id>7-Bit ASCII Text</parsing_standard_id>
      <record_delimiter>Carriage-Return Line-Feed</record_delimiter>
    </Stream_Text>
  </File_Area_Text>
between Bundle and Bundle_Member_Entry
- Within Reference_List (with stuff chopped), these are incorrect:
  <Internal_Reference>
    <lidvid_reference>urn:nasa:pds:lucy.mission:document::2.0</...>
    <reference_type>bundle_to_document</...>
  <Internal_Reference>
    <lidvid_reference>urn:nasa:pds:lucy.leisa:document::2.0</...>
    <reference_type>bundle_to_document</...>
A bundle_to_document should point to a specific document, not a collection.
A Bundle_Member_Entry points to a collection, including documents. This
bundle.xml already points to u:n:p:lucy.leisa:document that way. It could
also point to the other collection via
  <Bundle_Member_Entry>
    <lidvid_reference>urn:nasa:pds:lucy.mission:document::2.0</...>
    <member_status>Secondary</...>  <!-- not Primary -->
    <reference_type>bundle_has_document_collection</...>

calibration/collection.xml
- The VID in this lidvid_reference
  urn:nasa:pds:lucy.leisa:calibration:collection_overview::1.0
doesn't match the calibration/collection_overview.xml's VID, 2.0
- Suggestion: since labels in this collection have them, add lid_references to
  urn:nasa:pds:context:target:calibration_field.space
  urn:nasa:pds:context:target:calibrator.flat_field
bundle.xml should add these as well

calibration/collection_inventory.csv
- This contains
  P,urn:nasa:pds:lucy.leisa:calibration:collection_overview::1.0
but calibration/collection_overview.xml's VID is 2.0
- This contains many LIDs previously delivered but not included in this
review. That's fine if those files are available in the real collection.
However, 6 such LIDs don't match previously ingested LIDs. In this file:
  P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129330_02298_fflat::1.0
  P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129330_02298_space::1.0
  P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129711_02300_fflat::1.0
  P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129711_02300_space::1.0
  P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129956_02302_fflat::1.0
  P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129956_02302_space::1.0
but collection_calibration_inventory.csv, ingested in 2024.10, has
  P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129330_02298_fflat_03::1.0
  P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129711_02300_fflat_02::1.0
  P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129956_02302_fflat_03::1.0
  P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129330_02298_space_01::1.0
  P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129711_02300_space_01::1.0
  P,urn:nasa:pds:lucy.leisa:calibration:lei_0752129956_02302_space_01::1.0

data_donaldjohanson_calibrated/collection_overview.xml
- Presumably, this file's LID is wrong:
  urn:nasa:pds:lucy.leisa:data_dinkinesh_calibrated:collection_overview
and should be
  urn:nasa:pds:lucy.leisa:data_donaldjohanson_raw:collection_overview
That would solve many missing references in this bundle.

data_donaldjohanson_raw/
- This directory file has 27 labels while data_donaldjohanson_calibrated/
has 17. 10 of the files in _raw have lid_references to calibrated labels
not in this review, e.g. file lei_0798443091_02608_eng_04.xml references
  u:n:p:lucy.leisa:data_donaldjohanson_calibrated:lei_0798443091_02608_sci
which isn't in this review.  This may be an artifcat of selecting files for
the review. Please ensure that the delivered products all refer to existing
calibrated products.

data_donaldjohanson_raw/collection.xml
- Suggestion: since a label in this collection has this, add a lid_reference to
  urn:nasa:pds:context:target:calibrator.internal_source
bundle.xml should add this as well

data_donaldjohanson_raw/collection_overview.xml
- Presumably, this file's LID is wrong:
  urn:nasa:pds:lucy.leisa:data_dinkinesh_raw:collection_overview
and should be
  urn:nasa:pds:lucy.leisa:data_donaldjohanson_raw:collection_overview
That would solve many missing references in this bundle.

document/collection_inventory.csv
- These LIDs are listed here, but the corresponding docs are missing.
  P,urn:nasa:pds:lucy.leisa:document:leisa_sis::1.0
  P,urn:nasa:pds:lucy.leisa:document:lralph_ssr::1.0
Please ensure they will be available in the bundle. Many labels reference them



lucy.llorri

*.xml
- Most (all?) labels have a lid_reference to
  urn:nasa:pds:lucy.llorri:document:llorri_sis
but this delivery doesn't have this file or even a directory document/.
Please ensure that label will be availabe in the bundle.

calibration/collection_inventory.csv
- The labels for the first 8 LIDs listed aren't provided in this review,
but many labels in this review have lid_references to them. Please ensure
they will be availabe in the real bundle.

data_didymos_raw/collection.xml
- typo in lidvid_reference
  urn:nasa:pds:lucy.llorri:data_didymos_raw:collection_ovrview:1.0
should be
  urn:nasa:pds:lucy.llorri:data_didymos_raw:collection_overview:1.0




lucy.ltes


*.xml
- The document/ dir and any associated SIS were not part of this review, but
many files have a lid_ or lidvid_reference to
  urn:nasa:pds:lucy.ltes:document:ltes_sis
Please ensure this will be available in the real bundle.

*/collection_overview.*
- "collection" is a "reserved base name component" in the PDS4 Standards.
Suggestion: rename these files to "overview.*".

bundle.xml
- This has lid_references to collections not in the bundle under review:
  urn:nasa:pds:lucy.ltes:data_dinkinesh_calibrated::1.0
  urn:nasa:pds:lucy.ltes:data_dinkinesh_hkraw::1.0
  urn:nasa:pds:lucy.ltes:data_dinkinesh_raw::1.0
Please ensure those collections will still be in the real bundle.
- Since readme.txt exists, bundle.xml should point to it, something like
  <File_Area_Text>
    <File>
      <file_name>readme.txt</file_name>
    </File>
    <Stream_Text>
      <offset unit="byte">0</offset>
      <parsing_standard_id>7-Bit ASCII Text</parsing_standard_id>
      <record_delimiter>Carriage-Return Line-Feed</record_delimiter>
    </Stream_Text>
  </File_Area_Text>
between Bundle and Bundle_Member_Entry
- The bundle under review has no document/ directory, but bundle.xml has
  <lidvid_reference>urn:nasa:pds:lucy.ltes:document::1.0</...>

data_donaldjohanson_calibrated/collection_overview.xml
- This file's LID is ...:data_dinkinesh_calibrated:...
instead of ...:data_donaldjohanson_calibrated:...
If that's intentional, many files would have to change.

data_donaldjohanson_hkraw/collection.xml
- Suggestion: since the label in this collection has it, add lid_references to
  urn:nasa:pds:context:target:calibrator.unk

data_donaldjohanson_raw/collection.xml
- Suggestion: since labels in this collection have them, add lid_references to
  urn:nasa:pds:context:target:calibration_field.space
  urn:nasa:pds:context:target:calibrator.test_image
  urn:nasa:pds:context:target:calibrator.unk
bundle.xml should add these 3 as well



lucy.mission

document/
- Many labels in other bundles have a lid_reference to
  urn:nasa:pds:lucy.mission:document:lucy_mission_info
which is neither provided nor listed in collection_inventory.csv in this 
review. Please ensure that it exists in the delivered version.



lucy.mvic

*.xml
- The document/ dir and any associated SIS were not part of this review, but
many files have a lid_ or lidvid_reference to
  urn:nasa:pds:lucy.mvic:document:mvic_sis
Please ensure this will be available in the real bundle.

bundle.xml
- This has lid_references to collections not in the bundle under review:
  urn:nasa:pds:lucy.ltes:data_dinkinesh_calibrated::1.0
  urn:nasa:pds:lucy.ltes:data_dinkinesh_raw::1.0
Please ensure those collections will still be in the real bundle.
- Since readme.txt exists, bundle.xml should point to it, something like
  <File_Area_Text>
    <File>
      <file_name>readme.txt</file_name>
    </File>
    <Stream_Text>
      <offset unit="byte">0</offset>
      <parsing_standard_id>7-Bit ASCII Text</parsing_standard_id>
      <record_delimiter>Carriage-Return Line-Feed</record_delimiter>
    </Stream_Text>
  </File_Area_Text>
between Bundle and Bundle_Member_Entry
- Suggestion: since labels in this bundle have them, add lid_references to
  urn:nasa:pds:context:target:asteroid.52246_donaldjohanson
  urn:nasa:pds:context:target:calibration_field.space

calibration/collection.xml
- Suggestion: since labels in this collection have it, add lid_reference to
  urn:nasa:pds:context:target:calibration_field.space
- This lidvid_reference has no corresponding label:
  urn:nasa:pds:lucy.mvic:calibration:collection_overview::1.0
The LID is also listed in calibration/collection_inventory.csv

collection/collection_inventory.csv
- This lists many LIDs not available in this review:
  urn:nasa:pds:lucy.mvic:calibration:mvi_0752129246_02297_space::1.0
  urn:nasa:pds:lucy.mvic:calibration:mvi_0752129547_02299_space::1.0
  urn:nasa:pds:lucy.mvic:calibration:mvi_0752129862_02301_space::1.0
  urn:nasa:pds:lucy.mvic:calibration:mvic_radcal_tdi16::1.0
  urn:nasa:pds:lucy.mvic:calibration:mvic_radcal_tdi32::1.0
  urn:nasa:pds:lucy.mvic:calibration:mvic_radcal_tdi4::1.0
  urn:nasa:pds:lucy.mvic:calibration:mvic_radcal_tdi64::1.0
  urn:nasa:pds:lucy.mvic:calibration:mvic_radcal_tdi8::1.0
Please ensure they'll exist in the delivered bundle, or modify this file.

data_donaldjohanson_calibrated/collection_overview.xml
- This file's LID is ...:data_dinkinesh_calibrated:...
instead of ...:data_donaldjohanson_calibrated:...

data_donaldjohanson_raw/collection_overview.xml
- This file's LID is ...:data_dinkinesh_calibrated:...
instead of ...:data_donaldjohanson_calibrated:...

data_donaldjohanson_raw/mvi_0798391044_02539_eng_03.xml & 4 more
- These have no equivalent in directory data_donaldjohanson_calibrated/, and
each of these five labels has a (missing) lid_reference to the equivalent, e.g.
  urn:nasa:pds:lucy.mvic:data_donaldjohanson_calibrated:mvi_0798391044_02539_sci
Please ensure those labels and data files will be in the real bundle.

document/
- Many labels have lid_references to
  urn:nasa:pds:lucy.mvic:document:mvic_sis
which is neither provided nor listed in collection_inventory.csv in this 
review. Please ensure that it exists in the delivered version.

document/collection.xml
- This lidvid_reference has no corresponding label:
  urn:nasa:pds:lucy.mvic:document:collection_overview::1.0



lucy.rss

data_*.xml
- Suggestion: for the name of urn:nasa:pds:context:instrument:lucy.rss, change
"Lucy Radio Science Subsystem" to "The Lucy Radio Sceince Investigation and
Telecom Subsystem aboard the Lucy spacecraft, Lucy Radio Science" to match
what's in the context product.
- Labels in other bundles that give part of the physical spacecraft as the
target (with type Equipment) have usually (always?) used the spacecraft's 
LID, not the instrument's LID. Is the Radio Science instrument actually
something physical? If so, is the instrument itself or the spacecraft the
target? Suggestion: use the spacecraft, u:n:p:c:instrument_host:spacecraft.lucy

data_donaldjohanson_skyfreq/collection.xml
data_donaldjohanson_sff/collection.xml
data_donaldjohanson_trk234/collection.xml
- These all have a lidvid reference to
  urn:nasa:pds:lucy.rss:document:rss_info
That LID was defined once in a review, but EN hasn't seen it since, and
it's not listed in the existing 
  https://pdssbn.astro.umd.edu/holdings/pds4-lucy.rss-v1.0/document/collection_inventory.csv
Please ensure this LID will be defined eventually.



lucy.ttcam

bundle.xml
- Suggestion: on lines , remove
  <Internal_Reference>
    <lidvid_reference>urn:nasa:pds:lucy.ttcam:document::1.0</lidvid_reference>
    <reference_type>bundle_to_document</reference_type>
    <comment>Document collection for the TTCam instrument.</comment>
  </Internal_Reference>
because 1) the LIDVID is for a collection, not a document, and 2) that LIDVID
appears later, more appropriately, as a Bundle_Member_Entry



comet_afrho

data/db_dust_activity_level.lblx
- Suggestion: add lid_references to the targets in the .csv, e.g.
  <Target_Identification>
    <name>1P/Halley</name>
    <type>Comet</type>
    <Internal_Reference>
      <lid_reference>urn:nasa:pds:context:target:comet.1p_halley</lid_reference>
      <reference_type>data_to_target</reference_type>
    </Internal_Reference>
  </Target_Identification>
This will (someday) aid data search. If you do this, please add the same
lid_references into collection.lblx